All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: Wim Coekaerts <wim.coekaerts@oracle.com>,
	wim@iguana.be, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Fri, 29 Jan 2016 18:12:43 +0300	[thread overview]
Message-ID: <56AB816B.6030900@oracle.com> (raw)
In-Reply-To: <1454017572-5235-1-git-send-email-wim.coekaerts@oracle.com>



On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
<cut>
> +static const struct watchdog_info sun4v_wdt_ident = {
> +	.options =	WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
> +	.identity =	"sun4v hypervisor watchdog",
> +	.firmware_version = 0,
> +};

In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c 
WDIOF_KEEPALIVEPING may be needed here as to enable the support of 
WDIOC_KEEPALIVE ioctl.

Correct? So maybe add it then?

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: Wim Coekaerts <wim.coekaerts@oracle.com>,
	wim@iguana.be, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Fri, 29 Jan 2016 15:12:43 +0000	[thread overview]
Message-ID: <56AB816B.6030900@oracle.com> (raw)
In-Reply-To: <1454017572-5235-1-git-send-email-wim.coekaerts@oracle.com>



On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
<cut>
> +static const struct watchdog_info sun4v_wdt_ident = {
> +	.options =	WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
> +	.identity =	"sun4v hypervisor watchdog",
> +	.firmware_version = 0,
> +};

In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c 
WDIOF_KEEPALIVEPING may be needed here as to enable the support of 
WDIOC_KEEPALIVE ioctl.

Correct? So maybe add it then?

Thanks.

  parent reply	other threads:[~2016-01-29 15:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 21:46 [PATCH v6] Add sun4v_wdt watchdog driver Wim Coekaerts
2016-01-28 21:46 ` Wim Coekaerts
2016-01-28 22:50 ` Julian Calaby
2016-01-28 22:50   ` Julian Calaby
2016-01-28 22:53   ` Wim Coekaerts
2016-01-28 22:53     ` Wim Coekaerts
2016-01-29  0:24     ` Guenter Roeck
2016-01-29  0:24       ` Guenter Roeck
2016-01-29  0:35       ` Wim Coekaerts
2016-01-29  0:35         ` Wim Coekaerts
2016-01-29 11:56 ` Stanislav Kholmanskikh
2016-01-29 11:56   ` Stanislav Kholmanskikh
2016-01-29 15:12 ` Stanislav Kholmanskikh [this message]
2016-01-29 15:12   ` Stanislav Kholmanskikh
2016-01-29 15:23   ` Guenter Roeck
2016-01-29 15:23     ` Guenter Roeck
2016-01-29 17:39     ` Wim Coekaerts
2016-01-29 17:39       ` Wim Coekaerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AB816B.6030900@oracle.com \
    --to=stanislav.kholmanskikh@oracle.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sparclinux@vger.kernel.org \
    --cc=wim.coekaerts@oracle.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.