From: Jianqun Xu <jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org,
huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi
Date: Fri, 19 Feb 2016 10:44:42 +0800 [thread overview]
Message-ID: <56C6819A.8090106@rock-chips.com> (raw)
In-Reply-To: <20160218135751.GE7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Hi Mark
在 18/02/2016 21:57, Mark Brown 写道:
> On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
>
>> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
>> the compatible like:
>> - compatible: should be one of the followings
>> - "rockchip,rk3066-i2s": for rk3066
>> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
>> and the driver only has
>> static const struct of_device_id rockchip_i2s_match[] = {
>> { .compatible = "rockchip,rk3066-i2s", },
>> {},
>> };
>
>> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
>> keep different rules ?
>
> No, that's just something that got missed in review and which should be
> fixed.
>
Got it, it's will be fixed in a separate patch later, thank you very much.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jay.xu@rock-chips.com (Jianqun Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi
Date: Fri, 19 Feb 2016 10:44:42 +0800 [thread overview]
Message-ID: <56C6819A.8090106@rock-chips.com> (raw)
In-Reply-To: <20160218135751.GE7129@sirena.org.uk>
Hi Mark
? 18/02/2016 21:57, Mark Brown ??:
> On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
>
>> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
>> the compatible like:
>> - compatible: should be one of the followings
>> - "rockchip,rk3066-i2s": for rk3066
>> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
>> and the driver only has
>> static const struct of_device_id rockchip_i2s_match[] = {
>> { .compatible = "rockchip,rk3066-i2s", },
>> {},
>> };
>
>> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
>> keep different rules ?
>
> No, that's just something that got missed in review and which should be
> fixed.
>
Got it, it's will be fixed in a separate patch later, thank you very much.
WARNING: multiple messages have this Message-ID (diff)
From: Jianqun Xu <jay.xu@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
jwerner@chromium.org, catalin.marinas@arm.com,
will.deacon@arm.com, sboyd@codeaurora.org,
linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk,
huangtao@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi
Date: Fri, 19 Feb 2016 10:44:42 +0800 [thread overview]
Message-ID: <56C6819A.8090106@rock-chips.com> (raw)
In-Reply-To: <20160218135751.GE7129@sirena.org.uk>
Hi Mark
在 18/02/2016 21:57, Mark Brown 写道:
> On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
>
>> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
>> the compatible like:
>> - compatible: should be one of the followings
>> - "rockchip,rk3066-i2s": for rk3066
>> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
>> and the driver only has
>> static const struct of_device_id rockchip_i2s_match[] = {
>> { .compatible = "rockchip,rk3066-i2s", },
>> {},
>> };
>
>> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
>> keep different rules ?
>
> No, that's just something that got missed in review and which should be
> fixed.
>
Got it, it's will be fixed in a separate patch later, thank you very much.
next prev parent reply other threads:[~2016-02-19 2:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 2:36 [PATCH v2 0/4] Add core dtsi for rk3399 from Rockchip jianqun.xu
2016-02-18 2:36 ` jianqun.xu
2016-02-18 2:36 ` jianqun.xu
2016-02-18 2:36 ` [PATCH v2 1/4] clk: rockchip: add dt-binding header for rk3399 jianqun.xu
2016-02-18 2:36 ` jianqun.xu
[not found] ` <1455762983-29980-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-18 2:36 ` [PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi jianqun.xu
2016-02-18 2:36 ` jianqun.xu
2016-02-18 2:36 ` jianqun.xu
[not found] ` <1455762983-29980-3-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-18 9:41 ` Mark Brown
2016-02-18 9:41 ` Mark Brown
2016-02-18 9:41 ` Mark Brown
[not found] ` <20160218094108.GA7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-18 9:47 ` [PATCH v2.1 " Heiko Stuebner
2016-02-18 9:47 ` Heiko Stuebner
2016-02-18 9:47 ` Heiko Stuebner
2016-02-18 9:57 ` Jianqun Xu
2016-02-18 9:57 ` Jianqun Xu
[not found] ` <56C5959D.3030806-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-18 13:57 ` Mark Brown
2016-02-18 13:57 ` Mark Brown
2016-02-18 13:57 ` Mark Brown
[not found] ` <20160218135751.GE7129-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-19 2:44 ` Jianqun Xu [this message]
2016-02-19 2:44 ` Jianqun Xu
2016-02-19 2:44 ` Jianqun Xu
2016-02-18 2:36 ` [PATCH v2 3/4] dt-bindings: add documentation of rk3399 clock controller jianqun.xu
2016-02-18 2:36 ` jianqun.xu
2016-02-18 2:36 ` [PATCH v2 4/4] ARM64: dts: rockchip: add core dtsi file for rk3399 jianqun.xu
2016-02-18 2:36 ` jianqun.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6819A.8090106@rock-chips.com \
--to=jay.xu-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.