From: Sinan Kaya <okaya@codeaurora.org>
To: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, eric.auger@linaro.org
Cc: shankerd@codeaurora.org, vikrams@codeaurora.org,
marc.zyngier@arm.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, vinod.koul@intel.com,
agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Alex Williamson <alex.williamson@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver
Date: Tue, 8 Mar 2016 10:37:34 -0500 [thread overview]
Message-ID: <56DEF1BE.8010701@codeaurora.org> (raw)
In-Reply-To: <1457451209-21462-1-git-send-email-okaya@codeaurora.org>
On 3/8/2016 10:33 AM, Sinan Kaya wrote:
> + int rc = 0;
> +
I should have initialized this to -1.
> + vdev->reset = vfio_platform_lookup_reset(vdev->compat, vdev->acpihid,
> + &vdev->reset_module);
> + if (vdev->reset)
> + return 0;
> +
> + if (vdev->acpihid)
> + rc = request_module("vfio-reset:%s", vdev->acpihid);
> +
> + if (rc && vdev->compat)
> + rc = request_module("vfio-reset:%s", vdev->compat);
> +
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver
Date: Tue, 8 Mar 2016 10:37:34 -0500 [thread overview]
Message-ID: <56DEF1BE.8010701@codeaurora.org> (raw)
In-Reply-To: <1457451209-21462-1-git-send-email-okaya@codeaurora.org>
On 3/8/2016 10:33 AM, Sinan Kaya wrote:
> + int rc = 0;
> +
I should have initialized this to -1.
> + vdev->reset = vfio_platform_lookup_reset(vdev->compat, vdev->acpihid,
> + &vdev->reset_module);
> + if (vdev->reset)
> + return 0;
> +
> + if (vdev->acpihid)
> + rc = request_module("vfio-reset:%s", vdev->acpihid);
> +
> + if (rc && vdev->compat)
> + rc = request_module("vfio-reset:%s", vdev->compat);
> +
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-03-08 15:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 15:33 [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver Sinan Kaya
2016-03-08 15:33 ` Sinan Kaya
2016-03-08 15:33 ` [PATCH 2/2] vfio, platform: add QTI HIDMA " Sinan Kaya
2016-03-08 15:33 ` Sinan Kaya
2016-03-08 15:37 ` Sinan Kaya [this message]
2016-03-08 15:37 ` [PATCH 1/2] vfio, platform: add support for ACPI while detecting the " Sinan Kaya
[not found] ` <56DEF1BE.8010701-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-10 7:58 ` Dan Carpenter
2016-03-10 7:58 ` Dan Carpenter
2016-03-10 7:58 ` Dan Carpenter
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 10:11 ` Eric Auger
2016-03-10 10:11 ` Eric Auger
2016-03-10 17:13 ` Sinan Kaya
2016-03-10 17:13 ` Sinan Kaya
2016-03-11 3:48 ` Eric Auger
2016-03-11 3:48 ` Eric Auger
2016-03-11 16:09 ` Sinan Kaya
2016-03-11 16:09 ` Sinan Kaya
[not found] ` <56E1AB38.8020702-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEF1BE.8010701@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=b.reynal@virtualopensystems.com \
--cc=cov@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@linaro.org \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=shankerd@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=vikrams@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.