From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
vikrams-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
marc.zyngier-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Baptiste Reynal
<b.reynal-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>,
Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver
Date: Thu, 10 Mar 2016 10:58:30 +0300 [thread overview]
Message-ID: <20160310075830.GB5273@mwanda> (raw)
In-Reply-To: <56DEF1BE.8010701-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote:
> On 3/8/2016 10:33 AM, Sinan Kaya wrote:
> > + int rc = 0;
> > +
>
> I should have initialized this to -1.
>
-1 is a magic number which stands for -EPERM which is wrong. Use
-ENODEV.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver
Date: Thu, 10 Mar 2016 10:58:30 +0300 [thread overview]
Message-ID: <20160310075830.GB5273@mwanda> (raw)
In-Reply-To: <56DEF1BE.8010701@codeaurora.org>
On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote:
> On 3/8/2016 10:33 AM, Sinan Kaya wrote:
> > + int rc = 0;
> > +
>
> I should have initialized this to -1.
>
-1 is a magic number which stands for -EPERM which is wrong. Use
-ENODEV.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, eric.auger@linaro.org, shankerd@codeaurora.org,
vikrams@codeaurora.org, marc.zyngier@arm.com,
mark.rutland@arm.com, devicetree@vger.kernel.org,
vinod.koul@intel.com, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Alex Williamson <alex.williamson@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver
Date: Thu, 10 Mar 2016 10:58:30 +0300 [thread overview]
Message-ID: <20160310075830.GB5273@mwanda> (raw)
In-Reply-To: <56DEF1BE.8010701@codeaurora.org>
On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote:
> On 3/8/2016 10:33 AM, Sinan Kaya wrote:
> > + int rc = 0;
> > +
>
> I should have initialized this to -1.
>
-1 is a magic number which stands for -EPERM which is wrong. Use
-ENODEV.
regards,
dan carpenter
next prev parent reply other threads:[~2016-03-10 7:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 15:33 [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver Sinan Kaya
2016-03-08 15:33 ` Sinan Kaya
2016-03-08 15:33 ` [PATCH 2/2] vfio, platform: add QTI HIDMA " Sinan Kaya
2016-03-08 15:33 ` Sinan Kaya
2016-03-08 15:37 ` [PATCH 1/2] vfio, platform: add support for ACPI while detecting the " Sinan Kaya
2016-03-08 15:37 ` Sinan Kaya
[not found] ` <56DEF1BE.8010701-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-10 7:58 ` Dan Carpenter [this message]
2016-03-10 7:58 ` Dan Carpenter
2016-03-10 7:58 ` Dan Carpenter
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 17:00 ` Sinan Kaya
2016-03-10 10:11 ` Eric Auger
2016-03-10 10:11 ` Eric Auger
2016-03-10 17:13 ` Sinan Kaya
2016-03-10 17:13 ` Sinan Kaya
2016-03-11 3:48 ` Eric Auger
2016-03-11 3:48 ` Eric Auger
2016-03-11 16:09 ` Sinan Kaya
2016-03-11 16:09 ` Sinan Kaya
[not found] ` <56E1AB38.8020702-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
2016-03-11 4:05 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310075830.GB5273@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=b.reynal-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
--cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vikrams-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.