From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic
Date: Fri, 11 Mar 2016 14:09:00 +0100 [thread overview]
Message-ID: <56E2C36C.6030709@samsung.com> (raw)
In-Reply-To: <56DD9086.7070903@osg.samsung.com>
On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote:
> Thanks, I just noticed another similar issue in the driver now and is
> that fimc_is_parse_sensor_config() uses the same struct device_node *
> for looking up the I2C sensor, port and endpoint and thus not doing a
> of_node_put() for all the nodes on the error path.
>
> I think the right fix is to have a separate struct device_node * for
> each so their reference counter can be incremented and decremented.
Yes, the node reference count is indeed not handled very well there,
feel free to submit a patch to fix that bug.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic
Date: Fri, 11 Mar 2016 14:09:00 +0100 [thread overview]
Message-ID: <56E2C36C.6030709@samsung.com> (raw)
In-Reply-To: <56DD9086.7070903@osg.samsung.com>
On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote:
> Thanks, I just noticed another similar issue in the driver now and is
> that fimc_is_parse_sensor_config() uses the same struct device_node *
> for looking up the I2C sensor, port and endpoint and thus not doing a
> of_node_put() for all the nodes on the error path.
>
> I think the right fix is to have a separate struct device_node * for
> each so their reference counter can be incremented and decremented.
Yes, the node reference count is indeed not handled very well there,
feel free to submit a patch to fix that bug.
--
Regards,
Sylwester
next prev parent reply other threads:[~2016-03-11 13:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 20:20 [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas
2016-03-04 20:20 ` [PATCH 1/2] [media] exynos4-is: Put node before s5pcsis_parse_dt() return error Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas
2016-03-04 20:20 ` [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas
2016-03-11 13:03 ` Sylwester Nawrocki
2016-03-11 13:03 ` Sylwester Nawrocki
2016-03-11 14:55 ` Javier Martinez Canillas
2016-03-11 14:55 ` Javier Martinez Canillas
2016-03-22 20:19 ` Javier Martinez Canillas
2016-03-22 20:19 ` Javier Martinez Canillas
2016-03-05 4:35 ` [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic Krzysztof Kozlowski
2016-03-05 4:35 ` Krzysztof Kozlowski
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 14:30 ` Javier Martinez Canillas
2016-03-07 14:30 ` Javier Martinez Canillas
2016-03-11 13:09 ` Sylwester Nawrocki [this message]
2016-03-11 13:09 ` Sylwester Nawrocki
2016-03-11 14:39 ` Javier Martinez Canillas
2016-03-11 14:39 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2C36C.6030709@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.