From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com
Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk,
linux.amoon@gmail.com, m.reichl@fivetechno.de,
tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK
Date: Tue, 12 Apr 2016 13:25:10 +0200 [thread overview]
Message-ID: <570CDB16.2050001@samsung.com> (raw)
In-Reply-To: <1460091646-28701-6-git-send-email-cw00.choi@samsung.com>
On 04/08/2016 07:00 AM, Chanwoo Choi wrote:
> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI
> Bus. This clock should be handled in Bus frequency scaling driver.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++-------------
> 1 file changed, 55 insertions(+), 30 deletions(-)
The IDs itself look good but you are not adding only clock ID. You are
changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should
be explained in the commit message why you need it. Probably it should
be also in separate commit.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK
Date: Tue, 12 Apr 2016 13:25:10 +0200 [thread overview]
Message-ID: <570CDB16.2050001@samsung.com> (raw)
In-Reply-To: <1460091646-28701-6-git-send-email-cw00.choi@samsung.com>
On 04/08/2016 07:00 AM, Chanwoo Choi wrote:
> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI
> Bus. This clock should be handled in Bus frequency scaling driver.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++-------------
> 1 file changed, 55 insertions(+), 30 deletions(-)
The IDs itself look good but you are not adding only clock ID. You are
changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should
be explained in the commit message why you need it. Probably it should
be also in separate commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-04-12 11:25 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 5:00 [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-08 5:00 ` [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 8:07 ` Krzysztof Kozlowski
2016-04-12 8:07 ` Krzysztof Kozlowski
2016-04-15 5:13 ` Chanwoo Choi
2016-04-15 5:13 ` Chanwoo Choi
2016-04-08 5:00 ` [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for Exynos5422 bus Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-11 15:45 ` Rob Herring
2016-04-11 15:45 ` Rob Herring
2016-04-15 6:08 ` Chanwoo Choi
2016-04-15 6:08 ` Chanwoo Choi
[not found] ` <1460091646-28701-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-08 5:00 ` [PATCH 3/7] ARM: dts: Add NoC Probe dt node for Exynos542x SoC Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 8:14 ` Krzysztof Kozlowski
2016-04-12 8:14 ` Krzysztof Kozlowski
2016-04-14 5:48 ` Chanwoo Choi
2016-04-14 5:48 ` Chanwoo Choi
2016-04-08 5:00 ` [PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of " Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 11:29 ` Krzysztof Kozlowski
2016-04-12 11:29 ` Krzysztof Kozlowski
2016-04-08 5:00 ` [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 11:25 ` Krzysztof Kozlowski [this message]
2016-04-12 11:25 ` Krzysztof Kozlowski
2016-04-13 6:20 ` Tomasz Figa
2016-04-13 6:20 ` Tomasz Figa
2016-04-14 6:28 ` Chanwoo Choi
2016-04-14 6:28 ` Chanwoo Choi
2016-04-08 5:00 ` [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 10:53 ` Krzysztof Kozlowski
2016-04-12 10:53 ` Krzysztof Kozlowski
2016-04-13 23:16 ` Chanwoo Choi
2016-04-13 23:16 ` Chanwoo Choi
2016-04-08 5:00 ` [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT for exynos5422-odroidxu3 Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-08 5:00 ` Chanwoo Choi
2016-04-12 10:59 ` Krzysztof Kozlowski
2016-04-12 10:59 ` Krzysztof Kozlowski
2016-04-13 23:14 ` Chanwoo Choi
2016-04-13 23:14 ` Chanwoo Choi
2016-04-08 12:55 ` [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Markus Reichl
2016-04-08 12:55 ` Markus Reichl
2016-04-08 12:55 ` Markus Reichl
2016-04-08 18:25 ` Chanwoo Choi
2016-04-08 18:25 ` Chanwoo Choi
2016-04-08 18:25 ` Chanwoo Choi
2016-04-08 18:11 ` Anand Moon
2016-04-08 18:11 ` Anand Moon
[not found] ` <CANAwSgQuWBRiRhjd-E-WaSdhe2njE262CEG8uVH83jJDGFJVKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-08 18:24 ` Chanwoo Choi
2016-04-08 18:24 ` Chanwoo Choi
2016-04-08 18:24 ` Chanwoo Choi
2016-04-11 2:16 ` Chanwoo Choi
2016-04-11 2:16 ` Chanwoo Choi
2016-04-11 2:16 ` Chanwoo Choi
2016-04-11 4:01 ` Anand Moon
2016-04-11 4:01 ` Anand Moon
2016-04-11 4:01 ` Anand Moon
2016-04-11 4:03 ` Chanwoo Choi
2016-04-11 4:03 ` Chanwoo Choi
2016-04-11 4:03 ` Chanwoo Choi
2016-04-11 4:15 ` Chanwoo Choi
2016-04-11 4:15 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CDB16.2050001@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.