All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com
Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	linux.amoon@gmail.com, m.reichl@fivetechno.de,
	tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT for exynos5422-odroidxu3
Date: Thu, 14 Apr 2016 08:14:57 +0900	[thread overview]
Message-ID: <570ED2F1.1080006@samsung.com> (raw)
In-Reply-To: <570CD4F7.6000700@samsung.com>

On 2016년 04월 12일 19:59, Krzysztof Kozlowski wrote:
> On 04/08/2016 07:00 AM, Chanwoo Choi wrote:
>> This patch adds the bus device tree nodes for INT (Internal) block
>> to enable the AMBA bus frequency scaling and add the NoC (Network on Chip)
>> Probe Device Tree node to measure the bandwidht for AMBA AXI bus.
>>
>> The WCORE bus bus is parent device in INT block using VDD_INT.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 99 ++++++++++++++++++++++
>>  1 file changed, 99 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1bd507bfa750..2a74abe6fc5d 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -361,6 +361,22 @@
>>  	cap-sd-highspeed;
>>  };
>>  
>> +&nocp_mem0_0 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_1 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_2 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_3 {
>> +	status = "okay";
>> +};
>> +
>>  &pinctrl_0 {
>>  	hdmi_hpd_irq: hdmi-hpd-irq {
>>  		samsung,pins = "gpx3-7";
>> @@ -432,3 +448,86 @@
>>  	vdd33-supply = <&ldo9_reg>;
>>  	vdd10-supply = <&ldo11_reg>;
>>  };
>> +
>> +&bus_wcore {
>> +	devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
>> +			<&nocp_mem0_2>, <&nocp_mem0_3>;
>> +	vdd-supply = <&buck3_reg>;
>> +	exynos,saturation-ratio = <100>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_noc {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys_apb {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys2 {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_mfc {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_gen {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_peri {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_g2d {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_g2d_acp {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_jpeg {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_jpeg_apb {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_disp1_fimd {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_disp1 {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_gscl_scaler {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_mscl {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
> 
> Could you put the bus nodes in alphabetical order, both between them and
> in relation to others (so before &clock_audss)? Let's keep the file ordered.

OK. I'll reorder them.

Best Regards,
Chanwoo Choi

WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT for exynos5422-odroidxu3
Date: Thu, 14 Apr 2016 08:14:57 +0900	[thread overview]
Message-ID: <570ED2F1.1080006@samsung.com> (raw)
In-Reply-To: <570CD4F7.6000700@samsung.com>

On 2016? 04? 12? 19:59, Krzysztof Kozlowski wrote:
> On 04/08/2016 07:00 AM, Chanwoo Choi wrote:
>> This patch adds the bus device tree nodes for INT (Internal) block
>> to enable the AMBA bus frequency scaling and add the NoC (Network on Chip)
>> Probe Device Tree node to measure the bandwidht for AMBA AXI bus.
>>
>> The WCORE bus bus is parent device in INT block using VDD_INT.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 99 ++++++++++++++++++++++
>>  1 file changed, 99 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1bd507bfa750..2a74abe6fc5d 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -361,6 +361,22 @@
>>  	cap-sd-highspeed;
>>  };
>>  
>> +&nocp_mem0_0 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_1 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_2 {
>> +	status = "okay";
>> +};
>> +
>> +&nocp_mem0_3 {
>> +	status = "okay";
>> +};
>> +
>>  &pinctrl_0 {
>>  	hdmi_hpd_irq: hdmi-hpd-irq {
>>  		samsung,pins = "gpx3-7";
>> @@ -432,3 +448,86 @@
>>  	vdd33-supply = <&ldo9_reg>;
>>  	vdd10-supply = <&ldo11_reg>;
>>  };
>> +
>> +&bus_wcore {
>> +	devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
>> +			<&nocp_mem0_2>, <&nocp_mem0_3>;
>> +	vdd-supply = <&buck3_reg>;
>> +	exynos,saturation-ratio = <100>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_noc {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys_apb {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_fsys2 {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_mfc {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_gen {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_peri {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_g2d {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_g2d_acp {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_jpeg {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_jpeg_apb {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_disp1_fimd {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_disp1 {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_gscl_scaler {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
>> +
>> +&bus_mscl {
>> +	devfreq = <&bus_wcore>;
>> +	status = "okay";
>> +};
> 
> Could you put the bus nodes in alphabetical order, both between them and
> in relation to others (so before &clock_audss)? Let's keep the file ordered.

OK. I'll reorder them.

Best Regards,
Chanwoo Choi

  reply	other threads:[~2016-04-13 23:15 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08  5:00 [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Chanwoo Choi
2016-04-08  5:00 ` Chanwoo Choi
2016-04-08  5:00 ` [PATCH 1/7] PM / devfreq: event: Add new Exynos NoC probe driver Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-12  8:07   ` Krzysztof Kozlowski
2016-04-12  8:07     ` Krzysztof Kozlowski
2016-04-15  5:13     ` Chanwoo Choi
2016-04-15  5:13       ` Chanwoo Choi
2016-04-08  5:00 ` [PATCH 2/7] PM / devfreq: exynos: Add the detailed correlation for Exynos5422 bus Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-11 15:45   ` Rob Herring
2016-04-11 15:45     ` Rob Herring
2016-04-15  6:08     ` Chanwoo Choi
2016-04-15  6:08       ` Chanwoo Choi
     [not found] ` <1460091646-28701-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-04-08  5:00   ` [PATCH 3/7] ARM: dts: Add NoC Probe dt node for Exynos542x SoC Chanwoo Choi
2016-04-08  5:00     ` Chanwoo Choi
2016-04-08  5:00     ` Chanwoo Choi
2016-04-12  8:14     ` Krzysztof Kozlowski
2016-04-12  8:14       ` Krzysztof Kozlowski
2016-04-14  5:48       ` Chanwoo Choi
2016-04-14  5:48         ` Chanwoo Choi
2016-04-08  5:00 ` [PATCH 4/7] dt-bindings: clock: Add the clock id for ACLK clock of " Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-12 11:29   ` Krzysztof Kozlowski
2016-04-12 11:29     ` Krzysztof Kozlowski
2016-04-08  5:00 ` [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-12 11:25   ` Krzysztof Kozlowski
2016-04-12 11:25     ` Krzysztof Kozlowski
2016-04-13  6:20     ` Tomasz Figa
2016-04-13  6:20       ` Tomasz Figa
2016-04-14  6:28       ` Chanwoo Choi
2016-04-14  6:28         ` Chanwoo Choi
2016-04-08  5:00 ` [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-12 10:53   ` Krzysztof Kozlowski
2016-04-12 10:53     ` Krzysztof Kozlowski
2016-04-13 23:16     ` Chanwoo Choi
2016-04-13 23:16       ` Chanwoo Choi
2016-04-08  5:00 ` [PATCH 7/7] ARM: dts: Add support of Bus frequency using VDD_INT for exynos5422-odroidxu3 Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-08  5:00   ` Chanwoo Choi
2016-04-12 10:59   ` Krzysztof Kozlowski
2016-04-12 10:59     ` Krzysztof Kozlowski
2016-04-13 23:14     ` Chanwoo Choi [this message]
2016-04-13 23:14       ` Chanwoo Choi
2016-04-08 12:55 ` [PATCH 0/7] PM / devfreq: Add NoCP devfreq-event and support busfreq on exyno5422-odroidxu3 Markus Reichl
2016-04-08 12:55   ` Markus Reichl
2016-04-08 12:55   ` Markus Reichl
2016-04-08 18:25   ` Chanwoo Choi
2016-04-08 18:25     ` Chanwoo Choi
2016-04-08 18:25     ` Chanwoo Choi
2016-04-08 18:11 ` Anand Moon
2016-04-08 18:11   ` Anand Moon
     [not found]   ` <CANAwSgQuWBRiRhjd-E-WaSdhe2njE262CEG8uVH83jJDGFJVKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-08 18:24     ` Chanwoo Choi
2016-04-08 18:24       ` Chanwoo Choi
2016-04-08 18:24       ` Chanwoo Choi
2016-04-11  2:16       ` Chanwoo Choi
2016-04-11  2:16         ` Chanwoo Choi
2016-04-11  2:16         ` Chanwoo Choi
2016-04-11  4:01         ` Anand Moon
2016-04-11  4:01           ` Anand Moon
2016-04-11  4:01           ` Anand Moon
2016-04-11  4:03           ` Chanwoo Choi
2016-04-11  4:03             ` Chanwoo Choi
2016-04-11  4:03             ` Chanwoo Choi
2016-04-11  4:15 ` Chanwoo Choi
2016-04-11  4:15   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570ED2F1.1080006@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=linux@arm.linux.org.uk \
    --cc=m.reichl@fivetechno.de \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tjakobi@math.uni-bielefeld.de \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.