* [PATCH] Access c_ispeed and c_ospeed via APIs
[not found] ` <56E91CC8.9060907@dest-unreach.org>
@ 2016-04-12 17:53 ` Khem Raj
2016-04-12 21:05 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2016-04-12 17:53 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer, Bruce Ashfield
FYI
---------- Forwarded message ----------
From: Gerhard Rieger <gerhard@dest-unreach.org>
Date: Wed, Mar 16, 2016 at 4:43 AM
Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
To: Khem Raj <raj.khem@gmail.com>
Thank you, I will check this patch!
- Gerhard
Am 15.03.2016 um 22:39 schrieb Khem Raj:
> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
> instead of operating on c_ispeed and c_ospeed termios structure
> members directly because they are not guaranteed to exist on all
> libc implementations
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> xioinitialize.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xioinitialize.c b/xioinitialize.c
> index 9f50155..632ca4c 100644
> --- a/xioinitialize.c
> +++ b/xioinitialize.c
> @@ -65,10 +65,10 @@ int xioinitialize(void) {
> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET != -1)
> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
> - tdata.termarg.c_ispeed = 0x56789abc;
> - tdata.termarg.c_ospeed = 0x6789abcd;
> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
> + cfsetispeed(&tdata.termarg, 0x56789abc);
> + cfsetospeed(&tdata.termarg, 0x6789abcd);
> + assert(cfgetispeed(&tdata.termarg) == tdata.speeds[ISPEED_OFFSET]);
> + assert(cfgetospeed(&tdata.termarg) == tdata.speeds[OSPEED_OFFSET]);
> #endif
> #endif
> #endif
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-12 17:53 ` [PATCH] Access c_ispeed and c_ospeed via APIs Khem Raj
@ 2016-04-12 21:05 ` Bruce Ashfield
2016-04-12 22:20 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2016-04-12 21:05 UTC (permalink / raw)
To: Khem Raj, Patches and discussions about the oe-core layer
On 2016-04-12 1:53 PM, Khem Raj wrote:
> FYI
Thanks. I can also confirm that when I dropped the patch, I'm
back up and running assertion free.
Bruce
>
> ---------- Forwarded message ----------
> From: Gerhard Rieger <gerhard@dest-unreach.org>
> Date: Wed, Mar 16, 2016 at 4:43 AM
> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
> To: Khem Raj <raj.khem@gmail.com>
>
>
> Thank you, I will check this patch!
> - Gerhard
>
>
> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>> instead of operating on c_ispeed and c_ospeed termios structure
>> members directly because they are not guaranteed to exist on all
>> libc implementations
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> xioinitialize.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/xioinitialize.c b/xioinitialize.c
>> index 9f50155..632ca4c 100644
>> --- a/xioinitialize.c
>> +++ b/xioinitialize.c
>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET != -1)
>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>> - tdata.termarg.c_ispeed = 0x56789abc;
>> - tdata.termarg.c_ospeed = 0x6789abcd;
>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>> + assert(cfgetispeed(&tdata.termarg) == tdata.speeds[ISPEED_OFFSET]);
>> + assert(cfgetospeed(&tdata.termarg) == tdata.speeds[OSPEED_OFFSET]);
>> #endif
>> #endif
>> #endif
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-12 21:05 ` Bruce Ashfield
@ 2016-04-12 22:20 ` Khem Raj
[not found] ` <CAMKF1srQ5ayOr3ha=YTTGBS-ovX8Ht41ODoNaSEHBGW9EfjFGA@mail.gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2016-04-12 22:20 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]
Since you have it reproduced. Can you check which of the api call is
failing?
On Apr 12, 2016 5:05 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
wrote:
> On 2016-04-12 1:53 PM, Khem Raj wrote:
>
>> FYI
>>
>
> Thanks. I can also confirm that when I dropped the patch, I'm
> back up and running assertion free.
>
> Bruce
>
>
>> ---------- Forwarded message ----------
>> From: Gerhard Rieger <gerhard@dest-unreach.org>
>> Date: Wed, Mar 16, 2016 at 4:43 AM
>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
>> To: Khem Raj <raj.khem@gmail.com>
>>
>>
>> Thank you, I will check this patch!
>> - Gerhard
>>
>>
>> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>>
>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>>> instead of operating on c_ispeed and c_ospeed termios structure
>>> members directly because they are not guaranteed to exist on all
>>> libc implementations
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> xioinitialize.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/xioinitialize.c b/xioinitialize.c
>>> index 9f50155..632ca4c 100644
>>> --- a/xioinitialize.c
>>> +++ b/xioinitialize.c
>>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET !=
>>> -1)
>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>>> - tdata.termarg.c_ispeed = 0x56789abc;
>>> - tdata.termarg.c_ospeed = 0x6789abcd;
>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>>> + assert(cfgetispeed(&tdata.termarg) ==
>>> tdata.speeds[ISPEED_OFFSET]);
>>> + assert(cfgetospeed(&tdata.termarg) ==
>>> tdata.speeds[OSPEED_OFFSET]);
>>> #endif
>>> #endif
>>> #endif
>>>
>>>
>
[-- Attachment #2: Type: text/html, Size: 2962 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
[not found] ` <CAMKF1sqBwbkHWQBBzX8jbK0SoZtcMr6MO2ZSZ9dcMJJns6x+eQ@mail.gmail.com>
@ 2016-04-12 22:33 ` Khem Raj
2016-04-13 15:57 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2016-04-12 22:33 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]
I think I see the problem now. The constant should be converted to use Bnn
values. When calling the baudrate apis. I will send a patch for you to test
once I am close to computer
On Apr 12, 2016 6:20 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
Since you have it reproduced. Can you check which of the api call is
failing?
On Apr 12, 2016 5:05 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
wrote:
> On 2016-04-12 1:53 PM, Khem Raj wrote:
>
>> FYI
>>
>
> Thanks. I can also confirm that when I dropped the patch, I'm
> back up and running assertion free.
>
> Bruce
>
>
>> ---------- Forwarded message ----------
>> From: Gerhard Rieger <gerhard@dest-unreach.org>
>> Date: Wed, Mar 16, 2016 at 4:43 AM
>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
>> To: Khem Raj <raj.khem@gmail.com>
>>
>>
>> Thank you, I will check this patch!
>> - Gerhard
>>
>>
>> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>>
>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>>> instead of operating on c_ispeed and c_ospeed termios structure
>>> members directly because they are not guaranteed to exist on all
>>> libc implementations
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> xioinitialize.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/xioinitialize.c b/xioinitialize.c
>>> index 9f50155..632ca4c 100644
>>> --- a/xioinitialize.c
>>> +++ b/xioinitialize.c
>>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET !=
>>> -1)
>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>>> - tdata.termarg.c_ispeed = 0x56789abc;
>>> - tdata.termarg.c_ospeed = 0x6789abcd;
>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>>> + assert(cfgetispeed(&tdata.termarg) ==
>>> tdata.speeds[ISPEED_OFFSET]);
>>> + assert(cfgetospeed(&tdata.termarg) ==
>>> tdata.speeds[OSPEED_OFFSET]);
>>> #endif
>>> #endif
>>> #endif
>>>
>>>
>
[-- Attachment #2: Type: text/html, Size: 3491 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-12 22:33 ` Khem Raj
@ 2016-04-13 15:57 ` Khem Raj
2016-04-13 15:59 ` Bruce Ashfield
2016-04-13 17:15 ` Bruce Ashfield
0 siblings, 2 replies; 8+ messages in thread
From: Khem Raj @ 2016-04-13 15:57 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On Tue, Apr 12, 2016 at 3:33 PM, Khem Raj <raj.khem@gmail.com> wrote:
> I think I see the problem now. The constant should be converted to use Bnn
> values. When calling the baudrate apis. I will send a patch for you to test
> once I am close to computer
I have sent a potential patch.
http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120229.html
It worked on musl env that I had ready here. Can you test it
with your env and make sure it works for you ?
>
> On Apr 12, 2016 6:20 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
> Since you have it reproduced. Can you check which of the api call is
> failing?
>
> On Apr 12, 2016 5:05 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
> wrote:
>>
>> On 2016-04-12 1:53 PM, Khem Raj wrote:
>>>
>>> FYI
>>
>>
>> Thanks. I can also confirm that when I dropped the patch, I'm
>> back up and running assertion free.
>>
>> Bruce
>>
>>>
>>> ---------- Forwarded message ----------
>>> From: Gerhard Rieger <gerhard@dest-unreach.org>
>>> Date: Wed, Mar 16, 2016 at 4:43 AM
>>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
>>> To: Khem Raj <raj.khem@gmail.com>
>>>
>>>
>>> Thank you, I will check this patch!
>>> - Gerhard
>>>
>>>
>>> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>>>>
>>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>>>> instead of operating on c_ispeed and c_ospeed termios structure
>>>> members directly because they are not guaranteed to exist on all
>>>> libc implementations
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> xioinitialize.c | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/xioinitialize.c b/xioinitialize.c
>>>> index 9f50155..632ca4c 100644
>>>> --- a/xioinitialize.c
>>>> +++ b/xioinitialize.c
>>>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET !=
>>>> -1)
>>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>>>> - tdata.termarg.c_ispeed = 0x56789abc;
>>>> - tdata.termarg.c_ospeed = 0x6789abcd;
>>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>>>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>>>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>>>> + assert(cfgetispeed(&tdata.termarg) ==
>>>> tdata.speeds[ISPEED_OFFSET]);
>>>> + assert(cfgetospeed(&tdata.termarg) ==
>>>> tdata.speeds[OSPEED_OFFSET]);
>>>> #endif
>>>> #endif
>>>> #endif
>>>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-13 15:57 ` Khem Raj
@ 2016-04-13 15:59 ` Bruce Ashfield
2016-04-13 17:15 ` Bruce Ashfield
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2016-04-13 15:59 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 2016-04-13 11:57 AM, Khem Raj wrote:
> On Tue, Apr 12, 2016 at 3:33 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> I think I see the problem now. The constant should be converted to use Bnn
>> values. When calling the baudrate apis. I will send a patch for you to test
>> once I am close to computer
>
> I have sent a potential patch.
>
> http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120229.html
>
> It worked on musl env that I had ready here. Can you test it
> with your env and make sure it works for you ?
Will do. Launching builds now. I'll follow up once I know one way
or another.
Bruce
>
>
>
>
>>
>> On Apr 12, 2016 6:20 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>
>> Since you have it reproduced. Can you check which of the api call is
>> failing?
>>
>> On Apr 12, 2016 5:05 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
>> wrote:
>>>
>>> On 2016-04-12 1:53 PM, Khem Raj wrote:
>>>>
>>>> FYI
>>>
>>>
>>> Thanks. I can also confirm that when I dropped the patch, I'm
>>> back up and running assertion free.
>>>
>>> Bruce
>>>
>>>>
>>>> ---------- Forwarded message ----------
>>>> From: Gerhard Rieger <gerhard@dest-unreach.org>
>>>> Date: Wed, Mar 16, 2016 at 4:43 AM
>>>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
>>>> To: Khem Raj <raj.khem@gmail.com>
>>>>
>>>>
>>>> Thank you, I will check this patch!
>>>> - Gerhard
>>>>
>>>>
>>>> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>>>>>
>>>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>>>>> instead of operating on c_ispeed and c_ospeed termios structure
>>>>> members directly because they are not guaranteed to exist on all
>>>>> libc implementations
>>>>>
>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>> ---
>>>>> xioinitialize.c | 8 ++++----
>>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/xioinitialize.c b/xioinitialize.c
>>>>> index 9f50155..632ca4c 100644
>>>>> --- a/xioinitialize.c
>>>>> +++ b/xioinitialize.c
>>>>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET !=
>>>>> -1)
>>>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>>>>> - tdata.termarg.c_ispeed = 0x56789abc;
>>>>> - tdata.termarg.c_ospeed = 0x6789abcd;
>>>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>>>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>>>>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>>>>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>>>>> + assert(cfgetispeed(&tdata.termarg) ==
>>>>> tdata.speeds[ISPEED_OFFSET]);
>>>>> + assert(cfgetospeed(&tdata.termarg) ==
>>>>> tdata.speeds[OSPEED_OFFSET]);
>>>>> #endif
>>>>> #endif
>>>>> #endif
>>>>>
>>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-13 15:57 ` Khem Raj
2016-04-13 15:59 ` Bruce Ashfield
@ 2016-04-13 17:15 ` Bruce Ashfield
2016-04-13 17:17 ` Khem Raj
1 sibling, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2016-04-13 17:15 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On 2016-04-13 11:57 AM, Khem Raj wrote:
> On Tue, Apr 12, 2016 at 3:33 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> I think I see the problem now. The constant should be converted to use Bnn
>> values. When calling the baudrate apis. I will send a patch for you to test
>> once I am close to computer
>
> I have sent a potential patch.
>
> http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120229.html
>
> It worked on musl env that I had ready here. Can you test it
> with your env and make sure it works for you ?
confirmed. I reverted my local change, applied this and socat is
working without the assert.
Bruce
>
>
>
>
>>
>> On Apr 12, 2016 6:20 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>
>> Since you have it reproduced. Can you check which of the api call is
>> failing?
>>
>> On Apr 12, 2016 5:05 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com>
>> wrote:
>>>
>>> On 2016-04-12 1:53 PM, Khem Raj wrote:
>>>>
>>>> FYI
>>>
>>>
>>> Thanks. I can also confirm that when I dropped the patch, I'm
>>> back up and running assertion free.
>>>
>>> Bruce
>>>
>>>>
>>>> ---------- Forwarded message ----------
>>>> From: Gerhard Rieger <gerhard@dest-unreach.org>
>>>> Date: Wed, Mar 16, 2016 at 4:43 AM
>>>> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
>>>> To: Khem Raj <raj.khem@gmail.com>
>>>>
>>>>
>>>> Thank you, I will check this patch!
>>>> - Gerhard
>>>>
>>>>
>>>> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>>>>>
>>>>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>>>>> instead of operating on c_ispeed and c_ospeed termios structure
>>>>> members directly because they are not guaranteed to exist on all
>>>>> libc implementations
>>>>>
>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>> ---
>>>>> xioinitialize.c | 8 ++++----
>>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/xioinitialize.c b/xioinitialize.c
>>>>> index 9f50155..632ca4c 100644
>>>>> --- a/xioinitialize.c
>>>>> +++ b/xioinitialize.c
>>>>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>>>> #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET !=
>>>>> -1)
>>>>> #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>>>> #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>>>>> - tdata.termarg.c_ispeed = 0x56789abc;
>>>>> - tdata.termarg.c_ospeed = 0x6789abcd;
>>>>> - assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>>>>> - assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>>>>> + cfsetispeed(&tdata.termarg, 0x56789abc);
>>>>> + cfsetospeed(&tdata.termarg, 0x6789abcd);
>>>>> + assert(cfgetispeed(&tdata.termarg) ==
>>>>> tdata.speeds[ISPEED_OFFSET]);
>>>>> + assert(cfgetospeed(&tdata.termarg) ==
>>>>> tdata.speeds[OSPEED_OFFSET]);
>>>>> #endif
>>>>> #endif
>>>>> #endif
>>>>>
>>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Access c_ispeed and c_ospeed via APIs
2016-04-13 17:15 ` Bruce Ashfield
@ 2016-04-13 17:17 ` Khem Raj
0 siblings, 0 replies; 8+ messages in thread
From: Khem Raj @ 2016-04-13 17:17 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On Wed, Apr 13, 2016 at 10:15 AM, Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
> On 2016-04-13 11:57 AM, Khem Raj wrote:
>>
>> On Tue, Apr 12, 2016 at 3:33 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> I think I see the problem now. The constant should be converted to use
>>> Bnn
>>> values. When calling the baudrate apis. I will send a patch for you to
>>> test
>>> once I am close to computer
>>
>>
>> I have sent a potential patch.
>>
>>
>> http://lists.openembedded.org/pipermail/openembedded-core/2016-April/120229.html
>>
>> It worked on musl env that I had ready here. Can you test it
>> with your env and make sure it works for you ?
>
>
> confirmed. I reverted my local change, applied this and socat is
> working without the assert.
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-13 17:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1458077979-23303-1-git-send-email-raj.khem@gmail.com>
[not found] ` <56E91CC8.9060907@dest-unreach.org>
2016-04-12 17:53 ` [PATCH] Access c_ispeed and c_ospeed via APIs Khem Raj
2016-04-12 21:05 ` Bruce Ashfield
2016-04-12 22:20 ` Khem Raj
[not found] ` <CAMKF1srQ5ayOr3ha=YTTGBS-ovX8Ht41ODoNaSEHBGW9EfjFGA@mail.gmail.com>
[not found] ` <CAMKF1sqBwbkHWQBBzX8jbK0SoZtcMr6MO2ZSZ9dcMJJns6x+eQ@mail.gmail.com>
2016-04-12 22:33 ` Khem Raj
2016-04-13 15:57 ` Khem Raj
2016-04-13 15:59 ` Bruce Ashfield
2016-04-13 17:15 ` Bruce Ashfield
2016-04-13 17:17 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.