All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
	swarren@wwwdotorg.org, thierry.reding@gmail.com,
	linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org,
	mark.rutland@arm.com
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 6/7] pinctrl: tegra: Add DT binding for io pads control
Date: Fri, 15 Apr 2016 22:11:42 +0530	[thread overview]
Message-ID: <571119C6.6000107@nvidia.com> (raw)
In-Reply-To: <57110CA4.6050903@nvidia.com>


On Friday 15 April 2016 09:15 PM, Jon Hunter wrote:
> On 15/04/16 16:14, Laxman Dewangan wrote:
>>
>> I used pins as this is the property from pincon generic so that I can
>> use the generic implementation.
>>
>> Here, I will not go to the pin level control as HW does not support pin
>> level control.
>>
>> I will say the unit should be interface level. Should we say
>> IO_GROUP_CSIA, IO_GROUP_CSIB etc?
> So we need to reflect the hardware in device-tree and although yes the
> power-down for the CSI_x_xxx pads are all controlled together as a
> single group, it does not feel right that we add a pseudo pin called
> csix to represent these.
>
> The CSI_x_xxx pads are already in device-tree and so why not add a
> property to each of these pads which has the IO rail information for
> power-down and voltage-select?

Which dt binding docs have these?
I looked for nvidia,tegra210-pinmux.txt and not able to find csi_xxx.

Here I dont want to refer the individual pins as control should be as group.


WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>, <swarren@wwwdotorg.org>,
	<thierry.reding@gmail.com>, <linus.walleij@linaro.org>,
	<gnurou@gmail.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>
Cc: <linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 6/7] pinctrl: tegra: Add DT binding for io pads control
Date: Fri, 15 Apr 2016 22:11:42 +0530	[thread overview]
Message-ID: <571119C6.6000107@nvidia.com> (raw)
In-Reply-To: <57110CA4.6050903@nvidia.com>


On Friday 15 April 2016 09:15 PM, Jon Hunter wrote:
> On 15/04/16 16:14, Laxman Dewangan wrote:
>>
>> I used pins as this is the property from pincon generic so that I can
>> use the generic implementation.
>>
>> Here, I will not go to the pin level control as HW does not support pin
>> level control.
>>
>> I will say the unit should be interface level. Should we say
>> IO_GROUP_CSIA, IO_GROUP_CSIB etc?
> So we need to reflect the hardware in device-tree and although yes the
> power-down for the CSI_x_xxx pads are all controlled together as a
> single group, it does not feel right that we add a pseudo pin called
> csix to represent these.
>
> The CSI_x_xxx pads are already in device-tree and so why not add a
> property to each of these pads which has the IO rail information for
> power-down and voltage-select?

Which dt binding docs have these?
I looked for nvidia,tegra210-pinmux.txt and not able to find csi_xxx.

Here I dont want to refer the individual pins as control should be as group.

  reply	other threads:[~2016-04-15 16:53 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 14:56 [PATCH 0/7] pinctrl: soc/tegra: Add support to configure IO rail voltage and pad power states Laxman Dewangan
2016-04-12 14:56 ` Laxman Dewangan
     [not found] ` <1460473007-11535-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12 14:56   ` [PATCH 1/7] soc/tegra: pmc: Use BIT macro for register field definition Laxman Dewangan
2016-04-12 14:56     ` Laxman Dewangan
     [not found]     ` <1460473007-11535-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12 15:26       ` Thierry Reding
2016-04-12 15:26         ` Thierry Reding
2016-04-12 16:58         ` Laxman Dewangan
2016-04-12 16:58           ` Laxman Dewangan
2016-04-15  7:44         ` Linus Walleij
2016-04-12 14:56 ` [PATCH 2/7] soc/tegra: pmc: Add new Tegra210 IO rails Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
     [not found]   ` <1460473007-11535-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12 15:28     ` Thierry Reding
2016-04-12 15:28       ` Thierry Reding
     [not found]       ` <20160412152830.GB30211-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-04-12 16:59         ` Laxman Dewangan
2016-04-12 16:59           ` Laxman Dewangan
2016-04-12 18:03           ` Jon Hunter
2016-04-12 18:03             ` Jon Hunter
2016-04-12 17:57             ` Laxman Dewangan
2016-04-12 17:57               ` Laxman Dewangan
2016-04-12 14:56 ` [PATCH 3/7] soc/tegra: pmc: Add interface to get IO rail power status Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
     [not found]   ` <1460473007-11535-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12 18:06     ` kbuild test robot
2016-04-12 18:06       ` kbuild test robot
2016-04-12 18:13     ` Jon Hunter
2016-04-12 18:13       ` Jon Hunter
2016-04-12 14:56 ` [PATCH 4/7] soc/tegra: pmc: Add interface to set voltage of IO rails Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
2016-04-13  8:47   ` Jon Hunter
2016-04-13  8:47     ` Jon Hunter
2016-04-13  9:00     ` Laxman Dewangan
2016-04-13  9:00       ` Laxman Dewangan
2016-04-13  9:25       ` Jon Hunter
2016-04-13  9:25         ` Jon Hunter
     [not found]         ` <570E109D.6070805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-13  9:20           ` Laxman Dewangan
2016-04-13  9:20             ` Laxman Dewangan
2016-04-13  9:56             ` Jon Hunter
2016-04-13  9:56               ` Jon Hunter
     [not found]   ` <1460473007-11535-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15  7:54     ` Linus Walleij
2016-04-15  7:54       ` Linus Walleij
     [not found]       ` <CACRpkdbueJ=0+WtNefQ7GHoqU5HY7WFYjL2geFq4vkpTbZesZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-15  8:00         ` Mark Brown
2016-04-15  8:00           ` Mark Brown
     [not found]           ` <20160415080027.GB3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-15  8:25             ` Laxman Dewangan
2016-04-15  8:25               ` Laxman Dewangan
     [not found]               ` <5710A583.2010102-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15  9:19                 ` Linus Walleij
2016-04-15  9:19                   ` Linus Walleij
2016-04-15 16:24   ` Stephen Warren
2016-04-15 16:21     ` Laxman Dewangan
2016-04-15 16:21       ` Laxman Dewangan
     [not found]       ` <57111524.60708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 16:41         ` Stephen Warren
2016-04-15 16:41           ` Stephen Warren
     [not found]           ` <571119D5.3040309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-15 16:33             ` Laxman Dewangan
2016-04-15 16:33               ` Laxman Dewangan
2016-04-15 16:59               ` Stephen Warren
2016-04-12 14:56 ` [PATCH 5/7] soc/tegra: pmc: Register sub-devices of PMC Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
     [not found]   ` <1460473007-11535-6-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 16:31     ` Stephen Warren
2016-04-15 16:31       ` Stephen Warren
2016-04-12 14:56 ` [PATCH 6/7] pinctrl: tegra: Add DT binding for io pads control Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
2016-04-13  9:04   ` Jon Hunter
2016-04-13  9:04     ` Jon Hunter
     [not found]     ` <570E0BAE.8090404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-13  9:08       ` Laxman Dewangan
2016-04-13  9:08         ` Laxman Dewangan
2016-04-13  9:31         ` Jon Hunter
2016-04-13  9:31           ` Jon Hunter
2016-04-15 14:16   ` Jon Hunter
2016-04-15 14:16     ` Jon Hunter
2016-04-15 14:12     ` Laxman Dewangan
2016-04-15 14:12       ` Laxman Dewangan
     [not found]       ` <5710F6CA.6060700-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 15:14         ` Jon Hunter
2016-04-15 15:14           ` Jon Hunter
     [not found]           ` <57110560.80004-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 15:14             ` Laxman Dewangan
2016-04-15 15:14               ` Laxman Dewangan
2016-04-15 15:45               ` Jon Hunter
2016-04-15 15:45                 ` Jon Hunter
2016-04-15 16:41                 ` Laxman Dewangan [this message]
2016-04-15 16:41                   ` Laxman Dewangan
2016-04-15 17:44                   ` Jon Hunter
2016-04-15 17:44                     ` Jon Hunter
     [not found]                     ` <5711288D.7060701-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 17:49                       ` Laxman Dewangan
2016-04-15 17:49                         ` Laxman Dewangan
2016-04-15 18:30                         ` Jon Hunter
2016-04-15 18:30                           ` Jon Hunter
     [not found]                           ` <57113340.6090701-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 18:43                             ` Laxman Dewangan
2016-04-15 18:43                               ` Laxman Dewangan
2016-04-15 16:35   ` Stephen Warren
2016-04-15 16:31     ` Laxman Dewangan
2016-04-15 16:31       ` Laxman Dewangan
2016-04-12 14:56 ` [PATCH 7/7] pinctrl: tegra: Add driver to configure voltage and power state of io pads Laxman Dewangan
2016-04-12 14:56   ` Laxman Dewangan
2016-04-15  8:08   ` Linus Walleij
2016-04-15  8:39     ` Laxman Dewangan
2016-04-15  9:25       ` Linus Walleij
2016-04-15  9:55         ` Laxman Dewangan
2016-04-15 11:15           ` Linus Walleij
     [not found]             ` <CACRpkdbr-9Z1JKMVmwNFyMq+Pg+3hT5c9rKZ1y4wZecnidW9Cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-15 11:47               ` Laxman Dewangan
2016-04-15 11:47                 ` Laxman Dewangan
2016-04-15 14:03                 ` Linus Walleij
2016-04-15 13:59                   ` Laxman Dewangan
     [not found]                     ` <5710F3DC.7090906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-19  9:49                       ` Laxman Dewangan
2016-04-19  9:49                         ` Laxman Dewangan
2016-04-26 13:32                 ` Laxman Dewangan
2016-04-26 15:31                   ` Stephen Warren
     [not found]       ` <5710A8A4.90309-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-15 16:38         ` Stephen Warren
2016-04-15 16:38           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571119C6.6000107@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.