Re: [PATCH v1 2/7] drm/rockchip: vop: add lut_size for RK3368 vop_data

From: Heiko Stuebner <heiko@sntech.de>
To: robh@kernel.org, WeiHao Li <cn.liweihao@gmail.com>,
	andy.yan@rock-chips.com
Cc: hjc@rock-chips.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
	WeiHao Li <cn.liweihao@gmail.com>
Subject: Re: [PATCH v1 2/7] drm/rockchip: vop: add lut_size for RK3368 vop_data
Date: Wed, 03 Sep 2025 14:16:04 +0200	[thread overview]
Message-ID: <5726817.Isy0gbHreE@phil> (raw)
In-Reply-To: <20250831104855.45883-3-cn.liweihao@gmail.com>

Hi,

Am Sonntag, 31. August 2025, 12:48:50 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> VOP driver need a correct lut_size to work normally.

please add a comment where that value is coming from.
Because the vop in the vendor kernel is so vastly different.

Thanks
Heiko

> 
> Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> ---
>  drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> index d1f788763..219f8c2fa 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> @@ -880,6 +880,7 @@ static const struct vop_data rk3368_vop = {
>  	.win = rk3368_vop_win_data,
>  	.win_size = ARRAY_SIZE(rk3368_vop_win_data),
>  	.max_output = { 4096, 2160 },
> +	.lut_size = 1024,
>  };
>  
>  static const struct vop_intr rk3366_vop_intr = {
> 