Re: [PATCH v1 6/7] ARM: dts: rockchip: Add D-PHY for RK3368

From: "Heiko Stübner" <heiko@sntech.de>
To: robh@kernel.org, WeiHao Li <cn.liweihao@gmail.com>
Cc: hjc@rock-chips.com, andy.yan@rock-chips.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
	WeiHao Li <cn.liweihao@gmail.com>
Subject: Re: [PATCH v1 6/7] ARM: dts: rockchip: Add D-PHY for RK3368
Date: Sun, 31 Aug 2025 17:06:24 +0200	[thread overview]
Message-ID: <8571992.T7Z3S40VBb@diego> (raw)
In-Reply-To: <20250831104855.45883-7-cn.liweihao@gmail.com>

Am Sonntag, 31. August 2025, 12:48:54 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> RK3368 has a InnoSilicon D-PHY which supports DSI/LVDS/TTL with maximum
> trasnfer rate of 1 Gbps per lane.
> 
> Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 0e47bf59a..674a3676d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -884,6 +884,20 @@ display_subsystem: display-subsystem {
>  		status = "disabled";
>  	};
>  
> +	video_phy: video-phy@ff968000 {

I think the node should be something like
dsi_dphy: phy@ff968000


> +		compatible = "rockchip,rk3368-dsi-dphy";
> +		reg = <0x0 0xff968000 0x0 0x4000>,
> +		      <0x0 0xff960000 0x0 0x4000>;
> +		clocks = <&cru SCLK_MIPIDSI_24M>, <&cru PCLK_DPHYTX0>,
> +			 <&cru PCLK_MIPI_DSI0>;
> +		clock-names = "ref", "pclk", "pclk_host";
> +		#clock-cells = <0>;
> +		resets = <&cru SRST_MIPIDPHYTX>;
> +		reset-names = "apb";
> +		#phy-cells = <0>;
> +		status = "disabled";
> +	};
> +
>  	hevc_mmu: iommu@ff9a0440 {
>  		compatible = "rockchip,iommu";
>  		reg = <0x0 0xff9a0440 0x0 0x40>,
>