* [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan
@ 2016-07-07 0:58 Joseph Salisbury
2016-07-07 1:02 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Salisbury @ 2016-07-07 0:58 UTC (permalink / raw)
To: gregkh, hdegoede, adrienverge, yaowen, vpalatin, stern
Cc: linux-kernel, linux-usb, stable
BugLink: http://bugs.launchpad.net/bugs/1498667
As reported in BugLink, this device has an issue with Linux Power
Management so adding a quirk. This quirk was reccomended by Alan Stern:
http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: stable <stable@vger.kernel.org>
---
drivers/usb/core/quirks.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 944a6dc..f028cc5 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x04f3, 0x016f), .driver_info =
USB_QUIRK_DEVICE_QUALIFIER },
+
+ { USB_DEVICE(0x04f3, 0x0381), .driver_info =
+ USB_QUIRK_NO_LPM },
{ USB_DEVICE(0x04f3, 0x21b8), .driver_info =
USB_QUIRK_DEVICE_QUALIFIER },
-
+
/* Roland SC-8820 */
{ USB_DEVICE(0x0582, 0x0007), .driver_info = USB_QUIRK_RESET_RESUME },
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan
2016-07-07 0:58 [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Joseph Salisbury
@ 2016-07-07 1:02 ` Greg KH
2016-07-07 1:05 ` Joseph Salisbury
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-07-07 1:02 UTC (permalink / raw)
To: Joseph Salisbury
Cc: hdegoede, adrienverge, yaowen, vpalatin, stern, linux-kernel,
linux-usb, stable
On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1498667
>
> As reported in BugLink, this device has an issue with Linux Power
> Management so adding a quirk. This quirk was reccomended by Alan Stern:
>
> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable <stable@vger.kernel.org>
> ---
> drivers/usb/core/quirks.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 944a6dc..f028cc5 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> { USB_DEVICE(0x04f3, 0x016f), .driver_info =
> USB_QUIRK_DEVICE_QUALIFIER },
> +
> + { USB_DEVICE(0x04f3, 0x0381), .driver_info =
> + USB_QUIRK_NO_LPM },
>
> { USB_DEVICE(0x04f3, 0x21b8), .driver_info =
> USB_QUIRK_DEVICE_QUALIFIER },
> -
> +
This is odd, why remove and add a blank line for no reason?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan
2016-07-07 1:02 ` Greg KH
@ 2016-07-07 1:05 ` Joseph Salisbury
0 siblings, 0 replies; 3+ messages in thread
From: Joseph Salisbury @ 2016-07-07 1:05 UTC (permalink / raw)
To: Greg KH
Cc: hdegoede, adrienverge, yaowen, vpalatin, stern, linux-kernel,
linux-usb, stable
On 07/06/2016 09:02 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power
>> Management so adding a quirk. This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>> ---
>> drivers/usb/core/quirks.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..f028cc5 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = {
>>
>> { USB_DEVICE(0x04f3, 0x016f), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> +
>> + { USB_DEVICE(0x04f3, 0x0381), .driver_info =
>> + USB_QUIRK_NO_LPM },
>>
>> { USB_DEVICE(0x04f3, 0x21b8), .driver_info =
>> USB_QUIRK_DEVICE_QUALIFIER },
>> -
>> +
> This is odd, why remove and add a blank line for no reason?
>
That is odd and wasn't intentional, I'll send a V3.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-07 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-07 0:58 [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Joseph Salisbury
2016-07-07 1:02 ` Greg KH
2016-07-07 1:05 ` Joseph Salisbury
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.