From: jeffy <jeffy.chen@rock-chips.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, briannorris@chromium.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org, bhelgaas@google.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq
Date: Fri, 18 Aug 2017 16:32:38 +0800 [thread overview]
Message-ID: <5996A626.5040303@rock-chips.com> (raw)
In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com>
Hi Shawn,
On 08/18/2017 03:23 PM, Shawn Lin wrote:
>>
>> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct
>> platform_device *pdev)
>> struct device *dev = &pdev->dev;
>> struct rockchip_pcie *rockchip = dev_get_drvdata(dev);
>> + dev_pm_clear_wake_irq(dev);
>> + device_init_wakeup(dev, false);
>> +
>
> Looks good overall but I think we need this on the
> error handling path of rockchip_pcie_probe as well?
hmm, right, will fix it, thanks.
and i also notice some other missing error handling, will fix them too:)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com,
briannorris@chromium.org, dianders@chromium.org,
Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq
Date: Fri, 18 Aug 2017 16:32:38 +0800 [thread overview]
Message-ID: <5996A626.5040303@rock-chips.com> (raw)
In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com>
Hi Shawn,
On 08/18/2017 03:23 PM, Shawn Lin wrote:
>>
>> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct
>> platform_device *pdev)
>> struct device *dev = &pdev->dev;
>> struct rockchip_pcie *rockchip = dev_get_drvdata(dev);
>> + dev_pm_clear_wake_irq(dev);
>> + device_init_wakeup(dev, false);
>> +
>
> Looks good overall but I think we need this on the
> error handling path of rockchip_pcie_probe as well?
hmm, right, will fix it, thanks.
and i also notice some other missing error handling, will fix them too:)
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq
Date: Fri, 18 Aug 2017 16:32:38 +0800 [thread overview]
Message-ID: <5996A626.5040303@rock-chips.com> (raw)
In-Reply-To: <5e3accf1-6f84-861f-f647-628322bb7841@rock-chips.com>
Hi Shawn,
On 08/18/2017 03:23 PM, Shawn Lin wrote:
>>
>> @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct
>> platform_device *pdev)
>> struct device *dev = &pdev->dev;
>> struct rockchip_pcie *rockchip = dev_get_drvdata(dev);
>> + dev_pm_clear_wake_irq(dev);
>> + device_init_wakeup(dev, false);
>> +
>
> Looks good overall but I think we need this on the
> error handling path of rockchip_pcie_probe as well?
hmm, right, will fix it, thanks.
and i also notice some other missing error handling, will fix them too:)
next prev parent reply other threads:[~2017-08-18 8:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 12:04 [RFC PATCH v2 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Jeffy Chen
2017-08-17 12:04 ` Jeffy Chen
2017-08-17 12:04 ` Jeffy Chen
2017-08-17 12:04 ` [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Jeffy Chen
2017-08-17 12:04 ` Jeffy Chen
2017-08-18 7:23 ` Shawn Lin
2017-08-18 7:23 ` Shawn Lin
2017-08-18 7:23 ` Shawn Lin
2017-08-18 8:32 ` jeffy [this message]
2017-08-18 8:32 ` jeffy
2017-08-18 8:32 ` jeffy
2017-08-18 17:01 ` Brian Norris
2017-08-18 17:01 ` Brian Norris
2017-08-18 17:01 ` Brian Norris
2017-08-18 17:07 ` Brian Norris
2017-08-18 17:07 ` Brian Norris
2017-08-18 17:07 ` Brian Norris
2017-08-18 17:47 ` jeffy
2017-08-18 17:47 ` jeffy
2017-08-18 17:47 ` jeffy
2017-08-18 18:28 ` Tony Lindgren
2017-08-18 18:28 ` Tony Lindgren
2017-08-18 18:28 ` Tony Lindgren
2017-08-18 18:14 ` Tony Lindgren
2017-08-18 18:14 ` Tony Lindgren
2017-08-18 18:14 ` Tony Lindgren
2017-08-18 20:05 ` jeffy
2017-08-18 20:05 ` jeffy
2017-08-18 20:05 ` jeffy
2017-08-22 17:26 ` Tony Lindgren
2017-08-22 17:26 ` Tony Lindgren
2017-08-22 17:26 ` Tony Lindgren
2017-08-23 1:32 ` jeffy
2017-08-23 1:32 ` jeffy
2017-08-23 1:57 ` Brian Norris
2017-08-23 1:57 ` Brian Norris
2017-08-23 1:57 ` Brian Norris
2017-08-23 2:16 ` jeffy
2017-08-23 2:16 ` jeffy
2017-08-23 2:16 ` jeffy
2017-12-19 0:48 ` Brian Norris
2017-12-19 0:48 ` Brian Norris
2017-12-19 0:48 ` Brian Norris
2017-12-20 19:19 ` Tony Lindgren
2017-12-20 19:19 ` Tony Lindgren
2017-12-22 23:20 ` Brian Norris
2017-12-22 23:20 ` Brian Norris
2017-12-22 23:20 ` Brian Norris
2017-12-23 16:36 ` Tony Lindgren
2017-12-23 16:36 ` Tony Lindgren
2017-12-23 16:36 ` Tony Lindgren
2017-08-17 12:04 ` [RFC PATCH v2 2/3] dt-bindings: " Jeffy Chen
2017-08-17 12:04 ` Jeffy Chen
2017-08-17 12:04 ` [RFC PATCH v2 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Jeffy Chen
2017-08-17 12:04 ` Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5996A626.5040303@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.