Re: [PATCH 1/3] arm64: dts: imx8mm: Deduplicate PCIe clock-names property

From: Marek Vasut <marex@denx.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@denx.de>, Peng Fan <peng.fan@nxp.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 1/3] arm64: dts: imx8mm: Deduplicate PCIe clock-names property
Date: Fri, 11 Nov 2022 15:03:44 +0100	[thread overview]
Message-ID: <59e12bc4-cf0e-2e52-0462-ebad15f83fc4@denx.de> (raw)
In-Reply-To: <20221111063323.GK2649582@dragon>

On 11/11/22 07:33, Shawn Guo wrote:
> On Wed, Nov 02, 2022 at 10:22:46PM +0100, Marek Vasut wrote:
>> Move the PCIe clock-names property from various DTs into SoC dtsi to
>> reduce duplication. In case of a couple of boards, reorder the clock
>> so they match the order in yaml DT bindings.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@denx.de>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Richard Zhu <hongxing.zhu@nxp.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> To: linux-arm-kernel@lists.infradead.org
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi  | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi               | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15.dtsi     | 1 -
>>   arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 6 +++---
>>   arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts   | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi     | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi     | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi     | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts      | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts      | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts      | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts      | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi            | 5 ++---
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi                   | 1 +
>>   15 files changed, 28 insertions(+), 40 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
>> index 03266bd90a06b..f3cb7e27799e7 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
>> @@ -241,9 +241,8 @@ &pcie0 {
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&pinctrl_pcie0>;
>>   	reset-gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
>> -	clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>,
>> -		 <&pcie0_refclk_gated>;
>> -	clock-names = "pcie", "pcie_aux", "pcie_bus";
>> +	clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk_gated>,
>> +		 <&clk IMX8MM_CLK_PCIE1_AUX>;
> 
> I'm not fond of it.  I would rather keep `clocks` and `clock-names`
> appear as couple to ease the cross-checking.

The downside of such mass duplication is the arbitrarily different 
ordering of clock/clock-names in some of those DTs, which needs to be 
corrected for dtbs_check validation to pass anyway. Since the 
clock-names are then identical across the SoC DTs, no need to duplicate 
that property anymore, one can simply open imx8m*.dtsi .

Note that there is a V2 of this series.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel