Re: [PATCH] powerpc: Create "rom" (MTD) device prpmc2800

[Segher Boessenkool <segher@kernel.crashing.org>]

>>> So, what you're suggesting is a subnode for each described partition?
>
>> I'm saying this is a reasonable way to describe the regions
>> of flash the firmware itself cares about.
>
>> This isn't anything new; it is done like this on some
>> Apple systems, for example.
>
>    First you're saying that nodes should correspont to *real* devices, 
> then it turns out that there have been precedents for the nodes 
> corresponding to completely virtual entities? ;-)

Every physical device should have its own node (there
_can_ be exceptions, but if you can help it at all...)

There can be virtual devices as well, although you don't
often need or want them.  There are a few pseudo-nodes
too, not representing _any_ device, physical or virtual.

>>> Seems an awfully verbose way of going about it,
>
>> Not verbose, but flexible, and in line with everything
>
>    Yes, I'd agree about more flexibility...

Good to hear :-)

>> else about the device tree.
>
>    How about your earlier arguments against the representation of 
> flashes?

What arguments, exactly?  Perhaps you're not understanding
exactly what I meant, or perhaps I changed my mind -- that
happens sometimes, after long discussions.  That is what
those discussions are for, even -- only after looking at
every detail, and discussing all those details with other
people, including non-experts on OF who can bring in valuable
concerns about use cases etc.; only then can a good device
binding be defined.  Sometimes also it should be concluded
there is not enough experience yet on how to do a certain
device binding; in such a case, the best course of action is
usually to _not_ define such a binding yet.

>>> and I don't see what
>>> it buys us over the partitions/partition-names pair of properties.
>
>> It is extensible.  It makes parsing trivial.  It
>
>    Excellent -- previously my arguments about more simplicity for 
> representing  flash itself were sent to /dev/null.

Do you like my proposed CFI binding?  I need a bit more
input on how to do a JEDEC flash binding still.  After
I've written it all up properly, I plan to send this to
the OF working group to turn it into a standard binding.

>> represents a flash partition in a way similar to how
>> a "whole" flash device is represented.
>
>    Except it's not a device. :-)

Yes, but in many aspects it can be treated as one.  And
it cannot be mistaken for one, either.


Segher