From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-integrity@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 1/6] tpm-buf: create new functions for handling TPM buffers
Date: Fri, 16 Mar 2018 13:58:08 +0200 [thread overview]
Message-ID: <6da309e727bec176fed7253ba5276f47f784d759.camel@linux.intel.com> (raw)
In-Reply-To: <1520720090.4495.12.camel@HansenPartnership.com>
On Sat, 2018-03-10 at 14:14 -0800, James Bottomley wrote:
> TPM_BUF_OVERFLOW = BIT(0),
> + TPM_BUF_2B = BIT(1),
Instead of re-using this I would prefer to have another enum for
buffer type. tpm_buf_init() could have the signature:
int tpm_buf_init(unsigned int type);
For commands there should be a function:
void tpm_buf_set_command_header(struct tpm_buf *buf, u16 tag, u32 ordinal);
And tpm_buf_append_2b() should not exist at all. It should be
maintained automatically by other append commands.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3 1/6] tpm-buf: create new functions for handling TPM buffers
Date: Fri, 16 Mar 2018 13:58:08 +0200 [thread overview]
Message-ID: <6da309e727bec176fed7253ba5276f47f784d759.camel@linux.intel.com> (raw)
In-Reply-To: <1520720090.4495.12.camel@HansenPartnership.com>
On Sat, 2018-03-10 at 14:14 -0800, James Bottomley wrote:
> TPM_BUF_OVERFLOW = BIT(0),
> + TPM_BUF_2B = BIT(1),
Instead of re-using this I would prefer to have another enum for
buffer type. tpm_buf_init() could have the signature:
int tpm_buf_init(unsigned int type);
For commands there should be a function:
void tpm_buf_set_command_header(struct tpm_buf *buf, u16 tag, u32 ordinal);
And tpm_buf_append_2b() should not exist at all. It should be
maintained automatically by other append commands.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-16 11:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 22:13 [PATCH v3 0/6] add integrity and security to TPM2 transactions James Bottomley
2018-03-10 22:13 ` James Bottomley
2018-03-10 22:14 ` [PATCH v3 1/6] tpm-buf: create new functions for handling TPM buffers James Bottomley
2018-03-10 22:14 ` James Bottomley
2018-03-12 16:00 ` J Freyensee
2018-03-12 16:00 ` J Freyensee
2018-03-12 17:59 ` James Bottomley
2018-03-12 17:59 ` James Bottomley
2018-03-13 16:00 ` J Freyensee
2018-03-13 16:00 ` J Freyensee
2018-03-16 11:58 ` Jarkko Sakkinen [this message]
2018-03-16 11:58 ` Jarkko Sakkinen
2018-03-16 12:02 ` Jarkko Sakkinen
2018-03-16 12:02 ` Jarkko Sakkinen
2018-03-10 22:16 ` [PATCH v3 2/6] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling James Bottomley
2018-03-10 22:16 ` James Bottomley
2018-03-10 22:16 ` [PATCH v3 3/6] tpm2: add hmac checks to tpm2_pcr_extend() James Bottomley
2018-03-10 22:16 ` James Bottomley
2018-03-10 22:17 ` [PATCH v3 4/6] tpm2: add session encryption protection to tpm2_get_random() James Bottomley
2018-03-10 22:17 ` James Bottomley
2018-03-10 22:19 ` [PATCH v3 5/6] trusted keys: Add session encryption protection to the seal/unseal path James Bottomley
2018-03-10 22:19 ` James Bottomley
2018-03-10 22:20 ` [PATCH v3 6/6] tpm2-sessions: NOT FOR COMMITTING add sessions testing James Bottomley
2018-03-10 22:20 ` James Bottomley
2018-03-12 10:58 ` [PATCH v3 0/6] add integrity and security to TPM2 transactions Jarkko Sakkinen
2018-03-12 10:58 ` Jarkko Sakkinen
2018-03-12 15:57 ` James Bottomley
2018-03-12 15:57 ` James Bottomley
2018-03-16 13:34 ` Jarkko Sakkinen
2018-03-16 13:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da309e727bec176fed7253ba5276f47f784d759.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.