Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema

From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Baruch Siach <baruch@tkos.co.il>,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: rtc: armada-380-rtc: convert to dtschema
Date: Sun, 24 Mar 2024 01:02:31 +0100	[thread overview]
Message-ID: <6e68e0ca-2f3e-41a7-bb96-00fbdadc4436@gmail.com> (raw)
In-Reply-To: <20240323233742bfb9ba4a@mail.local>

On 3/24/24 00:37, Alexandre Belloni wrote:
> On 23/03/2024 23:46:13+0100, Javier Carrasco wrote:
>> Convert existing binding to dtschema to support validation.
>>
>> +required:
>> +  - compatible
>> +  - reg
>> +  - reg-names
>> +  - interrupts
>> +
>> +additionalProperties: false
> 
> This is not correct because at least start-year is supported. Please
> check for all your other submissions too.
> 

allOf:
  - $ref: rtc.yaml#

is missing, and then

unvealuatedProperties: false

to account for that.

"start-year" is read in the RTC base class, so I wonder why so many RTC
bindings add a reference to rtc.yaml, but then use

additionalProperties: false

>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +    rtc@a3800 {
>> +        compatible = "marvell,armada-380-rtc";
>> +        reg = <0xa3800 0x20>, <0x184a0 0x0c>;
>> +        reg-names = "rtc", "rtc-soc";
>> +        interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> +    };
>>
>> -- 
>> 2.40.1
>>
> 

Thanks and best regards,
Javier Carrasco