From: Jan Beulich <jbeulich@suse.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y
Date: Mon, 3 Aug 2026 11:55:47 +0200 [thread overview]
Message-ID: <7e9c755a-0cbd-45f3-9683-069627e540eb@suse.com> (raw)
In-Reply-To: <1b4d5a82-bdc4-460d-a5a4-59e788fe1c3f@apertussolutions.com>
On 02.08.2026 17:05, Daniel P. Smith wrote:
> On 7/28/26 9:17 AM, Jan Beulich wrote:
>> They're unreachable / dead otherwise.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Strictly speaking .hvm_param_altp2mhvm() is dependent upon X86=y as well
>> (but oddly not dependent upon ALTP2M=y).
>
> At a minimum, would it be worth at least adding a comment about the
> dependency? Note, this is just a question/suggestion.
Just a comment would be too little imo. One way or another we want to sort
this properly. With the first question being - why a separate hook, and
hence why the double checking for HVM_PARAM_ALTP2M? With further data
passed into the hook, the Flask case can easily be dealt with using just a
single hook. The XSM_TARGET vs XSM_PRIV makes this a little less nice for
dummy.
Jan
next prev parent reply other threads:[~2026-08-03 9:56 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 13:10 [PATCH 00/24] XSM: follow-on to XSAs 492 and 499 Jan Beulich
2026-07-28 13:13 ` [PATCH 01/24] XSM: reduce redundancy in hook machinery Jan Beulich
2026-07-30 15:05 ` Daniel P. Smith
2026-07-30 15:18 ` Jan Beulich
2026-07-30 18:21 ` Daniel P. Smith
2026-07-31 8:03 ` Jan Beulich
2026-08-02 14:46 ` Daniel P. Smith
2026-07-28 13:14 ` [PATCH 02/24] XSM: make .grant_*() hooks dependent upon GRANT_TABLE=y Jan Beulich
2026-07-30 18:23 ` Daniel P. Smith
2026-07-28 13:14 ` [PATCH 03/24] XSM: make .{,un}map_domain_pirq() hooks dependent upon HAS_PIRQ=y Jan Beulich
2026-08-02 14:50 ` Daniel P. Smith
2026-07-28 13:14 ` [PATCH 04/24] XSM: make PCI hooks dependent upon HAS_PCI=y Jan Beulich
2026-08-02 14:53 ` Daniel P. Smith
2026-07-28 13:15 ` [PATCH 05/24] XSM: make .iomem_mapping_vcpi() hook dependent upon HAS_VPCI=y Jan Beulich
2026-08-02 14:56 ` Daniel P. Smith
2026-07-28 13:15 ` [PATCH 06/24] XSM: make .kexec() hook dependent upon KEXEC=y Jan Beulich
2026-08-02 14:57 ` Daniel P. Smith
2026-07-28 13:15 ` [PATCH 07/24] XSM: make .hypfs() hook dependent upon HYPFS=y Jan Beulich
2026-08-02 14:58 ` Daniel P. Smith
2026-07-28 13:16 ` [PATCH 08/24] XSM: make .hvm_altp2mhvm_op() hook dependent upon ALTP2M=y Jan Beulich
2026-08-02 14:58 ` Daniel P. Smith
2026-07-28 13:17 ` [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y Jan Beulich
2026-08-02 15:05 ` Daniel P. Smith
2026-08-03 9:55 ` Jan Beulich [this message]
2026-08-02 15:05 ` Daniel P. Smith
2026-07-28 13:17 ` [PATCH 10/24] XSM: make .dm_op() hook dependent upon IOREQ_SERVER=y Jan Beulich
2026-08-02 15:07 ` Daniel P. Smith
2026-07-28 13:18 ` [PATCH 11/24] XSM: make certain x86-specific hooks dependent upon PV=y Jan Beulich
2026-08-02 15:08 ` Daniel P. Smith
2026-07-28 13:18 ` [PATCH 12/24] x86/mm: get_page_from_l1e() is PV-or-shadow-only Jan Beulich
2026-08-02 15:55 ` Daniel P. Smith
2026-08-03 10:11 ` Jan Beulich
2026-08-13 11:51 ` Daniel P. Smith
2026-08-13 12:14 ` Jan Beulich
2026-08-13 13:02 ` Daniel P. Smith
2026-07-28 13:19 ` [PATCH 13/24] x86: restrict PHYSDEVOP_* when PV=n Jan Beulich
2026-08-05 22:38 ` Daniel P. Smith
2026-07-28 13:19 ` [PATCH 14/24] XSM/dummy: fold cf_check into XSM_INLINE Jan Beulich
2026-08-05 22:39 ` Daniel P. Smith
2026-07-28 13:20 ` [PATCH 15/24] XSM/dummy: drop redundant return statements Jan Beulich
2026-08-05 22:40 ` Daniel P. Smith
2026-07-28 13:20 ` [PATCH 16/24] XSM: suppress hypercall when XSM=n Jan Beulich
2026-08-05 22:42 ` Daniel P. Smith
2026-07-28 13:22 ` [PATCH 17/24] XSM: make Argo hooks well-formed ones Jan Beulich
2026-08-03 21:01 ` Jason Andryuk
2026-08-04 7:53 ` Jan Beulich
2026-08-04 14:27 ` Jason Andryuk
2026-08-05 9:11 ` Jan Beulich
2026-08-06 0:37 ` Daniel P. Smith
2026-08-05 23:02 ` Daniel P. Smith
2026-08-06 7:16 ` Jan Beulich
2026-08-06 14:09 ` Jason Andryuk
2026-08-13 12:09 ` Daniel P. Smith
2026-08-15 1:12 ` Jason Andryuk
2026-07-28 13:22 ` [PATCH 18/24] XSM: make XSM " Jan Beulich
2026-08-06 0:53 ` Daniel P. Smith
2026-08-06 7:22 ` Jan Beulich
2026-07-28 13:23 ` [PATCH 19/24] XSM: convert "allow" (Flask: "access") parameters to bool Jan Beulich
2026-08-06 0:56 ` Daniel P. Smith
2026-07-28 13:23 ` [PATCH 20/24] XSM: fold xsm_{,un}map_domain_pirq() hooks Jan Beulich
2026-08-06 1:10 ` Daniel P. Smith
2026-08-06 7:36 ` Jan Beulich
2026-08-06 8:02 ` Jan Beulich
2026-08-13 12:42 ` Daniel P. Smith
2026-08-13 13:02 ` Jan Beulich
2026-08-13 13:05 ` Daniel P. Smith
2026-07-28 13:24 ` [PATCH 21/24] x86: type-correct last parameter of map_domain_pirq() Jan Beulich
2026-07-28 13:25 ` [PATCH 22/24] XSM: pass just SBDF to xsm_{,un}map_domain_irq() Jan Beulich
2026-08-06 1:16 ` Daniel P. Smith
2026-07-28 13:26 ` [PATCH 23/24] XSM: fold xsm_{,un}map_domain_irq() hooks Jan Beulich
2026-08-13 11:27 ` Daniel P. Smith
2026-07-28 13:26 ` [PATCH 24/24] XSM: fold xsm_{,un}bind_pt_irq() hooks Jan Beulich
2026-08-13 11:32 ` Daniel P. Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9c755a-0cbd-45f3-9683-069627e540eb@suse.com \
--to=jbeulich@suse.com \
--cc=dpsmith@apertussolutions.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.