From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook
Date: Fri, 20 Sep 2019 13:24:09 +0530 [thread overview]
Message-ID: <8268c9b4002f6b9b1c87fcc16920f57f@codeaurora.org> (raw)
In-Reply-To: <5d83de74.1c69fb81.71c0f.f162@mx.google.com>
On 2019-09-20 01:30, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2019-09-19 11:54:27)
>> On 2019-09-19 08:48, Sai Prakash Ranjan wrote:
>> > On 2019-09-19 05:55, Bjorn Andersson wrote:
>> >> In the transition to this new design we lost the ability to
>> >> enable/disable the safe toggle per board, which according to Vivek
>> >> would result in some issue with Cheza.
>> >>
>> >> Can you confirm that this is okay? (Or introduce the DT property for
>> >> enabling the safe_toggle logic?)
>> >>
>> >
>> > Hmm, I don't remember Vivek telling about any issue on Cheza because
>> > of this logic.
>> > But I will test this on Cheza and let you know.
>> >
>>
>> I tested this on Cheza and no perf degradation nor any other issue is
>> seen
>> atleast openly, although I see this below stack dump always with
>> cant_sleep change added.
>
> The usage of cant_sleep() here is wrong then, and the comment should be
> removed from the scm API as well because it looks like it's perfectly
> OK
> to call the function from a context that can sleep.
>
Looking more into this downstream, it says this *can be called in atomic
context*
and not *should be called only in atomic context*. So will remove
cant_sleep and
modify the comment accordingly.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
iommu@lists.linux-foundation.org, Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, Will Deacon <will@kernel.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook
Date: Fri, 20 Sep 2019 13:24:09 +0530 [thread overview]
Message-ID: <8268c9b4002f6b9b1c87fcc16920f57f@codeaurora.org> (raw)
In-Reply-To: <5d83de74.1c69fb81.71c0f.f162@mx.google.com>
On 2019-09-20 01:30, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2019-09-19 11:54:27)
>> On 2019-09-19 08:48, Sai Prakash Ranjan wrote:
>> > On 2019-09-19 05:55, Bjorn Andersson wrote:
>> >> In the transition to this new design we lost the ability to
>> >> enable/disable the safe toggle per board, which according to Vivek
>> >> would result in some issue with Cheza.
>> >>
>> >> Can you confirm that this is okay? (Or introduce the DT property for
>> >> enabling the safe_toggle logic?)
>> >>
>> >
>> > Hmm, I don't remember Vivek telling about any issue on Cheza because
>> > of this logic.
>> > But I will test this on Cheza and let you know.
>> >
>>
>> I tested this on Cheza and no perf degradation nor any other issue is
>> seen
>> atleast openly, although I see this below stack dump always with
>> cant_sleep change added.
>
> The usage of cant_sleep() here is wrong then, and the comment should be
> removed from the scm API as well because it looks like it's perfectly
> OK
> to call the function from a context that can sleep.
>
Looking more into this downstream, it says this *can be called in atomic
context*
and not *should be called only in atomic context*. So will remove
cant_sleep and
modify the comment accordingly.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-20 7:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 9:45 [PATCHv6 0/3] QCOM smmu-500 wait-for-safe handling for sdm845 Sai Prakash Ranjan
2019-09-17 9:45 ` Sai Prakash Ranjan
2019-09-17 9:45 ` [PATCHv6 1/3] firmware: qcom_scm-64: Add atomic version of qcom_scm_call Sai Prakash Ranjan
2019-09-17 9:45 ` Sai Prakash Ranjan
2019-09-19 0:50 ` Stephen Boyd
2019-09-19 0:50 ` Stephen Boyd
2019-09-17 9:45 ` [PATCHv6 2/3] firmware/qcom_scm: Add scm call to handle smmu errata Sai Prakash Ranjan
2019-09-17 9:45 ` Sai Prakash Ranjan
2019-09-19 0:53 ` Stephen Boyd
2019-09-19 0:53 ` Stephen Boyd
2019-09-17 9:45 ` [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook Sai Prakash Ranjan
2019-09-17 9:45 ` Sai Prakash Ranjan
2019-09-19 0:25 ` Bjorn Andersson
2019-09-19 0:25 ` Bjorn Andersson
2019-09-19 0:52 ` Stephen Boyd
2019-09-19 0:52 ` Stephen Boyd
2019-09-19 3:18 ` Sai Prakash Ranjan
2019-09-19 3:18 ` Sai Prakash Ranjan
2019-09-19 18:54 ` Sai Prakash Ranjan
2019-09-19 18:54 ` Sai Prakash Ranjan
2019-09-19 20:00 ` Stephen Boyd
2019-09-19 20:00 ` Stephen Boyd
2019-09-20 7:54 ` Sai Prakash Ranjan [this message]
2019-09-20 7:54 ` Sai Prakash Ranjan
2019-09-19 0:57 ` Stephen Boyd
2019-09-19 0:57 ` Stephen Boyd
2019-09-19 3:13 ` Sai Prakash Ranjan
2019-09-19 3:13 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8268c9b4002f6b9b1c87fcc16920f57f@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=swboyd@chromium.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.