From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH 02/13] tests/intel/xe_oa: Drop unused macro
Date: Tue, 18 Feb 2025 09:32:43 -0800 [thread overview]
Message-ID: <85tt8r17lw.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250215010628.1639986-3-umesh.nerlige.ramappa@intel.com>
On Fri, 14 Feb 2025 17:06:17 -0800, Umesh Nerlige Ramappa wrote:
>
> Drop unused for helper
I don't remember why I left this in, probably wanted to save the way the
macro was written. Anyway, we can get it out of git if we need it:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> tests/intel/xe_oa.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 3274d472d..9c74315df 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4788,13 +4788,6 @@ static const char *xe_engine_class_name(uint32_t engine_class)
> igt_dynamic_f("%s-%d-%s", xe_engine_class_name(hwe->engine_class), \
> hwe->engine_instance, str)
>
> -#define __for_one_render_engine_0(hwe) \
> - xe_for_each_engine(drm_fd, hwe) \
> - if (hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER) \
> - break; \
> - for_each_if(hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER) \
> - igt_dynamic_f("rcs-%d", hwe->engine_instance)
> -
> #define __for_one_render_engine(hwe) \
> for (int m = 0, done = 0; !done; m++) \
> for_each_if(m < xe_number_engines(drm_fd) && \
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-02-18 17:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-15 1:06 [PATCH 00/13] Some refactor, rewrite and fixes for OA tests Umesh Nerlige Ramappa
2025-02-15 1:06 ` [PATCH 01/13] tests/intel/xe_oa: Use static for global variables Umesh Nerlige Ramappa
2025-02-18 17:28 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 02/13] tests/intel/xe_oa: Drop unused macro Umesh Nerlige Ramappa
2025-02-18 17:32 ` Dixit, Ashutosh [this message]
2025-02-15 1:06 ` [PATCH 03/13] tests/intel/xe_oa: Rename oa_exp_1_millisec to oa_exponent_default Umesh Nerlige Ramappa
2025-02-22 2:42 ` Dixit, Ashutosh
2025-02-22 3:35 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 04/13] tests/intel/xe_oa: Use default exponent for some tests Umesh Nerlige Ramappa
2025-02-22 2:43 ` Dixit, Ashutosh
2025-02-22 3:37 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 05/13] tests/intel/xe_oa: Use same render copy width and height across tests Umesh Nerlige Ramappa
2025-02-22 2:48 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 06/13] tests/intel/xe_oa: Rewrite the polling small buf test Umesh Nerlige Ramappa
2025-02-24 21:35 ` Dixit, Ashutosh
2025-02-25 4:26 ` Dixit, Ashutosh
2025-02-25 22:51 ` Umesh Nerlige Ramappa
2025-02-27 3:45 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 07/13] tests/intel/xe_oa: Simplify the buffer-fill test Umesh Nerlige Ramappa
2025-02-24 21:33 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 08/13] tests/intel/xe_oa: Use default buffer size for non-zero reason Umesh Nerlige Ramappa
2025-02-22 3:10 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 09/13] tests/intel/xe_oa: Test oa buffer sizes Umesh Nerlige Ramappa
2025-02-18 18:34 ` Dixit, Ashutosh
2025-02-18 18:38 ` Dixit, Ashutosh
2025-02-18 18:44 ` Umesh Nerlige Ramappa
2025-02-22 0:13 ` Dixit, Ashutosh
2025-02-22 1:12 ` Umesh Nerlige Ramappa
2025-02-22 3:14 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 10/13] tests/intel/xe_oa: Rewrite enable-disable test Umesh Nerlige Ramappa
2025-02-25 0:30 ` Dixit, Ashutosh
2025-02-25 2:54 ` Dixit, Ashutosh
2025-02-25 22:25 ` Umesh Nerlige Ramappa
2025-02-15 1:06 ` [PATCH 11/13] tests/intel/xe_oa: Enable unprivileged-single-ctx-counters and fix it Umesh Nerlige Ramappa
2025-02-25 3:53 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 12/13] tests/intel/xe_oa: Fix mmio_trigger_reports testing Umesh Nerlige Ramappa
2025-02-22 3:32 ` Dixit, Ashutosh
2025-02-15 1:06 ` [PATCH 13/13] tests/intel/xe_oa: Set boundaries for OA exponent test Umesh Nerlige Ramappa
2025-02-22 3:17 ` Dixit, Ashutosh
2025-02-15 2:09 ` ✓ Xe.CI.BAT: success for Some refactor, rewrite and fixes for OA tests Patchwork
2025-02-15 2:23 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-18 18:32 ` Umesh Nerlige Ramappa
2025-02-16 8:05 ` ✗ Xe.CI.Full: " Patchwork
2025-02-18 18:38 ` Umesh Nerlige Ramappa
2025-02-18 18:40 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85tt8r17lw.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.