Re: [PATCH 01/13] tests/intel/xe_oa: Use static for global variables

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 14 Feb 2025 17:06:16 -0800, Umesh Nerlige Ramappa wrote:
>
> Use static for mmio_data and hwe.
>

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>  tests/intel/xe_oa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 0242fd594..3274d472d 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -296,12 +296,12 @@ static int pm_fd = -1;
>  static int stream_fd = -1;
>  static uint32_t devid;
>
> -struct drm_xe_engine_class_instance default_hwe;
> +static struct drm_xe_engine_class_instance default_hwe;
>
>  static struct intel_xe_perf *intel_xe_perf;
>  static uint64_t oa_exp_1_millisec;
>  static size_t default_oa_buffer_size;
> -struct intel_mmio_data mmio_data;
> +static struct intel_mmio_data mmio_data;
>  static igt_render_copyfunc_t render_copy;
>
>  static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_class_instance *hwe)
> --
> 2.34.1
>