Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Laszlo Kertesz]

Hello,
i have an issue with Skype lately (i compile mesa, kernel, drm, xserver 
from git periodically and i use a A8-6500 with its IGP with r600g and 
glamor).
It crashes the x server if i use bi directional video call. It seems to 
work in one-way video.
The x server restarts, but skype  continues to work for about half a 
minute more, including sending video.
One problem is that i dont see any errors in any logs, not dmesg or xorg 
log so i cant say which component is the culprit.

Now it seems that a similar issue existed in the past and it was related 
to some drivers that couldnt handle multiple xv instances (one for the 
received video, the other for the local video thumbnail). And there was 
a workaround of disabling the local video thumbnail which cant be done 
on the current Skype (4.3). The glamor xv reports 16 available ports though.

Is there any other way of diagnosing this error? Maybe i have some issue 
with the 32 bit driver installation?
Although i had no problems whatsoever (gaming on Steam, vdpau etc works 
well for example) other than this.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Alex Deucher]

On Tue, Oct 28, 2014 at 8:13 AM, Laszlo Kertesz
<laszlo.kertesz@gmail.com> wrote:
> Hello,
> i have an issue with Skype lately (i compile mesa, kernel, drm, xserver from
> git periodically and i use a A8-6500 with its IGP with r600g and glamor).
> It crashes the x server if i use bi directional video call. It seems to work
> in one-way video.
> The x server restarts, but skype  continues to work for about half a minute
> more, including sending video.
> One problem is that i dont see any errors in any logs, not dmesg or xorg log
> so i cant say which component is the culprit.
>
> Now it seems that a similar issue existed in the past and it was related to
> some drivers that couldnt handle multiple xv instances (one for the received
> video, the other for the local video thumbnail). And there was a workaround
> of disabling the local video thumbnail which cant be done on the current
> Skype (4.3). The glamor xv reports 16 available ports though.
>
> Is there any other way of diagnosing this error? Maybe i have some issue
> with the 32 bit driver installation?
> Although i had no problems whatsoever (gaming on Steam, vdpau etc works well
> for example) other than this.
>

Attach gdb to the xserver and get a backtrace when it crashes.  Make
sure you install the debug symbols for the xserver, etc.
http://www.x.org/wiki/Development/Documentation/ServerDebugging/

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Kertesz Laszlo]

On Tue, 2014-10-28 at 09:41 -0400, Alex Deucher wrote: 
> On Tue, Oct 28, 2014 at 8:13 AM, Laszlo Kertesz
> <laszlo.kertesz@gmail.com> wrote:
> > Hello,
> > i have an issue with Skype lately (i compile mesa, kernel, drm, xserver from
> > git periodically and i use a A8-6500 with its IGP with r600g and glamor).
> > It crashes the x server if i use bi directional video call. It seems to work
> > in one-way video.
> > The x server restarts, but skype  continues to work for about half a minute
> > more, including sending video.
> > One problem is that i dont see any errors in any logs, not dmesg or xorg log
> > so i cant say which component is the culprit.
> >
> > Now it seems that a similar issue existed in the past and it was related to
> > some drivers that couldnt handle multiple xv instances (one for the received
> > video, the other for the local video thumbnail). And there was a workaround
> > of disabling the local video thumbnail which cant be done on the current
> > Skype (4.3). The glamor xv reports 16 available ports though.
> >
> > Is there any other way of diagnosing this error? Maybe i have some issue
> > with the 32 bit driver installation?
> > Although i had no problems whatsoever (gaming on Steam, vdpau etc works well
> > for example) other than this.
> >
> 
> Attach gdb to the xserver and get a backtrace when it crashes.  Make
> sure you install the debug symbols for the xserver, etc.
> http://www.x.org/wiki/Development/Documentation/ServerDebugging/
> 
> Alex

I idd a bdb trace a while back and it does seem incomplete probably
because something wasnt compiled with debug on.

Program received signal SIGABRT, Aborted.
0x00007f530e3d5077 in __GI_raise (sig=sig@entry=6)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
Continuing.
[Thread 0x7f53083d7700 (LWP 32676) exited]

Program terminated with signal SIGABRT, Aborted.
The program no longer exists.

Anyway, the cause is clearly glamor on r600g related as i have disabled
glamor and on exa i did not have any such issues.
Even with the newest xserver git build it does crash nonetheless.

last commit is 
glamor: Make sure glamor_egl_close_screen wraps glamor_close_screen



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Alex Deucher]

On Thu, Dec 18, 2014 at 5:03 PM, Kertesz Laszlo
<laszlo.kertesz@gmail.com> wrote:
> On Tue, 2014-10-28 at 09:41 -0400, Alex Deucher wrote:
>> On Tue, Oct 28, 2014 at 8:13 AM, Laszlo Kertesz
>> <laszlo.kertesz@gmail.com> wrote:
>> > Hello,
>> > i have an issue with Skype lately (i compile mesa, kernel, drm, xserver from
>> > git periodically and i use a A8-6500 with its IGP with r600g and glamor).
>> > It crashes the x server if i use bi directional video call. It seems to work
>> > in one-way video.
>> > The x server restarts, but skype  continues to work for about half a minute
>> > more, including sending video.
>> > One problem is that i dont see any errors in any logs, not dmesg or xorg log
>> > so i cant say which component is the culprit.
>> >
>> > Now it seems that a similar issue existed in the past and it was related to
>> > some drivers that couldnt handle multiple xv instances (one for the received
>> > video, the other for the local video thumbnail). And there was a workaround
>> > of disabling the local video thumbnail which cant be done on the current
>> > Skype (4.3). The glamor xv reports 16 available ports though.
>> >
>> > Is there any other way of diagnosing this error? Maybe i have some issue
>> > with the 32 bit driver installation?
>> > Although i had no problems whatsoever (gaming on Steam, vdpau etc works well
>> > for example) other than this.
>> >
>>
>> Attach gdb to the xserver and get a backtrace when it crashes.  Make
>> sure you install the debug symbols for the xserver, etc.
>> http://www.x.org/wiki/Development/Documentation/ServerDebugging/
>>
>> Alex
>
> I idd a bdb trace a while back and it does seem incomplete probably
> because something wasnt compiled with debug on.
>
> Program received signal SIGABRT, Aborted.
> 0x00007f530e3d5077 in __GI_raise (sig=sig@entry=6)
>     at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
> Continuing.
> [Thread 0x7f53083d7700 (LWP 32676) exited]
>
> Program terminated with signal SIGABRT, Aborted.
> The program no longer exists.
>
> Anyway, the cause is clearly glamor on r600g related as i have disabled
> glamor and on exa i did not have any such issues.
> Even with the newest xserver git build it does crash nonetheless.
>

The question is whether the issue is in glamor or r600g or mesa.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Michel Dänzer]

On 19.12.2014 07:03, Kertesz Laszlo wrote:
> On Tue, 2014-10-28 at 09:41 -0400, Alex Deucher wrote: 
>> On Tue, Oct 28, 2014 at 8:13 AM, Laszlo Kertesz
>> <laszlo.kertesz@gmail.com> wrote:
>>> Hello,
>>> i have an issue with Skype lately (i compile mesa, kernel, drm, xserver from
>>> git periodically and i use a A8-6500 with its IGP with r600g and glamor).
>>> It crashes the x server if i use bi directional video call. It seems to work
>>> in one-way video.
>>> The x server restarts, but skype  continues to work for about half a minute
>>> more, including sending video.
>>> One problem is that i dont see any errors in any logs, not dmesg or xorg log
>>> so i cant say which component is the culprit.
>>>
>>> Now it seems that a similar issue existed in the past and it was related to
>>> some drivers that couldnt handle multiple xv instances (one for the received
>>> video, the other for the local video thumbnail). And there was a workaround
>>> of disabling the local video thumbnail which cant be done on the current
>>> Skype (4.3). The glamor xv reports 16 available ports though.
>>>
>>> Is there any other way of diagnosing this error? Maybe i have some issue
>>> with the 32 bit driver installation?
>>> Although i had no problems whatsoever (gaming on Steam, vdpau etc works well
>>> for example) other than this.
>>>
>>
>> Attach gdb to the xserver and get a backtrace when it crashes.  Make
>> sure you install the debug symbols for the xserver, etc.
>> http://www.x.org/wiki/Development/Documentation/ServerDebugging/
>>
>> Alex
> 
> I idd a bdb trace a while back and it does seem incomplete probably
> because something wasnt compiled with debug on.
> 
> Program received signal SIGABRT, Aborted.
> 0x00007f530e3d5077 in __GI_raise (sig=sig@entry=6)
>     at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
> Continuing.

You need to run 'bt full' at this point instead of continuing execution.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Kertesz Laszlo]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Attached gdb trace (crashed on latest git x server).


-- 
O zi buna,
Kertesz Laszlo

[-- Attachment #2: gdb.txt --]
[-- Type: text/plain, Size: 2894 bytes --]

Continuing.

Program received signal SIGABRT, Aborted.
0x00007f95897a5107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
#0  0x00007f95897a5107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
        resultvar = 0
        pid = 1782
        selftid = 1782
#1  0x00007f95897a64e8 in __GI_abort () at abort.c:89
        save_stage = 2
        act = {__sigaction_handler = {sa_handler = 0x7fffb8735f97, sa_sigaction = 0x7fffb8735f97}, sa_mask = {__val = {140280234577441, 140280212795042, 806, 4, 140736287947904, 49479023872, 
              140280161238272, 4294967296, 0, 0, 0, 21474836480, 140280234576967, 140736287948056, 140280267075584, 140280234592616}}, sa_flags = -2009026648, sa_restorer = 0x7f958840b1c0}
        sigs = {__val = {32, 0 <repeats 15 times>}}
#2  0x00007f958979e226 in __assert_fail_base (fmt=0x7f95898d4968 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x7f958840afa8 "y + fbo_y_off + h <= pixmap_priv->base.fbo->height", file=file@entry=0x7f958840aea2 "glamor_pixmap.c", line=line@entry=806, 
    function=function@entry=0x7f958840b1c0 "_glamor_upload_bits_to_pixmap_texture") at assert.c:92
        str = 0x1b5f570 ""
        total = 4096
#3  0x00007f958979e2d2 in __GI___assert_fail (assertion=0x7f958840afa8 "y + fbo_y_off + h <= pixmap_priv->base.fbo->height", file=0x7f958840aea2 "glamor_pixmap.c", line=806, 
    function=0x7f958840b1c0 "_glamor_upload_bits_to_pixmap_texture") at assert.c:101
No locals.
#4  0x00007f95883fc1fe in ?? () from /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so
No symbol table info available.
#5  0x00007f95883fcaf8 in ?? () from /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so
No symbol table info available.
#6  0x00007f9588404ae3 in ?? () from /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so
No symbol table info available.
#7  0x000000000048d9ef in ?? ()
No symbol table info available.
#8  0x00000000004d5859 in ?? ()
No symbol table info available.
#9  0x0000000000437c87 in ?? ()
No symbol table info available.
#10 0x000000000043bd1b in ?? ()
No symbol table info available.
#11 0x00007f9589791b45 in __libc_start_main (main=0x427350, argc=12, argv=0x7fffb8734358, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffb8734348)
    at libc-start.c:287
        result = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, -517365550660209946, 4354901, 140736287949648, 0, 0, 517494095386489574, 575018433031549670}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 
              0x594380 <__libc_csu_init>, 0x7fffb8734358}, data = {prev = 0x0, cleanup = 0x0, canceltype = 5849984}}}
        not_first_call = <optimized out>
#12 0x000000000042737e in _start ()
No symbol table info available.

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Michel Dänzer]

On 26.12.2014 09:01, Kertesz Laszlo wrote:
> Attached gdb trace (crashed on latest git x server).

Did it include commit 70a6f65f9e2b26ef7539dcacfcfea927bc1f13fd ('glamor:
Make sure Xvideo source image data is properly aligned')? If not, does
that help by any chance?

If not, can you make sure debugging symbols are available for
/usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so, and get another
backtrace?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Kertesz Laszlo]

On Fri, 2014-12-26 at 10:26 +0900, Michel Dänzer wrote: 
> On 26.12.2014 09:01, Kertesz Laszlo wrote:
> > Attached gdb trace (crashed on latest git x server).
> 
> Did it include commit 70a6f65f9e2b26ef7539dcacfcfea927bc1f13fd ('glamor:
> Make sure Xvideo source image data is properly aligned')? If not, does
> that help by any chance?
> 
> If not, can you make sure debugging symbols are available for
> /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so, and get another
> backtrace?
> 
> 
Yes i do have that commit (last is  modesetting: Add vblank
synchronization support when using Present.).
And i enabled debug in the xserver with --enable-debug, is there
something else i need to add for libglamoregl?


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Michel Dänzer]

On 26.12.2014 12:10, Kertesz Laszlo wrote:
> On Fri, 2014-12-26 at 10:26 +0900, Michel Dänzer wrote: 
>> On 26.12.2014 09:01, Kertesz Laszlo wrote:
>>> Attached gdb trace (crashed on latest git x server).
>>
>> Did it include commit 70a6f65f9e2b26ef7539dcacfcfea927bc1f13fd ('glamor:
>> Make sure Xvideo source image data is properly aligned')? If not, does
>> that help by any chance?
>>
>> If not, can you make sure debugging symbols are available for
>> /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so, and get another
>> backtrace?
>>
>>
> Yes i do have that commit (last is  modesetting: Add vblank
> synchronization support when using Present.).
> And i enabled debug in the xserver with --enable-debug, is there
> something else i need to add for libglamoregl?

If you're building and installing packages from xserver Git, you may
need to install the corresponding debugging package. Otherwise, make
sure /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so is actually
the one you built from Git, and that it doesn't get stripped.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Kertesz Laszlo]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

On Fri, 2014-12-26 at 12:17 +0900, Michel Dänzer wrote: 
> On 26.12.2014 12:10, Kertesz Laszlo wrote:
> > On Fri, 2014-12-26 at 10:26 +0900, Michel Dänzer wrote: 
> >> On 26.12.2014 09:01, Kertesz Laszlo wrote:
> >>> Attached gdb trace (crashed on latest git x server).
> >>
> >> Did it include commit 70a6f65f9e2b26ef7539dcacfcfea927bc1f13fd ('glamor:
> >> Make sure Xvideo source image data is properly aligned')? If not, does
> >> that help by any chance?
> >>
> >> If not, can you make sure debugging symbols are available for
> >> /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so, and get another
> >> backtrace?
> >>
> >>
> > Yes i do have that commit (last is  modesetting: Add vblank
> > synchronization support when using Present.).
> > And i enabled debug in the xserver with --enable-debug, is there
> > something else i need to add for libglamoregl?
> 
> If you're building and installing packages from xserver Git, you may
> need to install the corresponding debugging package. Otherwise, make
> sure /usr/lib/x86_64-linux-gnu/xorg/modules/libglamoregl.so is actually
> the one you built from Git, and that it doesn't get stripped.
> 
> 

Ok, rebuilt the xserver package with debugging symbols (seems that
checkinstall strips stuff by default). I got a bigger gdb.txt. See if it
helps.


[-- Attachment #2: gdb.txt --]
[-- Type: text/plain, Size: 5949 bytes --]

Continuing.

Program received signal SIGABRT, Aborted.
0x00007f62dd2e5107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
#0  0x00007f62dd2e5107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
        resultvar = 0
        pid = 321
        selftid = 321
#1  0x00007f62dd2e64e8 in __GI_abort () at abort.c:89
        save_stage = 2
        act = {__sigaction_handler = {sa_handler = 0x7fff09a46f97, sa_sigaction = 0x7fff09a46f97}, sa_mask = {__val = {140062595550753, 140062573768354, 806, 4, 140733355154400, 50883329280, 
              140062522211584, 4294967296, 0, 0, 0, 21474836480, 140062595550279, 140733355154552, 140062627950592, 140062595565928}}, sa_flags = -604721240, 
          sa_restorer = 0x7f62dbf4b1c0 <__PRETTY_FUNCTION__.42275>}
        sigs = {__val = {32, 0 <repeats 15 times>}}
#2  0x00007f62dd2de226 in __assert_fail_base (fmt=0x7f62dd414968 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x7f62dbf4afa8 "y + fbo_y_off + h <= pixmap_priv->base.fbo->height", file=file@entry=0x7f62dbf4aea2 "glamor_pixmap.c", line=line@entry=806, 
    function=function@entry=0x7f62dbf4b1c0 <__PRETTY_FUNCTION__.42275> "_glamor_upload_bits_to_pixmap_texture") at assert.c:92
        str = 0x23eff80 "\220\351\065\002"
        total = 4096
#3  0x00007f62dd2de2d2 in __GI___assert_fail (assertion=assertion@entry=0x7f62dbf4afa8 "y + fbo_y_off + h <= pixmap_priv->base.fbo->height", file=file@entry=0x7f62dbf4aea2 "glamor_pixmap.c", 
    line=line@entry=806, function=function@entry=0x7f62dbf4b1c0 <__PRETTY_FUNCTION__.42275> "_glamor_upload_bits_to_pixmap_texture") at assert.c:101
No locals.
#4  0x00007f62dbf3c1fe in _glamor_upload_bits_to_pixmap_texture (pixmap=0x2342210, format=6406, type=5121, no_alpha=0, revert=0, swap_rb=3, x=0, y=0, w=320, h=241, stride=320, bits=0x2373178, pbo=0)
    at glamor_pixmap.c:806
        fbo_x_off = 0
        fbo_y_off = 0
        pixmap_priv = 0x23fe730
        vertices = {-1, -1, 1, -1, 1, 1, -1, 1}
        texcoords_inv = {0, 0, 1, 0, 1, 1, 0, 1}
        ptexcoords = <optimized out>
        dst_xscale = <optimized out>
        dst_yscale = <optimized out>
        tex = 0
        need_free_bits = 0
        __PRETTY_FUNCTION__ = "_glamor_upload_bits_to_pixmap_texture"
#5  0x00007f62dbf3caf8 in glamor_upload_sub_pixmap_to_texture (pixmap=0x141, x=321, x@entry=0, y=6, y@entry=0, w=320, h=241, stride=1667525480, stride@entry=320, bits=0x2373178, pbo=0)
    at glamor_pixmap.c:1031
        force_clip = -602555200
        __FUNCTION__ = "glamor_upload_sub_pixmap_to_texture"
        __PRETTY_FUNCTION__ = "glamor_upload_sub_pixmap_to_texture"
#6  0x00007f62dbf44ae3 in glamor_xv_put_image (port_priv=0x1a33a38, pDrawable=0x23e5d80, src_x=<optimized out>, src_y=<optimized out>, drw_x=<optimized out>, drw_y=<optimized out>, src_w=320, 
    src_h=239, drw_w=63, drw_h=47, id=842094169, 
    buf=0x2373178 '\374' <repeats 74 times>, '\373' <repeats 14 times>, "\372\373", '\372' <repeats 40 times>, "\371\372\372\372\372\372\372\372\372\371\371\371\372\371\372\372\372\371\372\372\372\372\372\372\372\372\372\371\371\371\372\371\371\372\372\371\372\371\371\371\371\370\361\336Ǹ\257\241\217\205sqnpqlgefghijhhmwuqo"..., width=320, height=240, sync=0, clipBoxes=0x7fff09a46000)
    at glamor_xv.c:454
        pScreen = 0x154c8f0
        srcPitch = 320
        srcPitch2 = 160
        top = 0
        nlines = 241
        s2offset = <optimized out>
        s3offset = <optimized out>
#7  0x000000000048d9ef in xf86XVPutImage (pDraw=0x23e5d80, pPort=0x1a34340, pGC=<optimized out>, src_x=<optimized out>, src_y=<optimized out>, src_w=<optimized out>, src_h=239, drw_x=0, drw_y=0, 
    drw_w=63, drw_h=47, format=0x19a9690, 
    data=0x2373178 '\374' <repeats 74 times>, '\373' <repeats 14 times>, "\372\373", '\372' <repeats 40 times>, "\371\372\372\372\372\372\372\372\372\371\371\371\372\371\372\372\372\371\372\372\372\372\372\372\372\372\372\371\371\371\372\371\371\372\372\371\372\371\371\371\371\370\361\336Ǹ\257\241\217\205sqnpqlgefghijhhmwuqo"..., sync=0, width=320, height=240) at xf86xv.c:1649
        portPriv = 0x198a990
        WinRegion = {extents = {x1 = 482, y1 = 509, x2 = 545, y2 = 556}, data = 0x0}
        ClipRegion = {extents = {x1 = 482, y1 = 509, x2 = 545, y2 = 556}, data = 0x23e6d60}
        WinBox = {x1 = 482, y1 = 509, x2 = 545, y2 = 556}
        ret = <optimized out>
        clippedAway = 0
#8  0x00000000004d5859 in ProcXvPutImage (client=0x20527d0) at xvdisp.c:865
        pDraw = 0x23e5d80
        pPort = 0x1a34340
        pImage = 0x19a9690
        pGC = 0x2372a00
        status = <optimized out>
        i = <optimized out>
        size = <optimized out>
        width = 320
        height = 240
        stuff = 0x2373150
#9  0x0000000000437c87 in Dispatch () at dispatch.c:432
        clientReady = 0x1d960e0
        result = <optimized out>
        client = 0x20527d0
        nready = 0
        icheck = 0x81d470 <checkForInput>
        start_tick = 475
#10 0x000000000043bd1b in dix_main (argc=12, argv=0x7fff09a462b8, envp=<optimized out>) at main.c:298
        i = <optimized out>
        alwaysCheckForInput = {0, 1}
#11 0x00007f62dd2d1b45 in __libc_start_main (main=0x427350 <main>, argc=12, argv=0x7fff09a462b8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff09a462a8)
    at libc-start.c:287
        result = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 2940555772799183881, 4354901, 140733355156144, 0, 0, -2940603520821531639, -3023241638247830519}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 
              0x594380 <__libc_csu_init>, 0x7fff09a462b8}, data = {prev = 0x0, cleanup = 0x0, canceltype = 5849984}}}
        not_first_call = <optimized out>
#12 0x000000000042737e in _start ()
No symbol table info available.

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Keith Packard]

[-- Attachment #1.1.1: Type: text/plain, Size: 501 bytes --]

Kertesz Laszlo <laszlo.kertesz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> Ok, rebuilt the xserver package with debugging symbols (seems that
> checkinstall strips stuff by default). I got a bigger gdb.txt. See if it
> helps.

I found a bug -- glamor_xv_put_image was mis-computing the number of
lines of changed video when the client drew only a subset of the
image. I think the client is drawing at src_y=1, src_h=239 for some
weird reason (I suspect a bug in the client).

Try this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-glamor-Fix-nlines-in-glamor_xv_put_image-when-src_y-.patch --]
[-- Type: text/x-diff, Size: 962 bytes --]

From eaa4225413b31314070f9a52d9290649e79a3b0f Mon Sep 17 00:00:00 2001
From: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
Date: Sat, 27 Dec 2014 09:11:33 -0800
Subject: [PATCH] glamor: Fix nlines in glamor_xv_put_image when src_y is odd

The number of lines of video to update in the texture needs to be
computed from the height of the updated source, not the full height of
the source.

Signed-off-by: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
---
 glamor/glamor_xv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c
index 1c877da..83e24ad 100644
--- a/glamor/glamor_xv.c
+++ b/glamor/glamor_xv.c
@@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
     }
 
     top = (src_y) & ~1;
-    nlines = (src_y + height) - top;
+    nlines = (src_y + src_h) - top;
 
     switch (id) {
     case FOURCC_YV12:
-- 
2.1.4


[-- Attachment #1.1.3: Type: text/plain, Size: 62 bytes --]


-- 
keith.packard-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 191 bytes --]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 1770 bytes --]

Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org> writes:

> Kertesz Laszlo <laszlo.kertesz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>
>> Ok, rebuilt the xserver package with debugging symbols (seems that
>> checkinstall strips stuff by default). I got a bigger gdb.txt. See if it
>> helps.
>
> I found a bug -- glamor_xv_put_image was mis-computing the number of
> lines of changed video when the client drew only a subset of the
> image. I think the client is drawing at src_y=1, src_h=239 for some
> weird reason (I suspect a bug in the client).
>
> Try this patch:
>
> From eaa4225413b31314070f9a52d9290649e79a3b0f Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
> Date: Sat, 27 Dec 2014 09:11:33 -0800
> Subject: [PATCH] glamor: Fix nlines in glamor_xv_put_image when src_y is odd
>
> The number of lines of video to update in the texture needs to be
> computed from the height of the updated source, not the full height of
> the source.
>
> Signed-off-by: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
> ---
>  glamor/glamor_xv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c
> index 1c877da..83e24ad 100644
> --- a/glamor/glamor_xv.c
> +++ b/glamor/glamor_xv.c
> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
>      }
>  
>      top = (src_y) & ~1;
> -    nlines = (src_y + height) - top;
> +    nlines = (src_y + src_h) - top;
>  
>      switch (id) {
>      case FOURCC_YV12:

If the point is to upload only from the src_[xywh] recctangle, shouldn't
the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead
of width, too?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 191 bytes --]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Kertesz Laszlo]

On Sat, 2014-12-27 at 09:18 -0800, Keith Packard wrote: 
> Kertesz Laszlo <laszlo.kertesz@gmail.com> writes:
> 
> > Ok, rebuilt the xserver package with debugging symbols (seems that
> > checkinstall strips stuff by default). I got a bigger gdb.txt. See if it
> > helps.
> 
> I found a bug -- glamor_xv_put_image was mis-computing the number of
> lines of changed video when the client drew only a subset of the
> image. I think the client is drawing at src_y=1, src_h=239 for some
> weird reason (I suspect a bug in the client).
> 
> Try this patch:
> 

Tried it and it works. I had a ~10 min Skype call and had no issues.



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 796 bytes --]

Eric Anholt <eric@anholt.net> writes:

>> --- a/glamor/glamor_xv.c
>> +++ b/glamor/glamor_xv.c
>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
>>      }
>>  
>>      top = (src_y) & ~1;
>> -    nlines = (src_y + height) - top;
>> +    nlines = (src_y + src_h) - top;
>>  
>>      switch (id) {
>>      case FOURCC_YV12:
>
> If the point is to upload only from the src_[xywh] recctangle, shouldn't
> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead
> of width, too?

It doesn't need to, but it could as an optimization. Skipping lines at
the top and bottom is also just an optimization as the source rectangle
defines a subset of the provided buffer, after all. I just fixed that
optimization.

-- 
keith.packard@intel.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 180 bytes --]

Kertesz Laszlo <laszlo.kertesz@gmail.com> writes:

> Tried it and it works. I had a ~10 min Skype call and had no issues.

Thanks for testing.

-- 
keith.packard@intel.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]

Keith Packard <keithp@keithp.com> writes:

> Eric Anholt <eric@anholt.net> writes:
>
>>> --- a/glamor/glamor_xv.c
>>> +++ b/glamor/glamor_xv.c
>>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
>>>      }
>>>  
>>>      top = (src_y) & ~1;
>>> -    nlines = (src_y + height) - top;
>>> +    nlines = (src_y + src_h) - top;
>>>  
>>>      switch (id) {
>>>      case FOURCC_YV12:
>>
>> If the point is to upload only from the src_[xywh] recctangle, shouldn't
>> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead
>> of width, too?
>
> It doesn't need to, but it could as an optimization. Skipping lines at
> the top and bottom is also just an optimization as the source rectangle
> defines a subset of the provided buffer, after all. I just fixed that
> optimization.

glamor_xv_render is trying to scale from dst coords to src coords using
multiplication by src_w / dst_w, though, so if the src pixmap was width
wide instead of src_w wide, I think you'd be rendering wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 990 bytes --]

Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org> writes:

> Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> writes:
>
>>> --- a/glamor/glamor_xv.c
>>> +++ b/glamor/glamor_xv.c
>>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
>>>      }
>>>  
>>>      top = (src_y) & ~1;
>>> -    nlines = (src_y + height) - top;
>>> +    nlines = (src_y + src_h) - top;
>>>  
>>>      switch (id) {
>>>      case FOURCC_YV12:
>>
>> If the point is to upload only from the src_[xywh] recctangle, shouldn't
>> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead
>> of width, too?
>
> It doesn't need to, but it could as an optimization. Skipping lines at
> the top and bottom is also just an optimization as the source rectangle
> defines a subset of the provided buffer, after all. I just fixed that
> optimization.

FWIW, even as is:

Reviewed-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 191 bytes --]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 257 bytes --]

Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> writes:

> Reviewed-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>

Merged.
   09230a2..d723928  master -> master

-- 
keith.packard-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 191 bytes --]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel