From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Wambui Karuga <wambui.karugax@gmail.com>,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org,
rodrigo.vivi@intel.com
Subject: Re: [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros
Date: Mon, 27 Jan 2020 11:17:37 +0200 [thread overview]
Message-ID: <871rrlcl72.fsf@intel.com> (raw)
In-Reply-To: <157996851987.2524.2577321446102599250@skylake-alporthouse-com>
On Sat, 25 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Wambui Karuga (2020-01-22 12:57:48)
>> This series is a part of the conversion to the new struct drm_device
>> based logging macros in drm/i915.
>> This series focuses on the drm/i915/gem directory and converts all
>> straightforward instances of the printk based logging macros to the new
>> macros.
>
> Overall, I'm not keen on this as it perpetuates the mistake of putting
> client debug message in dmesg and now gives them even more an air of
> being device driver debug messages. We need a mechanism by which we
> report the details of what a client did wrong back to that client
> (tracefs + context/client getparam to return an isolated debug fd is my
> idea).
I don't disagree, but I also don't think this makes things (much) worse
in that regard.
>
>> Wambui Karuga (2):
>> drm/i915/gem: initial conversion to new logging macros using
>> coccinelle.
>> drm/i915/gem: manual conversion to struct drm_device logging macros.
>
> Still this is a necessary evil for the current situation,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed both.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Wambui Karuga <wambui.karugax@gmail.com>,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org,
rodrigo.vivi@intel.com
Subject: Re: [Intel-gfx] [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros
Date: Mon, 27 Jan 2020 11:17:37 +0200 [thread overview]
Message-ID: <871rrlcl72.fsf@intel.com> (raw)
In-Reply-To: <157996851987.2524.2577321446102599250@skylake-alporthouse-com>
On Sat, 25 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Wambui Karuga (2020-01-22 12:57:48)
>> This series is a part of the conversion to the new struct drm_device
>> based logging macros in drm/i915.
>> This series focuses on the drm/i915/gem directory and converts all
>> straightforward instances of the printk based logging macros to the new
>> macros.
>
> Overall, I'm not keen on this as it perpetuates the mistake of putting
> client debug message in dmesg and now gives them even more an air of
> being device driver debug messages. We need a mechanism by which we
> report the details of what a client did wrong back to that client
> (tracefs + context/client getparam to return an isolated debug fd is my
> idea).
I don't disagree, but I also don't think this makes things (much) worse
in that regard.
>
>> Wambui Karuga (2):
>> drm/i915/gem: initial conversion to new logging macros using
>> coccinelle.
>> drm/i915/gem: manual conversion to struct drm_device logging macros.
>
> Still this is a necessary evil for the current situation,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed both.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Wambui Karuga <wambui.karugax@gmail.com>,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org,
rodrigo.vivi@intel.com
Subject: Re: [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros
Date: Mon, 27 Jan 2020 11:17:37 +0200 [thread overview]
Message-ID: <871rrlcl72.fsf@intel.com> (raw)
In-Reply-To: <157996851987.2524.2577321446102599250@skylake-alporthouse-com>
On Sat, 25 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Wambui Karuga (2020-01-22 12:57:48)
>> This series is a part of the conversion to the new struct drm_device
>> based logging macros in drm/i915.
>> This series focuses on the drm/i915/gem directory and converts all
>> straightforward instances of the printk based logging macros to the new
>> macros.
>
> Overall, I'm not keen on this as it perpetuates the mistake of putting
> client debug message in dmesg and now gives them even more an air of
> being device driver debug messages. We need a mechanism by which we
> report the details of what a client did wrong back to that client
> (tracefs + context/client getparam to return an isolated debug fd is my
> idea).
I don't disagree, but I also don't think this makes things (much) worse
in that regard.
>
>> Wambui Karuga (2):
>> drm/i915/gem: initial conversion to new logging macros using
>> coccinelle.
>> drm/i915/gem: manual conversion to struct drm_device logging macros.
>
> Still this is a necessary evil for the current situation,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks, pushed both.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2020-01-27 9:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 12:57 [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-22 12:57 ` [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:48 ` Jani Nikula
2020-01-28 13:48 ` Jani Nikula
2020-01-28 14:58 ` Tvrtko Ursulin
2020-01-28 14:58 ` Tvrtko Ursulin
2020-01-28 18:28 ` Chris Wilson
2020-01-28 18:28 ` Chris Wilson
2020-01-29 8:32 ` Jani Nikula
2020-01-29 8:32 ` Jani Nikula
2020-01-29 13:59 ` Jani Nikula
2020-01-29 13:59 ` Jani Nikula
2020-01-22 12:57 ` [PATCH 2/2] drm/i915/gem: manual conversion to struct drm_device logging macros Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-23 19:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: conversion to new drm " Patchwork
2020-01-25 4:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-25 16:08 ` [PATCH 0/2] " Chris Wilson
2020-01-25 16:08 ` Chris Wilson
2020-01-25 16:08 ` [Intel-gfx] " Chris Wilson
2020-01-27 9:05 ` Daniel Vetter
2020-01-27 9:05 ` Daniel Vetter
2020-01-27 9:05 ` [Intel-gfx] " Daniel Vetter
2020-01-27 9:08 ` Chris Wilson
2020-01-27 9:08 ` Chris Wilson
2020-01-27 9:08 ` [Intel-gfx] " Chris Wilson
2020-01-27 9:10 ` Daniel Vetter
2020-01-27 9:10 ` Daniel Vetter
2020-01-27 9:10 ` [Intel-gfx] " Daniel Vetter
2020-01-27 9:17 ` Jani Nikula [this message]
2020-01-27 9:17 ` Jani Nikula
2020-01-27 9:17 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rrlcl72.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.