All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Wambui Karuga <wambui.karugax@gmail.com>,
	airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle
Date: Wed, 29 Jan 2020 15:59:24 +0200	[thread overview]
Message-ID: <87lfpqbbyb.fsf@intel.com> (raw)
In-Reply-To: <87h80eaciw.fsf@intel.com>

On Wed, 29 Jan 2020, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Tue, 28 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Quoting Jani Nikula (2020-01-28 13:48:10)
>>> On Tue, 28 Jan 2020, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>>> >> -DRM_DEBUG(
>>> >> +drm_dbg(&T->drm,
>>> >
>>> > This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe 
>>> > becomes much more spammy.
>>> 
>>> This is what I've instructed Wambui to do in i915. It's my mistake that
>>> I haven't requested this to be pointed out in the commit message.
>>> 
>>> DRM_DEBUG() and DRM_DEBUG_DRIVER() have been conflated over the
>>> years. The former is supposed to be for drm core code only, but drivers
>>> are littered with it. I'm hoping drivers are less likely to use the new
>>> drm_dbg_core() which maps to DRM_DEBUG(). The shorter drm_dbg() is the
>>> new DRM_DEBUG_DRIVER().
>>> 
>>> If you think drm.debug=0xe is too spammy now, the fix is not to abuse
>>> DRM_UT_CORE as a spare category
>>
>> That mistake was made when that category was assigned to user debug like
>> ioctls.
>>
>> Shall I send a revert to remove the spam?
>
> Fine. Please suggest an alternative to DRM_UT_CORE to use here.

How about this for the time being, to continue the conversion:

1. Selectively revert the DRM_DEBUG() calls that were converted to
   drm_dbg() back to DRM_DEBUG() in gt/ and gem/. Let the others be. I
   think elsewhere the conversion is fine.

2. Continue the conversion otherwise, but leave current DRM_DEBUG()
   intact. Except in display/ where I think the conversion is fine.

3. Deal with the DRM_DEBUG() later once we figure out what we want.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Wambui Karuga <wambui.karugax@gmail.com>,
	airlied@linux.ie, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle
Date: Wed, 29 Jan 2020 15:59:24 +0200	[thread overview]
Message-ID: <87lfpqbbyb.fsf@intel.com> (raw)
In-Reply-To: <87h80eaciw.fsf@intel.com>

On Wed, 29 Jan 2020, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Tue, 28 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Quoting Jani Nikula (2020-01-28 13:48:10)
>>> On Tue, 28 Jan 2020, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>>> >> -DRM_DEBUG(
>>> >> +drm_dbg(&T->drm,
>>> >
>>> > This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe 
>>> > becomes much more spammy.
>>> 
>>> This is what I've instructed Wambui to do in i915. It's my mistake that
>>> I haven't requested this to be pointed out in the commit message.
>>> 
>>> DRM_DEBUG() and DRM_DEBUG_DRIVER() have been conflated over the
>>> years. The former is supposed to be for drm core code only, but drivers
>>> are littered with it. I'm hoping drivers are less likely to use the new
>>> drm_dbg_core() which maps to DRM_DEBUG(). The shorter drm_dbg() is the
>>> new DRM_DEBUG_DRIVER().
>>> 
>>> If you think drm.debug=0xe is too spammy now, the fix is not to abuse
>>> DRM_UT_CORE as a spare category
>>
>> That mistake was made when that category was assigned to user debug like
>> ioctls.
>>
>> Shall I send a revert to remove the spam?
>
> Fine. Please suggest an alternative to DRM_UT_CORE to use here.

How about this for the time being, to continue the conversion:

1. Selectively revert the DRM_DEBUG() calls that were converted to
   drm_dbg() back to DRM_DEBUG() in gt/ and gem/. Let the others be. I
   think elsewhere the conversion is fine.

2. Continue the conversion otherwise, but leave current DRM_DEBUG()
   intact. Except in display/ where I think the conversion is fine.

3. Deal with the DRM_DEBUG() later once we figure out what we want.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-29 13:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 12:57 [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-22 12:57 ` [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle Wambui Karuga
2020-01-22 12:57   ` Wambui Karuga
2020-01-22 12:57   ` [Intel-gfx] " Wambui Karuga
2020-01-28 13:25   ` Tvrtko Ursulin
2020-01-28 13:25     ` Tvrtko Ursulin
2020-01-28 13:25     ` Tvrtko Ursulin
2020-01-28 13:48     ` Jani Nikula
2020-01-28 13:48       ` Jani Nikula
2020-01-28 14:58       ` Tvrtko Ursulin
2020-01-28 14:58         ` Tvrtko Ursulin
2020-01-28 18:28       ` Chris Wilson
2020-01-28 18:28         ` Chris Wilson
2020-01-29  8:32         ` Jani Nikula
2020-01-29  8:32           ` Jani Nikula
2020-01-29 13:59           ` Jani Nikula [this message]
2020-01-29 13:59             ` Jani Nikula
2020-01-22 12:57 ` [PATCH 2/2] drm/i915/gem: manual conversion to struct drm_device logging macros Wambui Karuga
2020-01-22 12:57   ` Wambui Karuga
2020-01-22 12:57   ` [Intel-gfx] " Wambui Karuga
2020-01-23 19:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: conversion to new drm " Patchwork
2020-01-25  4:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-25 16:08 ` [PATCH 0/2] " Chris Wilson
2020-01-25 16:08   ` Chris Wilson
2020-01-25 16:08   ` [Intel-gfx] " Chris Wilson
2020-01-27  9:05   ` Daniel Vetter
2020-01-27  9:05     ` Daniel Vetter
2020-01-27  9:05     ` [Intel-gfx] " Daniel Vetter
2020-01-27  9:08     ` Chris Wilson
2020-01-27  9:08       ` Chris Wilson
2020-01-27  9:08       ` [Intel-gfx] " Chris Wilson
2020-01-27  9:10       ` Daniel Vetter
2020-01-27  9:10         ` Daniel Vetter
2020-01-27  9:10         ` [Intel-gfx] " Daniel Vetter
2020-01-27  9:17   ` Jani Nikula
2020-01-27  9:17     ` Jani Nikula
2020-01-27  9:17     ` [Intel-gfx] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfpqbbyb.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=wambui.karugax@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.