From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Wambui Karuga <wambui.karugax@gmail.com>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle
Date: Tue, 28 Jan 2020 15:48:10 +0200 [thread overview]
Message-ID: <87h80fd751.fsf@intel.com> (raw)
In-Reply-To: <b97de5b8-b87f-3b2d-e8bc-942fc21b266e@linux.intel.com>
On Tue, 28 Jan 2020, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> -DRM_DEBUG(
>> +drm_dbg(&T->drm,
>
> This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe
> becomes much more spammy.
This is what I've instructed Wambui to do in i915. It's my mistake that
I haven't requested this to be pointed out in the commit message.
DRM_DEBUG() and DRM_DEBUG_DRIVER() have been conflated over the
years. The former is supposed to be for drm core code only, but drivers
are littered with it. I'm hoping drivers are less likely to use the new
drm_dbg_core() which maps to DRM_DEBUG(). The shorter drm_dbg() is the
new DRM_DEBUG_DRIVER().
If you think drm.debug=0xe is too spammy now, the fix is not to abuse
DRM_UT_CORE as a spare category.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Wambui Karuga <wambui.karugax@gmail.com>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle
Date: Tue, 28 Jan 2020 15:48:10 +0200 [thread overview]
Message-ID: <87h80fd751.fsf@intel.com> (raw)
In-Reply-To: <b97de5b8-b87f-3b2d-e8bc-942fc21b266e@linux.intel.com>
On Tue, 28 Jan 2020, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> -DRM_DEBUG(
>> +drm_dbg(&T->drm,
>
> This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe
> becomes much more spammy.
This is what I've instructed Wambui to do in i915. It's my mistake that
I haven't requested this to be pointed out in the commit message.
DRM_DEBUG() and DRM_DEBUG_DRIVER() have been conflated over the
years. The former is supposed to be for drm core code only, but drivers
are littered with it. I'm hoping drivers are less likely to use the new
drm_dbg_core() which maps to DRM_DEBUG(). The shorter drm_dbg() is the
new DRM_DEBUG_DRIVER().
If you think drm.debug=0xe is too spammy now, the fix is not to abuse
DRM_UT_CORE as a spare category.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-28 13:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 12:57 [PATCH 0/2] drm/i915/gem: conversion to new drm logging macros Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-22 12:57 ` [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:25 ` Tvrtko Ursulin
2020-01-28 13:48 ` Jani Nikula [this message]
2020-01-28 13:48 ` Jani Nikula
2020-01-28 14:58 ` Tvrtko Ursulin
2020-01-28 14:58 ` Tvrtko Ursulin
2020-01-28 18:28 ` Chris Wilson
2020-01-28 18:28 ` Chris Wilson
2020-01-29 8:32 ` Jani Nikula
2020-01-29 8:32 ` Jani Nikula
2020-01-29 13:59 ` Jani Nikula
2020-01-29 13:59 ` Jani Nikula
2020-01-22 12:57 ` [PATCH 2/2] drm/i915/gem: manual conversion to struct drm_device logging macros Wambui Karuga
2020-01-22 12:57 ` Wambui Karuga
2020-01-22 12:57 ` [Intel-gfx] " Wambui Karuga
2020-01-23 19:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: conversion to new drm " Patchwork
2020-01-25 4:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-25 16:08 ` [PATCH 0/2] " Chris Wilson
2020-01-25 16:08 ` Chris Wilson
2020-01-25 16:08 ` [Intel-gfx] " Chris Wilson
2020-01-27 9:05 ` Daniel Vetter
2020-01-27 9:05 ` Daniel Vetter
2020-01-27 9:05 ` [Intel-gfx] " Daniel Vetter
2020-01-27 9:08 ` Chris Wilson
2020-01-27 9:08 ` Chris Wilson
2020-01-27 9:08 ` [Intel-gfx] " Chris Wilson
2020-01-27 9:10 ` Daniel Vetter
2020-01-27 9:10 ` Daniel Vetter
2020-01-27 9:10 ` [Intel-gfx] " Daniel Vetter
2020-01-27 9:17 ` Jani Nikula
2020-01-27 9:17 ` Jani Nikula
2020-01-27 9:17 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h80fd751.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.