All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization <virtualization@lists.linux-foundation.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [RFC 6/11] virtio_pci: don't use the legacy driver if we find the new PCI capabilities.
Date: Thu, 08 Dec 2011 21:08:30 +1030	[thread overview]
Message-ID: <871usfgxg9.fsf@rustcorp.com.au> (raw)
In-Reply-To: 87pqfzgy6p.fsf@rustcorp.com.au


With module option to override.  I assume I can call
pci_find_capability() before pci_request_regions?
---
 drivers/virtio/virtio_pci_legacy.c |   20 +++++++++++++++++++-
 include/linux/virtio_pci.h         |   19 +++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -26,6 +26,10 @@
 #include <linux/highmem.h>
 #include <linux/spinlock.h>
 
+static bool force_nonlegacy;
+module_param(force_nonlegacy, bool, 0644);
+MODULE_PARM_DESC(force_nonlegacy, "Take over non-legacy virtio devices too");
+
 MODULE_AUTHOR("Anthony Liguori <aliguori@us.ibm.com>");
 MODULE_DESCRIPTION("virtio-pci-legacy");
 MODULE_LICENSE("GPL");
@@ -622,7 +626,7 @@ static int __devinit virtio_pci_probe(st
 				      const struct pci_device_id *id)
 {
 	struct virtio_pci_device *vp_dev;
-	int err;
+	int err, cap;
 
 	/* We only own devices >= 0x1000 and <= 0x103f: leave the rest. */
 	if (pci_dev->device < 0x1000 || pci_dev->device > 0x103f)
@@ -654,6 +658,21 @@ static int __devinit virtio_pci_probe(st
 	if (err)
 		goto out;
 
+	/* We leave modern virtio-pci for the modern driver. */
+	cap = virtio_pci_find_capability(pci_dev, VIRTIO_PCI_CAP_COMMON_CFG);
+	if (cap) {
+		if (force_nonlegacy)
+			dev_info(&pci_dev->dev,
+				 "virtio_pci_legacy: forcing legacy mode!\n");
+		else {
+			dev_info(&pci_dev->dev,
+				 "virtio_pci_legacy: leaving to"
+				 " non-legacy driver\n");
+			err = -ENODEV;
+			goto out_enable_device;
+		}
+	}
+
 	err = pci_request_regions(pci_dev, "virtio-pci-legacy");
 	if (err)
 		goto out_enable_device;
diff --git a/include/linux/virtio_pci.h b/include/linux/virtio_pci.h
--- a/include/linux/virtio_pci.h
+++ b/include/linux/virtio_pci.h
@@ -152,4 +152,23 @@ struct virtio_pci_common_cfg {
 	__le16 queue_msix_vector;/* read-write */
 	__le64 queue_address;	/* read-write: 0xFFFFFFFFFFFFFFFF == DNE. */
 };
+
+#ifdef __KERNEL__
+/* Returns offset of the capability, or 0. */
+static inline int virtio_pci_find_capability(struct pci_dev *dev, u8 cfg_type)
+{
+	int pos;
+
+	for (pos = pci_find_capability(dev, PCI_CAP_ID_VNDR);
+	     pos > 0;
+	     pos = pci_find_next_capability(dev, pos, PCI_CAP_ID_VNDR)) {
+		u8 type;
+		pci_read_config_byte(dev, pos + offsetof(struct virtio_pci_cap,
+							 cfg_type), &type);
+		if (type == cfg_type)
+			return pos;
+	}
+	return 0;
+}
+#endif /* __KERNEL__ */
 #endif

  parent reply	other threads:[~2011-12-08 10:38 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 10:22 [PATCH 0/11] RFC: PCI using capabilitities Rusty Russell
2011-12-08 10:30 ` [RFC 1/11] virtio: use u32, not bitmap for struct virtio_device's features Rusty Russell
2011-12-08 10:31 ` [RFC 2/11] virtio: add support for 64 bit features Rusty Russell
2011-12-08 10:32 ` [PATCH 0/11] RFC: PCI using capabilitities Sasha Levin
2011-12-08 10:32 ` [RFC 3/11] pci: add pci_iomap_range Rusty Russell
2011-12-15  8:30   ` Michael S. Tsirkin
2011-12-16  1:56     ` Rusty Russell
2011-12-26 14:05       ` [PATCHv2 RFC] " Michael S Tsirkin
2011-12-26 14:05         ` Michael S Tsirkin
2011-12-08 10:34 ` [RFC 4/11] virtio-pci: define layout for virtio vendor-specific capabilities Rusty Russell
2011-12-10 21:14   ` Sasha Levin
2011-12-08 10:35 ` [RFC 6/11] virtio_pci: move old defines to legacy, introduce new structure Rusty Russell
2011-12-08 10:38 ` Rusty Russell [this message]
2011-12-10 21:18   ` [RFC 6/11] virtio_pci: don't use the legacy driver if we find the new PCI capabilities Sasha Levin
2011-12-11  5:15     ` Rusty Russell
2011-12-11  9:37     ` Michael S. Tsirkin
2011-12-08 10:39 ` [RFC 7/11] virtio_pci: new, capability-aware driver Rusty Russell
2011-12-11  9:42   ` Michael S. Tsirkin
2011-12-11 22:45     ` Rusty Russell
2011-12-12 11:49       ` Michael S. Tsirkin
2011-12-12 18:10         ` Don Dutile
2011-12-16  1:58           ` Rusty Russell
2013-05-28  7:56         ` Michael S. Tsirkin
2013-05-29  1:17           ` Rusty Russell
2013-05-29 10:21             ` Michael S. Tsirkin
2013-05-30  2:17               ` Rusty Russell
2011-12-12 18:25       ` Michael S. Tsirkin
2011-12-13  2:21         ` Rusty Russell
2011-12-15  8:27           ` Michael S. Tsirkin
2011-12-16  1:50             ` Rusty Russell
2011-12-18 10:18               ` Michael S. Tsirkin
2011-12-19  6:06                 ` Rusty Russell
2011-12-19  9:13                   ` Michael S. Tsirkin
2011-12-19 11:08                     ` Rusty Russell
2011-12-20 11:37                       ` Michael S. Tsirkin
2011-12-21  0:33                         ` Rusty Russell
2011-12-21  9:19                           ` Michael S. Tsirkin
2012-01-10 17:03                           ` Michael S. Tsirkin
2012-01-11  0:25                             ` Rusty Russell
2012-01-11  1:48                               ` Benjamin Herrenschmidt
2012-01-11  8:47                               ` Stefan Hajnoczi
2012-01-11  9:10                                 ` Benjamin Herrenschmidt
2012-01-11 14:28                                   ` Stefan Hajnoczi
2012-01-11 15:39                                     ` Michael S. Tsirkin
2012-01-11 17:21                                       ` Stefan Hajnoczi
2012-01-11 18:34                                         ` Michael S. Tsirkin
2012-01-11 20:56                                         ` Benjamin Herrenschmidt
2012-01-11 20:46                                     ` Benjamin Herrenschmidt
2012-01-12 10:37                                       ` Stefan Hajnoczi
2012-01-11 10:21                               ` Michael S. Tsirkin
2012-01-11 21:13                                 ` Benjamin Herrenschmidt
2012-01-11 22:13                                   ` Michael S. Tsirkin
2012-01-11 22:19                                     ` Benjamin Herrenschmidt
2012-01-11 22:56                                     ` Benjamin Herrenschmidt
2012-01-12  5:29                                       ` Michael S. Tsirkin
2012-01-12  6:13                                         ` Benjamin Herrenschmidt
2012-01-12  6:37                                           ` Michael S. Tsirkin
2012-01-12  2:01                                 ` Rusty Russell
2012-01-12  4:31                                   ` Benjamin Herrenschmidt
2012-01-12  6:09                                     ` Michael S. Tsirkin
2012-01-12  6:28                                       ` Benjamin Herrenschmidt
2012-01-12  6:51                                         ` Michael S. Tsirkin
2012-01-12  7:03                                           ` Benjamin Herrenschmidt
2012-01-12  6:00                                   ` Michael S. Tsirkin
2012-01-13  3:22                                     ` Rusty Russell
2012-01-11 13:30                               ` Anthony Liguori
2012-01-11 15:12                                 ` Michael S. Tsirkin
2012-01-11 15:15                                   ` Anthony Liguori
2012-01-11 15:21                                     ` Michael S. Tsirkin
2012-01-11 15:28                                       ` Anthony Liguori
2012-01-11 15:45                                         ` Michael S. Tsirkin
2012-01-11 16:02                                           ` Anthony Liguori
2012-01-11 17:08                                             ` Michael S. Tsirkin
2012-01-11 19:42                                               ` Anthony Liguori
2012-01-11 20:14                                                 ` Michael S. Tsirkin
2012-01-11 20:26                                                   ` Anthony Liguori
2012-01-11 21:02                                                     ` Benjamin Herrenschmidt
2012-01-11 22:02                                                       ` Michael S. Tsirkin
2012-01-11 22:16                                                         ` Benjamin Herrenschmidt
2012-01-12  1:42                                                         ` Rusty Russell
2012-01-13  2:19                                                           ` Michael S. Tsirkin
2012-01-13  2:32                                                             ` Benjamin Herrenschmidt
2012-01-18 15:29                                                               ` Michael S. Tsirkin
2012-01-22 22:53                                                                 ` Rusty Russell
2012-01-18  4:52                                                             ` Rusty Russell
2012-01-11 21:58                                                     ` Michael S. Tsirkin
2012-01-11 20:59                                                 ` Benjamin Herrenschmidt
2012-01-11 20:51                                       ` Benjamin Herrenschmidt
2012-01-11 20:50                                   ` Benjamin Herrenschmidt
2012-01-12  1:35                                 ` Rusty Russell
2011-12-08 10:40 ` [RFC 8/11] virtio_pci: share structure between legacy and modern Rusty Russell
2011-12-08 10:41 ` [RFC 9/11] virtio_pci: share interrupt/notify handlers " Rusty Russell
2011-12-08 10:42 ` [RFC 10/11] virtio_pci: share virtqueue setup/teardown between modern and legacy driver Rusty Russell
2011-12-08 10:44 ` [RFC 11/11] virtio_pci: simplify common helpers Rusty Russell
2011-12-08 15:37 ` [PATCH 0/11] RFC: PCI using capabilitities Sasha Levin
2011-12-08 15:37 ` Sasha Levin
2011-12-09  6:17   ` Rusty Russell
2011-12-10 21:32     ` Sasha Levin
2011-12-11  9:05   ` Avi Kivity
2011-12-11 10:03     ` Sasha Levin
2011-12-11 12:30       ` Michael S. Tsirkin
2011-12-11 12:48         ` Sasha Levin
2011-12-11 12:48         ` Sasha Levin
2011-12-11 12:47   ` Michael S. Tsirkin
2011-12-11 12:53     ` Sasha Levin
2011-12-11 12:53     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871usfgxg9.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=levinsasha928@gmail.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.