From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Marek Puzyniak <marek.puzyniak@tieto.com>
Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
greearb@candelatech.com, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/4] ath10k: Better tx/rx debugging.
Date: Wed, 5 Feb 2014 08:29:43 +0200 [thread overview]
Message-ID: <874n4enkbs.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CADnKcViuR401=cmsMSAVGL04pQ5U5+Kwn5-iUjQ5HfEbbhWcxA@mail.gmail.com> (Marek Puzyniak's message of "Wed, 5 Feb 2014 07:05:08 +0100")
Marek Puzyniak <marek.puzyniak@tieto.com> writes:
> On 4 February 2014 19:55, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> greearb@candelatech.com writes:
>>
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> Make it easier to grep for htt rx errors.
>>>
>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>
>> [...]
>>
>>> @@ -961,6 +962,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>>> }
>>>
>>> if (test_bit(ATH10K_CAC_RUNNING, &htt->ar->dev_flags)) {
>>> + ath10k_warn("htt rx: CAC running\n");
>>> ath10k_htt_rx_free_msdu_chain(msdu_head);
>>> continue;
>>> }
>>
>> I'm a bit worried about this one. Do we guarantee that we will never
>> receive frames while CAC is running? In other words, is this a normal
>> event or really an error in the driver which requires a warning
>> message?
>
> Actually this happens quite often during CAC. I remember we had some
> print there and we got it frequently (let say 10/s).
Yeah, this was exactly what I was wondering.
> So probably it would be better to have choice to enable this log print
> when someone need this information otherwise by default it should be
> disabled.
Maybe a debug message is better?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-02-05 6:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 0:05 [PATCH 1/4] ath10k: Print out firmware feature bits from IE greearb
2014-01-23 0:06 ` [PATCH 2/4] ath10k: Print out size of wmi-ready-event message greearb
2014-01-29 13:16 ` Kalle Valo
2014-02-03 16:53 ` Ben Greear
2014-02-04 5:55 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 3/4] ath10k: Add more debugging for receive errors greearb
2014-02-04 18:51 ` Kalle Valo
2014-02-04 19:35 ` Ben Greear
2014-02-05 8:16 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 4/4] ath10k: Better tx/rx debugging greearb
2014-02-04 18:55 ` Kalle Valo
2014-02-05 6:05 ` Marek Puzyniak
2014-02-05 6:29 ` Kalle Valo [this message]
2014-02-05 9:10 ` Marek Puzyniak
2014-02-05 16:50 ` Ben Greear
2014-02-06 6:17 ` Kalle Valo
2014-02-06 15:20 ` Ben Greear
2014-02-04 18:46 ` [PATCH 1/4] ath10k: Print out firmware feature bits from IE Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n4enkbs.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=janusz.dziedzic@tieto.com \
--cc=marek.puzyniak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.