From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH 3/4] ath10k: Add more debugging for receive errors.
Date: Tue, 4 Feb 2014 20:51:35 +0200 [thread overview]
Message-ID: <87ppn2ognc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1390435562-15473-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 22 Jan 2014 16:06:01 -0800")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -937,6 +937,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
> }
>
> if (ath10k_htt_rx_has_decrypt_err(msdu_head)) {
> + ath10k_warn("htt rx dropping due to decrypt-err\n");
> ath10k_htt_rx_free_msdu_chain(msdu_head);
> continue;
> }
> @@ -975,6 +976,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
> info.skb = msdu_head;
> info.fcs_err = ath10k_htt_rx_has_fcs_err(msdu_head);
> info.mic_err = ath10k_htt_rx_has_mic_err(msdu_head);
> +
> + if (info.fcs_err)
> + ath10k_warn("htt rx has FCS err\n");
> +
> + if (info.mic_err)
> + ath10k_warn("htt rx has MIC err\n");
> +
Do we really want to print warning messages to the user when these
happen? I would consider these as "business as usual" in 802.11 world,
not a problem in driver.
> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -259,7 +259,7 @@ void ath10k_process_rx(struct ath10k *ar, struct htt_rx_info *info)
> status->freq = ch->center_freq;
>
> ath10k_dbg(ATH10K_DBG_DATA,
> - "rx skb %p len %u %s%s%s%s%s %srate_idx %u vht_nss %u freq %u band %u\n",
> + "rx skb %p len %u %s%s%s%s%s %srate_idx %u vht_nss %u freq %u band %u flag: 0x%x fcs-err: %i\n",
> info->skb,
> info->skb->len,
> status->flag == 0 ? "legacy" : "",
> @@ -271,7 +271,7 @@ void ath10k_process_rx(struct ath10k *ar, struct htt_rx_info *info)
> status->rate_idx,
> status->vht_nss,
> status->freq,
> - status->band);
> + status->band, status->flag, info->fcs_err);
This makes sense, but please use the style used in ath10k debug messages:
"... band %u flag 0x%x fcs-err %i\n"
And as status->flag is u32, maybe 0x%08x makes it easier to read and
compare?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-02-04 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 0:05 [PATCH 1/4] ath10k: Print out firmware feature bits from IE greearb
2014-01-23 0:06 ` [PATCH 2/4] ath10k: Print out size of wmi-ready-event message greearb
2014-01-29 13:16 ` Kalle Valo
2014-02-03 16:53 ` Ben Greear
2014-02-04 5:55 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 3/4] ath10k: Add more debugging for receive errors greearb
2014-02-04 18:51 ` Kalle Valo [this message]
2014-02-04 19:35 ` Ben Greear
2014-02-05 8:16 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 4/4] ath10k: Better tx/rx debugging greearb
2014-02-04 18:55 ` Kalle Valo
2014-02-05 6:05 ` Marek Puzyniak
2014-02-05 6:29 ` Kalle Valo
2014-02-05 9:10 ` Marek Puzyniak
2014-02-05 16:50 ` Ben Greear
2014-02-06 6:17 ` Kalle Valo
2014-02-06 15:20 ` Ben Greear
2014-02-04 18:46 ` [PATCH 1/4] ath10k: Print out firmware feature bits from IE Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppn2ognc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.