From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH 3/4] ath10k: Add more debugging for receive errors.
Date: Wed, 5 Feb 2014 10:16:18 +0200 [thread overview]
Message-ID: <87a9e6m0tp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <52F140F3.3000707@candelatech.com> (Ben Greear's message of "Tue, 4 Feb 2014 11:35:15 -0800")
Ben Greear <greearb@candelatech.com> writes:
>>> @@ -975,6 +976,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>>> info.skb = msdu_head;
>>> info.fcs_err = ath10k_htt_rx_has_fcs_err(msdu_head);
>>> info.mic_err = ath10k_htt_rx_has_mic_err(msdu_head);
>>> +
>>> + if (info.fcs_err)
>>> + ath10k_warn("htt rx has FCS err\n");
>>> +
>>> + if (info.mic_err)
>>> + ath10k_warn("htt rx has MIC err\n");
>>> +
>>
>> Do we really want to print warning messages to the user when these
>> happen? I would consider these as "business as usual" in 802.11 world,
>> not a problem in driver.
>
> Maybe I should make them a debug message instead of warning message? That
> way they are only shown if the user enables debugging?
Yeah, having them as debug messages makes sense.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-02-05 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 0:05 [PATCH 1/4] ath10k: Print out firmware feature bits from IE greearb
2014-01-23 0:06 ` [PATCH 2/4] ath10k: Print out size of wmi-ready-event message greearb
2014-01-29 13:16 ` Kalle Valo
2014-02-03 16:53 ` Ben Greear
2014-02-04 5:55 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 3/4] ath10k: Add more debugging for receive errors greearb
2014-02-04 18:51 ` Kalle Valo
2014-02-04 19:35 ` Ben Greear
2014-02-05 8:16 ` Kalle Valo [this message]
2014-01-23 0:06 ` [PATCH 4/4] ath10k: Better tx/rx debugging greearb
2014-02-04 18:55 ` Kalle Valo
2014-02-05 6:05 ` Marek Puzyniak
2014-02-05 6:29 ` Kalle Valo
2014-02-05 9:10 ` Marek Puzyniak
2014-02-05 16:50 ` Ben Greear
2014-02-06 6:17 ` Kalle Valo
2014-02-06 15:20 ` Ben Greear
2014-02-04 18:46 ` [PATCH 1/4] ath10k: Print out firmware feature bits from IE Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9e6m0tp.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.