From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH 1/4] ath10k: Print out firmware feature bits from IE.
Date: Tue, 4 Feb 2014 20:46:24 +0200 [thread overview]
Message-ID: <87txceogvz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1390435562-15473-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 22 Jan 2014 16:05:59 -0800")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Aids in understanding excactly what a firmware is
> offering.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Patch 1 applied, still reviewing the rest.
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -470,8 +470,12 @@ static int ath10k_core_fetch_firmware_api_n(struct ath10k *ar, const char *name)
> if (index == ie_len)
> break;
>
> - if (data[index] & (1 << bit))
> + if (data[index] & (1 << bit)) {
> + ath10k_dbg(ATH10K_DBG_BOOT,
> + "Enabling feature bit: %i\n",
> + i);
> __set_bit(i, ar->fw_features);
> + }
> }
I was actually hoping to have something better like ath6kl has which
prints a name for the feature:
{ ATH6KL_FW_CAPABILITY_HOST_P2P, "host-p2p" },
{ ATH6KL_FW_CAPABILITY_SCHED_SCAN, "sched-scan" },
{ ATH6KL_FW_CAPABILITY_STA_P2PDEV_DUPLEX, "sta-p2pdev-duplex" },
{ ATH6KL_FW_CAPABILITY_INACTIVITY_TIMEOUT, "inactivity-timeout" },
{ ATH6KL_FW_CAPABILITY_RSN_CAP_OVERRIDE, "rsn-cap-override" },
{ ATH6KL_FW_CAPABILITY_WOW_MULTICAST_FILTER, "wow-mc-filter" },
But this is something for the future.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2014-02-04 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 0:05 [PATCH 1/4] ath10k: Print out firmware feature bits from IE greearb
2014-01-23 0:06 ` [PATCH 2/4] ath10k: Print out size of wmi-ready-event message greearb
2014-01-29 13:16 ` Kalle Valo
2014-02-03 16:53 ` Ben Greear
2014-02-04 5:55 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 3/4] ath10k: Add more debugging for receive errors greearb
2014-02-04 18:51 ` Kalle Valo
2014-02-04 19:35 ` Ben Greear
2014-02-05 8:16 ` Kalle Valo
2014-01-23 0:06 ` [PATCH 4/4] ath10k: Better tx/rx debugging greearb
2014-02-04 18:55 ` Kalle Valo
2014-02-05 6:05 ` Marek Puzyniak
2014-02-05 6:29 ` Kalle Valo
2014-02-05 9:10 ` Marek Puzyniak
2014-02-05 16:50 ` Ben Greear
2014-02-06 6:17 ` Kalle Valo
2014-02-06 15:20 ` Ben Greear
2014-02-04 18:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txceogvz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.