From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Christian Lamparter <chunkeey@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"maintainer:BROADCOM BCM5301X ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node
Date: Wed, 19 Aug 2020 11:28:11 -0700 [thread overview]
Message-ID: <8771fd4f-23ca-3685-47f6-b310faa18629@gmail.com> (raw)
In-Reply-To: <CACna6ryhQ=pY0LgpgwbBo5WGXSSfserc3V1ELzD3WLgnTv3n+g@mail.gmail.com>
On 8/19/20 8:36 AM, Rafał Miłecki wrote:
> On Wed, 19 Aug 2020 at 06:23, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> The pin controller resources start at 0xc0 from the CRU base which is at
>> 0x100 from th DMU base, for a final address of 0x1800_c1c0, whereas we
>> are currently off by 0x100. The resource size of the CRU is also
>> incorrect and should end at 0x248 bytes from 0x100 which is the start
>> address. Finally, the compatibility strings defined for the
>> pin-controller node should reflect the SoC being used.
>>
>> Fixes: 9994241ac97c ("ARM: dts: BCM5301X: Describe Northstar pins mux controller")
>
> Let me verify that fix. I'm confused as I believe I got pinctrl
> working for uart1 :|
Sure, please let me know what you find. Chances are that UART1 was
already pinmuxed corectly by the boot loader for your device and this
could have turned out as a no-op.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Christian Lamparter <chunkeey@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
"maintainer:BROADCOM BCM5301X ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix pin controller node
Date: Wed, 19 Aug 2020 11:28:11 -0700 [thread overview]
Message-ID: <8771fd4f-23ca-3685-47f6-b310faa18629@gmail.com> (raw)
In-Reply-To: <CACna6ryhQ=pY0LgpgwbBo5WGXSSfserc3V1ELzD3WLgnTv3n+g@mail.gmail.com>
On 8/19/20 8:36 AM, Rafał Miłecki wrote:
> On Wed, 19 Aug 2020 at 06:23, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> The pin controller resources start at 0xc0 from the CRU base which is at
>> 0x100 from th DMU base, for a final address of 0x1800_c1c0, whereas we
>> are currently off by 0x100. The resource size of the CRU is also
>> incorrect and should end at 0x248 bytes from 0x100 which is the start
>> address. Finally, the compatibility strings defined for the
>> pin-controller node should reflect the SoC being used.
>>
>> Fixes: 9994241ac97c ("ARM: dts: BCM5301X: Describe Northstar pins mux controller")
>
> Let me verify that fix. I'm confused as I believe I got pinctrl
> working for uart1 :|
Sure, please let me know what you find. Chances are that UART1 was
already pinmuxed corectly by the boot loader for your device and this
could have turned out as a no-op.
--
Florian
next prev parent reply other threads:[~2020-08-19 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 4:23 [PATCH] ARM: dts: BCM5301X: Fix pin controller node Florian Fainelli
2020-08-19 4:23 ` Florian Fainelli
2020-08-19 15:27 ` Ray Jui
2020-08-19 15:27 ` Ray Jui
2020-08-19 15:36 ` Rafał Miłecki
2020-08-19 15:36 ` Rafał Miłecki
2020-08-19 18:28 ` Florian Fainelli [this message]
2020-08-19 18:28 ` Florian Fainelli
2020-08-19 20:48 ` Christian Lamparter
2020-08-19 20:48 ` Christian Lamparter
2020-08-19 20:49 ` Florian Fainelli
2020-08-19 20:49 ` Florian Fainelli
2020-08-19 21:14 ` Ray Jui
2020-08-19 21:14 ` Ray Jui
2020-08-19 21:29 ` Florian Fainelli
2020-08-19 21:29 ` Florian Fainelli
2020-08-20 12:20 ` Rafał Miłecki
2020-08-20 12:20 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8771fd4f-23ca-3685-47f6-b310faa18629@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chunkeey@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.