[Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building

[Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building

[Thomas Petazzoni via buildroot]

Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
add detection for the lack of C library") added an $(error ...)
message when no C library is available for the currently selected
architecture.

However, this error message pops up not just when building, so for
example, the command:

  make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars

no longer works (this command is used by the pkg-stats script).

We restore a functional behavior by doing the check only when
BR_BUILDING=y.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index ff60f85092..43d214bcbe 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -53,7 +53,7 @@ else ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
 LIBC = musl
 else ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
 LIBC = gnu
-else
+else ifeq ($(BR_BUILDING),y)
 # This happens if there is a bug in Buildroot that allows an
 # architecture configuration that isn't supported by any library.
 $(error No C library enabled, this is not possible.)
-- 
2.37.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building

[Yann E. MORIN]

Thomas, All,

On 2022-08-21 21:01 +0200, Thomas Petazzoni via buildroot spake thusly:
> Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
> add detection for the lack of C library") added an $(error ...)
> message when no C library is available for the currently selected
> architecture.
> 
> However, this error message pops up not just when building, so for
> example, the command:
> 
>   make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars
> 
> no longer works (this command is used by the pkg-stats script).
> 
> We restore a functional behavior by doing the check only when
> BR_BUILDING=y.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/Makefile.in b/package/Makefile.in
> index ff60f85092..43d214bcbe 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -53,7 +53,7 @@ else ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
>  LIBC = musl
>  else ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
>  LIBC = gnu
> -else
> +else ifeq ($(BR_BUILDING),y)
>  # This happens if there is a bug in Buildroot that allows an
>  # architecture configuration that isn't supported by any library.
>  $(error No C library enabled, this is not possible.)
> -- 
> 2.37.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
 > add detection for the lack of C library") added an $(error ...)
 > message when no C library is available for the currently selected
 > architecture.

 > However, this error message pops up not just when building, so for
 > example, the command:

 >   make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars

 > no longer works (this command is used by the pkg-stats script).

 > We restore a functional behavior by doing the check only when
 > BR_BUILDING=y.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot