Re: [PATCH 00/17] Armada 370/XP NAND driver

[Robert Jarzmik <robert.jarzmik@free.fr>]

Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes:

> Robert,
>
> I pushed another version of the patch set with the following changes:
>
> - Bail out of mrvl_nand_probe_dt early if
>   !IS_ENABLED(CONFIG_OFTREE) || host->dev->platform_data
>
> - Move clkdev_add_physbase() before add_generic_device("mrvl_nand")
>   (Thanks Sascha!)
>
> I hope the issues are resolved now and thanks a lot for testing
> again!
Nope, see [1].
It's this part with match which is NULL in my case:
	const struct mrvl_nand_variant *variant = match->data;

Cheers.

-- 
Robert

[1] Backtrace
unable to handle NULL pointer dereference at address 0x00000004
pc : [<83f15b90>]    lr : [<83f15b7c>]
sp : 83fffed0  ip : 000001c8  fp : 00000000
r10: 00000002  r9 : 83706870  r8 : 83f8c74c
r7 : 00000000  r6 : 00000000  r5 : 83706930  r4 : 00000000
r3 : 83706870  r2 : 83f8518c  r1 : 00000000  r0 : 00000000
Flags: NzCv  IRQs off  FIQs off  Mode SVC_32
[<83f15b90>] (mrvl_nand_probe+0x1a0/0x604) from [<83f0bed8>] (device_probe+0x30/0xb8)
[<83f0bed8>] (device_probe+0x30/0xb8) from [<83f0bfa4>] (match.part.3+0x44/0x54)
[<83f0bfa4>] (match.part.3+0x44/0x54) from [<83f0c518>] (register_device+0x120/0x15c)
[<83f0c518>] (register_device+0x120/0x15c) from [<83f0c7ac>] (add_generic_device+0x3c/0x48)
[<83f0c7ac>] (add_generic_device+0x3c/0x48) from [<83f5a8ec>] (zylonite_devices_init+0x84/0xe8)
[<83f5a8ec>] (zylonite_devices_init+0x84/0xe8) from [<83f01258>] (start_barebox+0x30/0xe8)
[<83f01258>] (start_barebox+0x30/0xe8) from [<83f5cddc>] (__start+0x124/0x13c)
[<83f5cddc>] (__start+0x124/0x13c) from [<8386c1d0>] (0x8386c1d0)

[<83f5c534>] (unwind_backtrace+0x0/0x90) from [<83f01628>] (panic+0x28/0x38)
[<83f01628>] (panic+0x28/0x38) from [<83f5cb9c>] (do_exception+0x10/0x14)
[<83f5cb9c>] (do_exception+0x10/0x14) from [<83f5cc28>] (do_data_abort+0x2c/0x38)
[<83f5cc28>] (do_data_abort+0x2c/0x38) from [<83f5c8f4>] (do_abort_6+0x48/0x54)

@belgarion:~/mio_linux/barebox$ arm-none-eabi-addr2line -e barebox -i 0x83f15b90
/home/rj/mio_linux/barebox/drivers/mtd/nand/nand_mrvl_nfc.c:1174
/home/rj/mio_linux/barebox/drivers/mtd/nand/nand_mrvl_nfc.c:1204

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox