From: Rusty Russell <rusty@rustcorp.com.au>
To: Miche Baker-Harvey <miche@google.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Mike Waychison <mikew@google.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Northrup <digitaleric@google.com>
Subject: Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.
Date: Fri, 11 Nov 2011 14:57:20 +1030 [thread overview]
Message-ID: <877h37qo5z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111108214458.28884.86759.stgit@miche.sea.corp.google.com>
On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey <miche@google.com> wrote:
> Some modifications of vtermno were not done under the spinlock.
>
> Moved assignment from vtermno and increment of vtermno together,
> putting both under the spinlock. Revert vtermno on failure.
>
> Signed-off-by: Miche Baker-Harvey <miche@google.com>
Does it matter? It's normal not to lock in a function called
"init_XXX", since it's not exposed yet.
Or is it?
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Miche Baker-Harvey <miche@google.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Mike Waychison <mikew@google.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Northrup <digitaleric@google.com>
Subject: Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.
Date: Fri, 11 Nov 2011 14:57:20 +1030 [thread overview]
Message-ID: <877h37qo5z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111108214458.28884.86759.stgit@miche.sea.corp.google.com>
On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey <miche@google.com> wrote:
> Some modifications of vtermno were not done under the spinlock.
>
> Moved assignment from vtermno and increment of vtermno together,
> putting both under the spinlock. Revert vtermno on failure.
>
> Signed-off-by: Miche Baker-Harvey <miche@google.com>
Does it matter? It's normal not to lock in a function called
"init_XXX", since it's not exposed yet.
Or is it?
Thanks,
Rusty.
next prev parent reply other threads:[~2011-11-11 4:27 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:44 [PATCH RFC v3 0/3] Support multiple VirtioConsoles Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-08 21:44 ` [PATCH v3 1/3] virtio_console: Fix locking of vtermno Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-11 4:27 ` Rusty Russell [this message]
2011-11-11 4:27 ` Rusty Russell
2011-11-17 19:09 ` Amit Shah
2011-11-17 19:09 ` Amit Shah
2011-11-17 19:09 ` Amit Shah
2011-11-11 4:27 ` Rusty Russell
2011-11-08 21:45 ` [PATCH v3 2/3] hvc_init(): Enforce one-time initialization Miche Baker-Harvey
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-09 7:24 ` Michael Ellerman
2011-11-09 7:24 ` Michael Ellerman
2011-11-09 7:24 ` Michael Ellerman
2011-11-11 4:30 ` Rusty Russell
2011-11-11 4:30 ` Rusty Russell
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-21 5:01 ` Rusty Russell
2011-11-21 5:01 ` Rusty Russell
2011-11-21 5:01 ` Rusty Russell
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-22 0:58 ` Rusty Russell
2011-11-22 0:58 ` Rusty Russell
2011-11-22 0:58 ` Rusty Russell
2011-11-23 10:38 ` Amit Shah
2011-11-23 10:38 ` Amit Shah
2011-11-23 10:38 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:15 ` Amit Shah
2011-11-23 13:15 ` Amit Shah
2011-11-23 13:15 ` Amit Shah
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-29 14:21 ` Amit Shah
2011-11-29 14:21 ` Amit Shah
2011-11-29 14:21 ` Amit Shah
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-12-05 10:54 ` Amit Shah
2011-12-05 10:54 ` Amit Shah
2011-12-05 10:54 ` Amit Shah
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-08 12:08 ` Amit Shah
2011-12-08 12:08 ` Amit Shah
2011-12-08 12:08 ` Amit Shah
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:25 ` Amit Shah
2011-12-12 19:25 ` Amit Shah
2011-12-12 19:25 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-08 21:45 ` [PATCH v3 3/3] Use separate struct console structure for each hvc_console Miche Baker-Harvey
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-09 8:05 ` Michael Ellerman
2011-11-09 8:05 ` Michael Ellerman
2011-11-09 8:05 ` Michael Ellerman
2011-11-08 21:45 ` Miche Baker-Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h37qo5z.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=anton@samba.org \
--cc=digitaleric@google.com \
--cc=gregkh@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miche@google.com \
--cc=mikew@google.com \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.