From: Rusty Russell <rusty@rustcorp.com.au>
To: Miche Baker-Harvey <miche@google.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Mike Waychison <mikew@google.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Northrup <digitaleric@google.com>
Subject: Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.
Date: Mon, 21 Nov 2011 15:31:04 +1030 [thread overview]
Message-ID: <87lira9ii7.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAB8RdapbaueyWLJuJDE_ZdvLkRNM4sQHTxgmgO=jrnXZ6YPSmA@mail.gmail.com>
On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey <miche@google.com> wrote:
> Rusty, Michael, Stephen, et al,
>
> Thanks for your comments on these patches.
>
> For what I'm trying to do, all three patches are necessary, but maybe
> I'm going about it the wrong way. Your input would be appreciated.
> I'm in no way claiming that these patches are "right", just that it's
> working for me, and that what's in the current pool is not.
We have to *understand* the code. If we don't, we need to rewrite the
code so we *do* understand it, or make way for someone who does.
I'm looking at the kvm man page to try to figure out how to have virtio
console, and it's deeply unclear. What kvm commandline are you using?
I'll try to debug it here, and see what I learn about hvc_console.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Miche Baker-Harvey <miche@google.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Mike Waychison <mikew@google.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Northrup <digitaleric@google.com>
Subject: Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.
Date: Mon, 21 Nov 2011 15:31:04 +1030 [thread overview]
Message-ID: <87lira9ii7.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAB8RdapbaueyWLJuJDE_ZdvLkRNM4sQHTxgmgO=jrnXZ6YPSmA@mail.gmail.com>
On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey <miche@google.com> wrote:
> Rusty, Michael, Stephen, et al,
>
> Thanks for your comments on these patches.
>
> For what I'm trying to do, all three patches are necessary, but maybe
> I'm going about it the wrong way. Your input would be appreciated.
> I'm in no way claiming that these patches are "right", just that it's
> working for me, and that what's in the current pool is not.
We have to *understand* the code. If we don't, we need to rewrite the
code so we *do* understand it, or make way for someone who does.
I'm looking at the kvm man page to try to figure out how to have virtio
console, and it's deeply unclear. What kvm commandline are you using?
I'll try to debug it here, and see what I learn about hvc_console.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Miche Baker-Harvey <miche@google.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Anton Blanchard <anton@samba.org>,
Amit Shah <amit.shah@redhat.com>,
Mike Waychison <mikew@google.com>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
Eric Northrup <digitaleric@google.com>
Subject: Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.
Date: Mon, 21 Nov 2011 15:31:04 +1030 [thread overview]
Message-ID: <87lira9ii7.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAB8RdapbaueyWLJuJDE_ZdvLkRNM4sQHTxgmgO=jrnXZ6YPSmA@mail.gmail.com>
On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey <miche@google.com> wrote:
> Rusty, Michael, Stephen, et al,
>
> Thanks for your comments on these patches.
>
> For what I'm trying to do, all three patches are necessary, but maybe
> I'm going about it the wrong way. Your input would be appreciated.
> I'm in no way claiming that these patches are "right", just that it's
> working for me, and that what's in the current pool is not.
We have to *understand* the code. If we don't, we need to rewrite the
code so we *do* understand it, or make way for someone who does.
I'm looking at the kvm man page to try to figure out how to have virtio
console, and it's deeply unclear. What kvm commandline are you using?
I'll try to debug it here, and see what I learn about hvc_console.
Cheers,
Rusty.
next prev parent reply other threads:[~2011-11-21 5:01 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 21:44 [PATCH RFC v3 0/3] Support multiple VirtioConsoles Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-08 21:44 ` [PATCH v3 1/3] virtio_console: Fix locking of vtermno Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-08 21:44 ` Miche Baker-Harvey
2011-11-11 4:27 ` Rusty Russell
2011-11-11 4:27 ` Rusty Russell
2011-11-17 19:09 ` Amit Shah
2011-11-17 19:09 ` Amit Shah
2011-11-17 19:09 ` Amit Shah
2011-11-11 4:27 ` Rusty Russell
2011-11-08 21:45 ` [PATCH v3 2/3] hvc_init(): Enforce one-time initialization Miche Baker-Harvey
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-09 7:24 ` Michael Ellerman
2011-11-09 7:24 ` Michael Ellerman
2011-11-09 7:24 ` Michael Ellerman
2011-11-11 4:30 ` Rusty Russell
2011-11-11 4:30 ` Rusty Russell
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-21 5:01 ` Rusty Russell [this message]
2011-11-21 5:01 ` Rusty Russell
2011-11-21 5:01 ` Rusty Russell
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-22 0:58 ` Rusty Russell
2011-11-22 0:58 ` Rusty Russell
2011-11-22 0:58 ` Rusty Russell
2011-11-21 22:16 ` Miche Baker-Harvey
2011-11-23 10:38 ` Amit Shah
2011-11-23 10:38 ` Amit Shah
2011-11-23 10:38 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 12:56 ` Amit Shah
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:06 ` Sasha Levin
2011-11-23 13:15 ` Amit Shah
2011-11-23 13:15 ` Amit Shah
2011-11-23 13:15 ` Amit Shah
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-28 23:40 ` Miche Baker-Harvey
2011-11-29 14:21 ` Amit Shah
2011-11-29 14:21 ` Amit Shah
2011-11-29 14:21 ` Amit Shah
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:04 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-11-29 17:50 ` Miche Baker-Harvey
2011-12-05 10:54 ` Amit Shah
2011-12-05 10:54 ` Amit Shah
2011-12-05 10:54 ` Amit Shah
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-06 17:05 ` Miche Baker-Harvey
2011-12-08 12:08 ` Amit Shah
2011-12-08 12:08 ` Amit Shah
2011-12-08 12:08 ` Amit Shah
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:11 ` Miche Baker-Harvey
2011-12-12 19:25 ` Amit Shah
2011-12-12 19:25 ` Amit Shah
2011-12-12 19:25 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-12-16 6:00 ` Amit Shah
2011-11-17 18:57 ` Miche Baker-Harvey
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-08 21:45 ` [PATCH v3 3/3] Use separate struct console structure for each hvc_console Miche Baker-Harvey
2011-11-08 21:45 ` Miche Baker-Harvey
2011-11-09 8:05 ` Michael Ellerman
2011-11-09 8:05 ` Michael Ellerman
2011-11-09 8:05 ` Michael Ellerman
2011-11-08 21:45 ` Miche Baker-Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lira9ii7.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=anton@samba.org \
--cc=digitaleric@google.com \
--cc=gregkh@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miche@google.com \
--cc=mikew@google.com \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.