From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] split realmode and loader routines out of startup.S
Date: Wed, 17 Oct 2007 12:04:14 +0200 [thread overview]
Message-ID: <877ilmqcpt.fsf@xs4all.nl> (raw)
In-Reply-To: <20071017085052.GA17346@thorin> (Robert Millan's message of "Wed, 17 Oct 2007 10:50:52 +0200")
Robert Millan <rmh@aybabtu.com> writes:
> On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote:
>> > * kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ...
>> > * kern/i386/loader.S (grub_linux_prot_size): ... here.
>>
>> I would say:
>>
>> (...): Moved from here...
>> (...): ... to here.
>>
>> Can you change that?
>
> Ok (ACKed also for the next patch I already sent).
Great!
>> > * kern/i386/pc/startup.S (grub_linux_tmp_addr): Moved to ...
>> > * kern/i386/loader.S (grub_linux_tmp_addr): ... here.
>> > * kern/i386/pc/startup.S (grub_linux_real_addr): Moved to ...
>> > * kern/i386/loader.S (grub_linux_real_addr): ... here.
>> > * kern/i386/pc/startup.S (grub_linux_boot_zimage): Moved to ...
>> > * kern/i386/loader.S (grub_linux_boot_zimage): ... here.
>> > * kern/i386/pc/startup.S (grub_linux_boot_bzimage): Moved to ...
>> > * kern/i386/loader.S (grub_linux_boot_bzimage): ... here.
>> > * kern/i386/pc/startup.S (grub_multiboot_real_boot): Moved to ...
>> > * kern/i386/loader.S (grub_multiboot_real_boot): ... here.
>> > * kern/i386/pc/startup.S (grub_multiboot2_real_boot): Moved to ...
>> > * kern/i386/loader.S (grub_multiboot2_real_boot): ... here.
>> >
>> > * kern/i386/realmode.S: New file.
>> >
>> > * kern/i386/pc/startup.S (protstack): Moved to ...
>> > * kern/i386/realmode.S (protstack): ... here.
>> > * kern/i386/pc/startup.S (gdt): Moved to ...
>> > * kern/i386/realmode.S (gdt): ... here.
>> > * kern/i386/pc/startup.S (prot_to_real): Moved to ...
>> > * kern/i386/realmode.S (prot_to_real): ... here.
>> >
>> > * kern/i386/pc/startup.S: Include `kern/i386/loader.S' and
>> > `kern/i386/realmode.S'.
>>
>> Why include? Can't it be linked? That's what a linker is for :-)
>
> Linking required wrapping a lot of references with EXT_C() macro, so I opted
> for #include (note this is done for lzo1x.S already).
Is using EXT_C a problem? I don't know this code too well,
unfortunately :(
> Also, #including stuff from the wrong [1] place caused cpu faults in my tests.
> With my current patch, code doesn't change much its location (real mode stuff
> at the beginning, loader stuff at the end).
:-/
> [1] Sorry, I'm not sure what wrong means here. Maybe it has to do with GAS
> syntax magic affecting cross-include borders or with a weird hardcoded
> reference to a specific memory layout.
I can't help you there.
--
Marco
next prev parent reply other threads:[~2007-10-17 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:09 [PATCH] split realmode and loader routines out of startup.S Robert Millan
2007-10-17 8:32 ` Marco Gerards
2007-10-17 8:50 ` Robert Millan
2007-10-17 10:04 ` Marco Gerards [this message]
2007-10-17 10:26 ` Robert Millan
2007-10-17 10:35 ` Marco Gerards
2007-10-18 12:48 ` Robert Millan
2008-01-04 17:15 ` Jeroen Dekkers
2008-01-04 20:39 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ilmqcpt.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.