From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] split realmode and loader routines out of startup.S
Date: Wed, 17 Oct 2007 12:35:03 +0200 [thread overview]
Message-ID: <87y7e2owq0.fsf@xs4all.nl> (raw)
In-Reply-To: <20071017102602.GA21040@thorin> (Robert Millan's message of "Wed, 17 Oct 2007 12:26:02 +0200")
Robert Millan <rmh@aybabtu.com> writes:
> On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote:
>> >
>> > Linking required wrapping a lot of references with EXT_C() macro, so I opted
>> > for #include (note this is done for lzo1x.S already).
>>
>> Is using EXT_C a problem? I don't know this code too well,
>> unfortunately :(
>
> No. Maybe linking bring in other problems, but EXT_C per se isn't a big deal.
> Though do we really want it? It doesn't seem to be a problem for lzo1x.S.
Including is not a big problem for me. It should just not become a
common practise. It's easy to change so I am fine with it.
--
Marco
next prev parent reply other threads:[~2007-10-17 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:09 [PATCH] split realmode and loader routines out of startup.S Robert Millan
2007-10-17 8:32 ` Marco Gerards
2007-10-17 8:50 ` Robert Millan
2007-10-17 10:04 ` Marco Gerards
2007-10-17 10:26 ` Robert Millan
2007-10-17 10:35 ` Marco Gerards [this message]
2007-10-18 12:48 ` Robert Millan
2008-01-04 17:15 ` Jeroen Dekkers
2008-01-04 20:39 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y7e2owq0.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.