From: Jeroen Dekkers <jeroen@vrijschrift.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] split realmode and loader routines out of startup.S
Date: Fri, 04 Jan 2008 18:15:17 +0100 [thread overview]
Message-ID: <87ir29342i.wl@dekkers.cx> (raw)
In-Reply-To: <20071016210907.GA10870@thorin>
At Tue, 16 Oct 2007 23:09:07 +0200,
Robert Millan wrote:
> This patch splits realmode and loader routines out of startup.S. The idea
> is that the LinuxBIOS port can be adapted to share more code with the rest
> of GRUB instead of duplicating it.
>
> This is quite critical stuff, so even if the change seems trivial I'd suggest
> being careful, since I don't trust myself too much. Of course, I've tested
> that it can still boot Linux and Multiboot (on qemu only). Perhaps testing
> on real hardware would be appropiate (but I don't have this handy atm).
<SNIP>
> * kern/i386/pc/startup.S (protstack): Moved to ...
> * kern/i386/realmode.S (protstack): ... here.
> * kern/i386/pc/startup.S (gdt): Moved to ...
> * kern/i386/realmode.S (gdt): ... here.
> * kern/i386/pc/startup.S (prot_to_real): Moved to ...
> * kern/i386/realmode.S (prot_to_real): ... here.
>
> * kern/i386/pc/startup.S: Include `kern/i386/loader.S' and
> `kern/i386/realmode.S'.
Why did you move prot_to_real to realmode.S, but not real_to_prot?
That seems a bit strange to me...
Jeroen Dekkers
next prev parent reply other threads:[~2008-01-04 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:09 [PATCH] split realmode and loader routines out of startup.S Robert Millan
2007-10-17 8:32 ` Marco Gerards
2007-10-17 8:50 ` Robert Millan
2007-10-17 10:04 ` Marco Gerards
2007-10-17 10:26 ` Robert Millan
2007-10-17 10:35 ` Marco Gerards
2007-10-18 12:48 ` Robert Millan
2008-01-04 17:15 ` Jeroen Dekkers [this message]
2008-01-04 20:39 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ir29342i.wl@dekkers.cx \
--to=jeroen@vrijschrift.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.