Re: [RFC PATCH v2 09/12] spi: cadence-quadspi: add PHY tuning infrastructure

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

>>>> +	for_each_child_of_node(partition_np, part_np) {
>>>> +		if (of_property_read_string(part_np, "label", &label) ||
>>>> +		    !strstr(label, "phypattern"))
>>>> +			continue;
>>>
>>> There was already a review comment on the last version. Moving this
>>> into the driver doesn't make it any better. In fact this might
>>> create a (bad) precedent for future drivers.
>>
>> I remember complaining about it but not if there was a solution
>> foreseen. In SPI NAND the solution has been found: the pattern is in the
>> driver and we load it into cache before PHY tuning. But for SPI NOR I
>> understood this wasn't possible. What would be an alternative?
>
> I'm not complaining about using a partition for the pattern but
> about the hardcoded name of it.
>
> It was proposed to use at least a device tree phandle to point to a
> partition (or so).

Ah, yes indeed, thanks for clarifying this up (again) for me. I also
agree the hardcoded name is not ideal.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/