All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt
@ 2020-03-31  9:14 Chris Wilson
  2020-03-31  9:14 ` [Intel-gfx] [PATCH 2/4] drm/i915/execlists: Pause CS flow before reset Chris Wilson
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2020-03-31  9:14 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

Since we don't wait for the error interrupt to reset, restart and then
complete the guilty request, clean up the error messages.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index d3e163c93e22..b929e52a8f5a 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -649,9 +649,9 @@ static int live_error_interrupt(void *arg)
 						 error_repr(p->error[i]));
 
 				if (!i915_request_started(client[i])) {
-					pr_debug("%s: %s request not stated!\n",
-						 engine->name,
-						 error_repr(p->error[i]));
+					pr_err("%s: %s request not started!\n",
+					       engine->name,
+					       error_repr(p->error[i]));
 					err = -ETIME;
 					goto out;
 				}
@@ -659,9 +659,10 @@ static int live_error_interrupt(void *arg)
 				/* Kick the tasklet to process the error */
 				intel_engine_flush_submission(engine);
 				if (client[i]->fence.error != p->error[i]) {
-					pr_err("%s: %s request completed with wrong error code: %d\n",
+					pr_err("%s: %s request (%s) with wrong error code: %d\n",
 					       engine->name,
 					       error_repr(p->error[i]),
+					       i915_request_completed(client[i]) ? "completed" : "running",
 					       client[i]->fence.error);
 					err = -EINVAL;
 					goto out;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-04-01  8:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31  9:14 [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt Chris Wilson
2020-03-31  9:14 ` [Intel-gfx] [PATCH 2/4] drm/i915/execlists: Pause CS flow before reset Chris Wilson
2020-03-31 13:08   ` Mika Kuoppala
2020-03-31  9:14 ` [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Peek at the next submission for error interrupts Chris Wilson
2020-03-31  9:14 ` [Intel-gfx] [PATCH 4/4] drm/i915/execlists: Record the active CCID from before reset Chris Wilson
2020-03-31 11:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt Patchwork
2020-03-31 13:07 ` [Intel-gfx] [PATCH 1/4] " Mika Kuoppala
2020-04-01  8:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.