Re: [SPAM] [PATCH v1 02/21] hw/arm/ast27x0: Move SSP coprocessor initialization from machine to SoC leve

[Markus Armbruster <armbru@redhat.com>]

To: Jamin Lin <jamin_lin@aspeedtech.com>
Subject: Re: [SPAM] [PATCH v1 02/21] hw/arm/ast27x0: Move SSP coprocessor initialization from machine to SoC leve
Gcc: nnml:mail.redhat.xlst.qemu-devel
From: Markus Armbruster <armbru@redhat.com>
--text follows this line--
Jamin Lin <jamin_lin@aspeedtech.com> writes:

> Hi Markus,

[...]

>> object_property_set_link() can return false only when it fails, and it sets an
>> error when it fails.  Since you pass &error_abort, it cannot fail (it aborts
>> instead).  Therefore the return value is always true, and the return statement
>> is dead code.
>> 
>> If object_property_set_link() is not expected to fail, i.e. failure would be a
>> programming error, use
>> 
>>         object_property_set_link(..., &error_abort);
>> 
>> If failure is not a programming error, passing &error_abort is wrong, and you
>> need to pass errp instead.
>> 
>> >> +
>> >> +    if (!qdev_realize(DEVICE(&a->ssp), NULL, &error_abort)) {
>> >
>> > same here.
>> 
>
> Thanks for the detailed explanation - that clarifies the intent and the
> difference between using "error_abort" and "errp".
> Appreciate your help.
> Thanks again Jamin

You're welcome!