All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Remove duplicate `const` qualifier
Date: Tue, 09 Feb 2016 17:28:43 +0200	[thread overview]
Message-ID: <87io1x2990.fsf@intel.com> (raw)
In-Reply-To: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com>

On Tue, 09 Feb 2016, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on
> that line.

Too late, fixed in

commit 70c0616d5a8458ae9148d74309cede07ba2f5164
Author: Colin Ian King <colin.king@canonical.com>
Date:   Wed Jan 20 10:59:34 2016 +0000

    drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc

BR,
Jani.


>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
>  };
>  
>  static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> -	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> +	const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
>  	unsigned int num_planes)
>  {
>  	struct drm_fb_cma *fb_cma;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Remove duplicate `const` qualifier
Date: Tue, 09 Feb 2016 17:28:43 +0200	[thread overview]
Message-ID: <87io1x2990.fsf@intel.com> (raw)
In-Reply-To: <1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com>

On Tue, 09 Feb 2016, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on
> that line.

Too late, fixed in

commit 70c0616d5a8458ae9148d74309cede07ba2f5164
Author: Colin Ian King <colin.king@canonical.com>
Date:   Wed Jan 20 10:59:34 2016 +0000

    drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc

BR,
Jani.


>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
>  };
>  
>  static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> -	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> +	const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
>  	unsigned int num_planes)
>  {
>  	struct drm_fb_cma *fb_cma;

-- 
Jani Nikula, Intel Open Source Technology Center

  parent reply	other threads:[~2016-02-09 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 15:18 [PATCH] drm: Remove duplicate `const` qualifier Eric Engestrom
2016-02-09 15:18 ` Eric Engestrom
2016-02-09 15:24 ` Ville Syrjälä
2016-02-09 15:24   ` Ville Syrjälä
2016-02-09 15:28 ` Jani Nikula [this message]
2016-02-09 15:28   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io1x2990.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.