* [PATCH] drm: Remove duplicate `const` qualifier
@ 2016-02-09 15:18 ` Eric Engestrom
0 siblings, 0 replies; 6+ messages in thread
From: Eric Engestrom @ 2016-02-09 15:18 UTC (permalink / raw)
To: David Airlie, dri-devel, linux-kernel
Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c895b6f..c4309df 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
};
static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
- const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
+ const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
unsigned int num_planes)
{
struct drm_fb_cma *fb_cma;
--
2.7.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm: Remove duplicate `const` qualifier
@ 2016-02-09 15:18 ` Eric Engestrom
0 siblings, 0 replies; 6+ messages in thread
From: Eric Engestrom @ 2016-02-09 15:18 UTC (permalink / raw)
To: David Airlie, dri-devel, linux-kernel; +Cc: Eric Engestrom
Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c895b6f..c4309df 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
};
static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
- const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
+ const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
unsigned int num_planes)
{
struct drm_fb_cma *fb_cma;
--
2.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: Remove duplicate `const` qualifier
2016-02-09 15:18 ` Eric Engestrom
@ 2016-02-09 15:24 ` Ville Syrjälä
-1 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2016-02-09 15:24 UTC (permalink / raw)
To: Eric Engestrom; +Cc: linux-kernel, dri-devel
On Tue, Feb 09, 2016 at 03:18:05PM +0000, Eric Engestrom wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.
Already fixed
70c0616d5a84 ("drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc")
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: Remove duplicate `const` qualifier
@ 2016-02-09 15:24 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2016-02-09 15:24 UTC (permalink / raw)
To: Eric Engestrom; +Cc: David Airlie, dri-devel, linux-kernel
On Tue, Feb 09, 2016 at 03:18:05PM +0000, Eric Engestrom wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.
Already fixed
70c0616d5a84 ("drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc")
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Remove duplicate `const` qualifier
2016-02-09 15:18 ` Eric Engestrom
@ 2016-02-09 15:28 ` Jani Nikula
-1 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2016-02-09 15:28 UTC (permalink / raw)
To: Eric Engestrom, David Airlie, dri-devel, linux-kernel
On Tue, 09 Feb 2016, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on
> that line.
Too late, fixed in
commit 70c0616d5a8458ae9148d74309cede07ba2f5164
Author: Colin Ian King <colin.king@canonical.com>
Date: Wed Jan 20 10:59:34 2016 +0000
drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
BR,
Jani.
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: Remove duplicate `const` qualifier
@ 2016-02-09 15:28 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2016-02-09 15:28 UTC (permalink / raw)
To: Eric Engestrom, David Airlie, dri-devel, linux-kernel
On Tue, 09 Feb 2016, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on
> that line.
Too late, fixed in
commit 70c0616d5a8458ae9148d74309cede07ba2f5164
Author: Colin Ian King <colin.king@canonical.com>
Date: Wed Jan 20 10:59:34 2016 +0000
drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
BR,
Jani.
>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-09 15:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 15:18 [PATCH] drm: Remove duplicate `const` qualifier Eric Engestrom
2016-02-09 15:18 ` Eric Engestrom
2016-02-09 15:24 ` Ville Syrjälä
2016-02-09 15:24 ` Ville Syrjälä
2016-02-09 15:28 ` Jani Nikula
2016-02-09 15:28 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.