All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"open list\:ARM" <qemu-arm@nongnu.org>,
	qemu-devel@nongnu.org, rth@twiddle.net, pbonzini@redhat.com
Subject: Re: [PATCH 1/5] target/arm: Remove stale comment
Date: Tue, 05 Sep 2017 13:02:22 +0100	[thread overview]
Message-ID: <87lgltmjzl.fsf@linaro.org> (raw)
In-Reply-To: <20170829063313.10237-1-bobby.prani@gmail.com>


Pranith Kumar <bobby.prani@gmail.com> writes:

> Update the comment which is not true since MTTCG.

What happened to the cover letter? We seem to have a mix of patches but
no summary of the overall outcome.

>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
>  target/arm/translate-a64.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 2200e25be0..f42b155d7d 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -2012,10 +2012,6 @@ static void disas_ldst_excl(DisasContext *s, uint32_t insn)
>      }
>      tcg_addr = read_cpu_reg_sp(s, rn, 1);
>
> -    /* Note that since TCG is single threaded load-acquire/store-release
> -     * semantics require no extra if (is_lasr) { ... } handling.
> -     */
> -
>      if (is_excl) {
>          if (!is_store) {
>              s->is_ldex = true;


--
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"open list:ARM" <qemu-arm@nongnu.org>,
	qemu-devel@nongnu.org, rth@twiddle.net, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment
Date: Tue, 05 Sep 2017 13:02:22 +0100	[thread overview]
Message-ID: <87lgltmjzl.fsf@linaro.org> (raw)
In-Reply-To: <20170829063313.10237-1-bobby.prani@gmail.com>


Pranith Kumar <bobby.prani@gmail.com> writes:

> Update the comment which is not true since MTTCG.

What happened to the cover letter? We seem to have a mix of patches but
no summary of the overall outcome.

>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
>  target/arm/translate-a64.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 2200e25be0..f42b155d7d 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -2012,10 +2012,6 @@ static void disas_ldst_excl(DisasContext *s, uint32_t insn)
>      }
>      tcg_addr = read_cpu_reg_sp(s, rn, 1);
>
> -    /* Note that since TCG is single threaded load-acquire/store-release
> -     * semantics require no extra if (is_lasr) { ... } handling.
> -     */
> -
>      if (is_excl) {
>          if (!is_store) {
>              s->is_ldex = true;


--
Alex Bennée

  parent reply	other threads:[~2017-09-05 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29  6:33 [PATCH 1/5] target/arm: Remove stale comment Pranith Kumar
2017-08-29  6:33 ` [Qemu-devel] " Pranith Kumar
2017-08-29  6:33 ` [Qemu-devel] [RFC v3 PATCH 2/5] cpus-common: Cache allocated work items Pranith Kumar
2017-09-05 12:28   ` Alex Bennée
2017-08-29  6:33 ` [RFC v3 PATCH 3/5] mttcg: Add tcg target default memory ordering Pranith Kumar
2017-08-29  6:33   ` [Qemu-devel] " Pranith Kumar
2017-08-29 14:51   ` Richard Henderson
2017-08-29 14:51     ` [Qemu-devel] " Richard Henderson
2017-08-29  6:33 ` [Qemu-devel] [RFC v3 PATCH 4/5] mttcg: Implement implicit ordering semantics Pranith Kumar
2017-08-29 14:53   ` Richard Henderson
2017-09-02  1:44   ` Emilio G. Cota
2017-08-29  6:33 ` [RFC v3 PATCH 5/5] tcg/softmmu: Increase size of TLB caches Pranith Kumar
2017-08-29  6:33   ` [Qemu-devel] " Pranith Kumar
2017-08-29 15:01   ` Richard Henderson
2017-08-29 15:01     ` [Qemu-devel] " Richard Henderson
2017-08-29 16:23     ` Pranith Kumar
2017-08-29 16:23       ` [Qemu-devel] " Pranith Kumar
2017-08-29 15:03   ` Richard Henderson
2017-08-29 15:03     ` [Qemu-devel] " Richard Henderson
2017-09-05 12:02 ` Alex Bennée [this message]
2017-09-05 12:02   ` [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment Alex Bennée
2017-09-06  0:35   ` Pranith Kumar
2017-09-06  0:35     ` [Qemu-devel] " Pranith Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgltmjzl.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bobby.prani@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.