From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Matthew Bobrowski <repnop@google.com>
Cc: pvorel@suse.cz, Amir Goldstein <amir73il@gmail.com>,
kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
Jan Kara <jack@suse.com>, Ext4 <linux-ext4@vger.kernel.org>,
LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR
Date: Mon, 23 Aug 2021 10:34:54 -0400 [thread overview]
Message-ID: <87o89o2prl.fsf@collabora.com> (raw)
In-Reply-To: <YSAlb7XGUNoc73ZJ@google.com> (Matthew Bobrowski's message of "Sat, 21 Aug 2021 07:58:07 +1000")
Matthew Bobrowski <repnop@google.com> writes:
> Hey Gabriel,
>
> On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote:
>> Hi all,
>>
>> > No problem. That's what review is for ;-)
>>
>> > BTW, unless anyone is specifically interested I don't think there
>> > is a reason to re post the test patches before the submission request.
>> > Certainly not for the small fixes that I requested.
>>
>> > I do request that you post a link to a branch with the fixed test
>> > so that we can experiment with the kernel patches.
>>
>> > I've also CC'ed Matthew who may want to help with review of the test
>> > and man page that you posted in the cover letter [1].
>>
>> @Amir Thanks a lot for your review, agree with all you mentioned.
>>
>> @Gabriel Thanks for your contribution. I'd also consider squashing some of the
>> commits.
>
> Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so,
> I may need to do some shuffling around as these LTP tests collide with the
> ones I author for the FAN_REPORT_PIDFD series.
>
Matthew,
Hi, sorry for the delay. I took a short vacation and couldn't follow
up. I think it is too late for 5.15, please go ahead with
FAN_REPORT_PIDFD series and I will consider them in my future
submission.
Thank you,
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR
Date: Mon, 23 Aug 2021 10:34:54 -0400 [thread overview]
Message-ID: <87o89o2prl.fsf@collabora.com> (raw)
In-Reply-To: <YSAlb7XGUNoc73ZJ@google.com> (Matthew Bobrowski's message of "Sat, 21 Aug 2021 07:58:07 +1000")
Matthew Bobrowski <repnop@google.com> writes:
> Hey Gabriel,
>
> On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote:
>> Hi all,
>>
>> > No problem. That's what review is for ;-)
>>
>> > BTW, unless anyone is specifically interested I don't think there
>> > is a reason to re post the test patches before the submission request.
>> > Certainly not for the small fixes that I requested.
>>
>> > I do request that you post a link to a branch with the fixed test
>> > so that we can experiment with the kernel patches.
>>
>> > I've also CC'ed Matthew who may want to help with review of the test
>> > and man page that you posted in the cover letter [1].
>>
>> @Amir Thanks a lot for your review, agree with all you mentioned.
>>
>> @Gabriel Thanks for your contribution. I'd also consider squashing some of the
>> commits.
>
> Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so,
> I may need to do some shuffling around as these LTP tests collide with the
> ones I author for the FAN_REPORT_PIDFD series.
>
Matthew,
Hi, sorry for the delay. I took a short vacation and couldn't follow
up. I think it is too late for 5.15, please go ahead with
FAN_REPORT_PIDFD series and I will consider them in my future
submission.
Thank you,
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2021-08-23 14:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 21:46 [PATCH 0/7] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 1/7] syscalls/fanotify20: Introduce helpers for FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:30 ` Amir Goldstein
2021-08-03 8:30 ` [LTP] " Amir Goldstein
2021-08-02 21:46 ` [PATCH 2/7] syscalls/fanotify20: Validate the generic error info Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:42 ` Amir Goldstein
2021-08-03 8:42 ` [LTP] " Amir Goldstein
2021-08-02 21:46 ` [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:56 ` Amir Goldstein
2021-08-03 8:56 ` [LTP] " Amir Goldstein
2021-08-04 4:54 ` Gabriel Krisman Bertazi
2021-08-04 4:54 ` [LTP] " Gabriel Krisman Bertazi
2021-08-04 5:39 ` Amir Goldstein
2021-08-04 5:39 ` [LTP] " Amir Goldstein
2021-08-04 7:40 ` Matthew Bobrowski
2021-08-04 7:40 ` [LTP] " Matthew Bobrowski
2021-08-20 10:21 ` Petr Vorel
2021-08-20 10:21 ` Petr Vorel
2021-08-20 21:58 ` Matthew Bobrowski
2021-08-20 21:58 ` Matthew Bobrowski
2021-08-23 9:35 ` Jan Kara
2021-08-23 9:35 ` Jan Kara
2021-08-23 11:19 ` Matthew Bobrowski
2021-08-23 11:19 ` Matthew Bobrowski
2021-08-23 14:34 ` Gabriel Krisman Bertazi [this message]
2021-08-23 14:34 ` Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 4/7] syscalls/fanotify20: Watch event after filesystem abort Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 5/7] syscalls/fanotify20: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 6/7] syscalls/fanotify20: Test file event with broken inode Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 9:04 ` Amir Goldstein
2021-08-03 9:04 ` [LTP] " Amir Goldstein
2021-08-03 9:08 ` Amir Goldstein
2021-08-03 9:08 ` [LTP] " Amir Goldstein
2021-08-04 4:52 ` Gabriel Krisman Bertazi
2021-08-04 4:52 ` [LTP] " Gabriel Krisman Bertazi
2021-08-04 5:27 ` Amir Goldstein
2021-08-04 5:27 ` [LTP] " Amir Goldstein
2021-08-05 21:50 ` Gabriel Krisman Bertazi
2021-08-05 21:50 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 7/7] syscalls/fanotify20: Test capture of multiple errors Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o89o2prl.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.