From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
Ext4 <linux-ext4@vger.kernel.org>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR
Date: Fri, 20 Aug 2021 12:21:19 +0200 [thread overview]
Message-ID: <YR+CH2+GYzwU2/SG@pevik> (raw)
In-Reply-To: <CAOQ4uxj_WwDPxZv0nr9+Hh+pim6+2onaBdFq_BR-qK=xz+8yUg@mail.gmail.com>
Hi all,
> No problem. That's what review is for ;-)
> BTW, unless anyone is specifically interested I don't think there
> is a reason to re post the test patches before the submission request.
> Certainly not for the small fixes that I requested.
> I do request that you post a link to a branch with the fixed test
> so that we can experiment with the kernel patches.
> I've also CC'ed Matthew who may want to help with review of the test
> and man page that you posted in the cover letter [1].
@Amir Thanks a lot for your review, agree with all you mentioned.
@Gabriel Thanks for your contribution. I'd also consider squashing some of the
commits.
Kind regards,
Petr
> Thanks,
> Amir.
> [1] https://lore.kernel.org/linux-ext4/20210802214645.2633028-1-krisman@collabora.com/T/#m9cf637c6aca94e28390f61deac5a53afbc9e88ae
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR
Date: Fri, 20 Aug 2021 12:21:19 +0200 [thread overview]
Message-ID: <YR+CH2+GYzwU2/SG@pevik> (raw)
In-Reply-To: <CAOQ4uxj_WwDPxZv0nr9+Hh+pim6+2onaBdFq_BR-qK=xz+8yUg@mail.gmail.com>
Hi all,
> No problem. That's what review is for ;-)
> BTW, unless anyone is specifically interested I don't think there
> is a reason to re post the test patches before the submission request.
> Certainly not for the small fixes that I requested.
> I do request that you post a link to a branch with the fixed test
> so that we can experiment with the kernel patches.
> I've also CC'ed Matthew who may want to help with review of the test
> and man page that you posted in the cover letter [1].
@Amir Thanks a lot for your review, agree with all you mentioned.
@Gabriel Thanks for your contribution. I'd also consider squashing some of the
commits.
Kind regards,
Petr
> Thanks,
> Amir.
> [1] https://lore.kernel.org/linux-ext4/20210802214645.2633028-1-krisman@collabora.com/T/#m9cf637c6aca94e28390f61deac5a53afbc9e88ae
next prev parent reply other threads:[~2021-08-20 10:21 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 21:46 [PATCH 0/7] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 1/7] syscalls/fanotify20: Introduce helpers for FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:30 ` Amir Goldstein
2021-08-03 8:30 ` [LTP] " Amir Goldstein
2021-08-02 21:46 ` [PATCH 2/7] syscalls/fanotify20: Validate the generic error info Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:42 ` Amir Goldstein
2021-08-03 8:42 ` [LTP] " Amir Goldstein
2021-08-02 21:46 ` [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 8:56 ` Amir Goldstein
2021-08-03 8:56 ` [LTP] " Amir Goldstein
2021-08-04 4:54 ` Gabriel Krisman Bertazi
2021-08-04 4:54 ` [LTP] " Gabriel Krisman Bertazi
2021-08-04 5:39 ` Amir Goldstein
2021-08-04 5:39 ` [LTP] " Amir Goldstein
2021-08-04 7:40 ` Matthew Bobrowski
2021-08-04 7:40 ` [LTP] " Matthew Bobrowski
2021-08-20 10:21 ` Petr Vorel [this message]
2021-08-20 10:21 ` Petr Vorel
2021-08-20 21:58 ` Matthew Bobrowski
2021-08-20 21:58 ` Matthew Bobrowski
2021-08-23 9:35 ` Jan Kara
2021-08-23 9:35 ` Jan Kara
2021-08-23 11:19 ` Matthew Bobrowski
2021-08-23 11:19 ` Matthew Bobrowski
2021-08-23 14:34 ` Gabriel Krisman Bertazi
2021-08-23 14:34 ` Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 4/7] syscalls/fanotify20: Watch event after filesystem abort Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 5/7] syscalls/fanotify20: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 6/7] syscalls/fanotify20: Test file event with broken inode Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
2021-08-03 9:04 ` Amir Goldstein
2021-08-03 9:04 ` [LTP] " Amir Goldstein
2021-08-03 9:08 ` Amir Goldstein
2021-08-03 9:08 ` [LTP] " Amir Goldstein
2021-08-04 4:52 ` Gabriel Krisman Bertazi
2021-08-04 4:52 ` [LTP] " Gabriel Krisman Bertazi
2021-08-04 5:27 ` Amir Goldstein
2021-08-04 5:27 ` [LTP] " Amir Goldstein
2021-08-05 21:50 ` Gabriel Krisman Bertazi
2021-08-05 21:50 ` [LTP] " Gabriel Krisman Bertazi
2021-08-02 21:46 ` [PATCH 7/7] syscalls/fanotify20: Test capture of multiple errors Gabriel Krisman Bertazi
2021-08-02 21:46 ` [LTP] " Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR+CH2+GYzwU2/SG@pevik \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.