From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure
Date: Wed, 10 Jul 2019 09:38:54 +0100 [thread overview]
Message-ID: <87pnmie129.fsf@zen.linaroharston> (raw)
In-Reply-To: <b42c405b-1b20-28b4-07c0-24df9a183e16@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 7/5/19 6:04 PM, Alex Bennée wrote:
>> +diff-out = $(call quiet-command, diff -q $1.out $2 || \
>> + (diff -u $1.out $2 | head -n 10 && false), \
>
> What about (set -o pipefail; diff ... | head) ?
> I think we already rely on bash, right?
I don't think so - we assume POSIX shell for configure and AFAICT we
don't do anything special in the make system to set the shell type to
bash.
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure
Date: Wed, 10 Jul 2019 09:38:54 +0100 [thread overview]
Message-ID: <87pnmie129.fsf@zen.linaroharston> (raw)
In-Reply-To: <b42c405b-1b20-28b4-07c0-24df9a183e16@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 7/5/19 6:04 PM, Alex Bennée wrote:
>> +diff-out = $(call quiet-command, diff -q $1.out $2 || \
>> + (diff -u $1.out $2 | head -n 10 && false), \
>
> What about (set -o pipefail; diff ... | head) ?
> I think we already rely on bash, right?
I don't think so - we assume POSIX shell for configure and AFAICT we
don't do anything special in the make system to set the shell type to
bash.
--
Alex Bennée
next prev parent reply other threads:[~2019-07-10 8:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:04 [PATCH for 4.1 0/5] tcg tests and gdbstub fixes Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 1/5] target/arm/vfp_helper: Call set_fpscr_to_host before updating FPSCR reg Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 6:58 ` Richard Henderson
2019-07-10 6:58 ` Richard Henderson
2019-07-10 10:41 ` Philippe Mathieu-Daudé
2019-07-10 10:41 ` Philippe Mathieu-Daudé
2019-07-10 11:32 ` Alex Bennée
2019-07-10 11:32 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:41 ` Richard Henderson
2019-07-10 8:38 ` Alex Bennée [this message]
2019-07-10 8:38 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 4/5] gdbstub: add some notes to the header comment Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:14 ` Philippe Mathieu-Daudé
2019-07-05 16:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-10 7:14 ` Richard Henderson
2019-07-10 7:14 ` Richard Henderson
2019-07-10 15:28 ` Alex Bennée
2019-07-10 15:28 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:15 ` Richard Henderson
2019-07-10 7:15 ` Richard Henderson
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:33 ` Aleksandar Markovic
2019-07-10 9:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnmie129.fsf@zen.linaroharston \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.