From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-arm@nongnu.org, "Jon Doron" <arilou@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour
Date: Wed, 10 Jul 2019 09:15:38 +0200 [thread overview]
Message-ID: <fecd49db-8517-764f-d998-bca7656de8d1@linaro.org> (raw)
In-Reply-To: <20190705160421.19015-6-alex.bennee@linaro.org>
On 7/5/19 6:04 PM, Alex Bennée wrote:
> The refactoring of handle_set_reg missed the fact we previously had
> responded with an empty packet when we were not using XML based
> protocols. This broke the fallback behaviour for architectures that
> don't have registers defined in QEMU's gdb-xml directory.
>
> Revert to the previous behaviour and clean up the commentary for what
> is going on.
>
> Fixes: 62b3320bddd
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Jon Doron <arilou@gmail.com>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> gdbstub.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Jon Doron" <arilou@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour
Date: Wed, 10 Jul 2019 09:15:38 +0200 [thread overview]
Message-ID: <fecd49db-8517-764f-d998-bca7656de8d1@linaro.org> (raw)
In-Reply-To: <20190705160421.19015-6-alex.bennee@linaro.org>
On 7/5/19 6:04 PM, Alex Bennée wrote:
> The refactoring of handle_set_reg missed the fact we previously had
> responded with an empty packet when we were not using XML based
> protocols. This broke the fallback behaviour for architectures that
> don't have registers defined in QEMU's gdb-xml directory.
>
> Revert to the previous behaviour and clean up the commentary for what
> is going on.
>
> Fixes: 62b3320bddd
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Jon Doron <arilou@gmail.com>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> gdbstub.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-07-10 7:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:04 [PATCH for 4.1 0/5] tcg tests and gdbstub fixes Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 1/5] target/arm/vfp_helper: Call set_fpscr_to_host before updating FPSCR reg Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 6:58 ` Richard Henderson
2019-07-10 6:58 ` Richard Henderson
2019-07-10 10:41 ` Philippe Mathieu-Daudé
2019-07-10 10:41 ` Philippe Mathieu-Daudé
2019-07-10 11:32 ` Alex Bennée
2019-07-10 11:32 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:41 ` Richard Henderson
2019-07-10 8:38 ` Alex Bennée
2019-07-10 8:38 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 4/5] gdbstub: add some notes to the header comment Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:14 ` Philippe Mathieu-Daudé
2019-07-05 16:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-10 7:14 ` Richard Henderson
2019-07-10 7:14 ` Richard Henderson
2019-07-10 15:28 ` Alex Bennée
2019-07-10 15:28 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:15 ` Richard Henderson [this message]
2019-07-10 7:15 ` Richard Henderson
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:33 ` Aleksandar Markovic
2019-07-10 9:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fecd49db-8517-764f-d998-bca7656de8d1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=arilou@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.