From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-arm@nongnu.org, Jan Bobek <jan.bobek@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation
Date: Wed, 10 Jul 2019 12:41:20 +0200 [thread overview]
Message-ID: <af417ca3-248a-d1a8-51c4-46676b6d9d4a@redhat.com> (raw)
In-Reply-To: <20190705160421.19015-3-alex.bennee@linaro.org>
On 7/5/19 6:04 PM, Alex Bennée wrote:
> We never shipped the reference data in the source tree because it was
> quite big (64M). As a result the only option is to generate it
Can we fetch it (with hash verification) or store it compressed?
$ du -ch pc-bios/edk2-*bz2
1.2M pc-bios/edk2-aarch64-code.fd.bz2
1.2M pc-bios/edk2-arm-code.fd.bz2
4.0K pc-bios/edk2-arm-vars.fd.bz2
1.7M pc-bios/edk2-i386-code.fd.bz2
1.9M pc-bios/edk2-i386-secure-code.fd.bz2
4.0K pc-bios/edk2-i386-vars.fd.bz2
1.7M pc-bios/edk2-x86_64-code.fd.bz2
1.9M pc-bios/edk2-x86_64-secure-code.fd.bz2
9.3M total
> locally. Although we have a rule to generate the reference file we
> missed the dependency and location changes, probably because it is
> only run for SLOW test runs.
>
> The test still fails with mostly incorrect flags and different than
> expected NaNs. I'll leave that for the x86 experts to look at.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Jan Bobek <jan.bobek@gmail.com>
> ---
> tests/tcg/i386/Makefile.target | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
> index b4033ba3d1..d0eb7023e5 100644
> --- a/tests/tcg/i386/Makefile.target
> +++ b/tests/tcg/i386/Makefile.target
> @@ -35,9 +35,9 @@ test-i386-fprem.ref: test-i386-fprem
> $(call quiet-command, ./$< > $@,"GENREF","generating $@")
>
> run-test-i386-fprem: TIMEOUT=60
> -run-test-i386-fprem: test-i386-fprem
> +run-test-i386-fprem: test-i386-fprem test-i386-fprem.ref
> $(call run-test,test-i386-fprem, $(QEMU) $<,"$< on $(TARGET_NAME)")
> - $(call diff-out,test-i386-fprem, $(I386_SRC)/$<.ref)
> + $(call diff-out,test-i386-fprem, test-i386-fprem.ref)
> else
> run-test-i386-fprem: test-i386-fprem
> $(call skip-test, $<, "SLOW")
>
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm@nongnu.org, Jan Bobek <jan.bobek@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation
Date: Wed, 10 Jul 2019 12:41:20 +0200 [thread overview]
Message-ID: <af417ca3-248a-d1a8-51c4-46676b6d9d4a@redhat.com> (raw)
In-Reply-To: <20190705160421.19015-3-alex.bennee@linaro.org>
On 7/5/19 6:04 PM, Alex Bennée wrote:
> We never shipped the reference data in the source tree because it was
> quite big (64M). As a result the only option is to generate it
Can we fetch it (with hash verification) or store it compressed?
$ du -ch pc-bios/edk2-*bz2
1.2M pc-bios/edk2-aarch64-code.fd.bz2
1.2M pc-bios/edk2-arm-code.fd.bz2
4.0K pc-bios/edk2-arm-vars.fd.bz2
1.7M pc-bios/edk2-i386-code.fd.bz2
1.9M pc-bios/edk2-i386-secure-code.fd.bz2
4.0K pc-bios/edk2-i386-vars.fd.bz2
1.7M pc-bios/edk2-x86_64-code.fd.bz2
1.9M pc-bios/edk2-x86_64-secure-code.fd.bz2
9.3M total
> locally. Although we have a rule to generate the reference file we
> missed the dependency and location changes, probably because it is
> only run for SLOW test runs.
>
> The test still fails with mostly incorrect flags and different than
> expected NaNs. I'll leave that for the x86 experts to look at.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Jan Bobek <jan.bobek@gmail.com>
> ---
> tests/tcg/i386/Makefile.target | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
> index b4033ba3d1..d0eb7023e5 100644
> --- a/tests/tcg/i386/Makefile.target
> +++ b/tests/tcg/i386/Makefile.target
> @@ -35,9 +35,9 @@ test-i386-fprem.ref: test-i386-fprem
> $(call quiet-command, ./$< > $@,"GENREF","generating $@")
>
> run-test-i386-fprem: TIMEOUT=60
> -run-test-i386-fprem: test-i386-fprem
> +run-test-i386-fprem: test-i386-fprem test-i386-fprem.ref
> $(call run-test,test-i386-fprem, $(QEMU) $<,"$< on $(TARGET_NAME)")
> - $(call diff-out,test-i386-fprem, $(I386_SRC)/$<.ref)
> + $(call diff-out,test-i386-fprem, test-i386-fprem.ref)
> else
> run-test-i386-fprem: test-i386-fprem
> $(call skip-test, $<, "SLOW")
>
next prev parent reply other threads:[~2019-07-10 10:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:04 [PATCH for 4.1 0/5] tcg tests and gdbstub fixes Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 1/5] target/arm/vfp_helper: Call set_fpscr_to_host before updating FPSCR reg Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:04 ` [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 6:58 ` Richard Henderson
2019-07-10 6:58 ` Richard Henderson
2019-07-10 10:41 ` Philippe Mathieu-Daudé [this message]
2019-07-10 10:41 ` Philippe Mathieu-Daudé
2019-07-10 11:32 ` Alex Bennée
2019-07-10 11:32 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:41 ` Richard Henderson
2019-07-10 8:38 ` Alex Bennée
2019-07-10 8:38 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 4/5] gdbstub: add some notes to the header comment Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-05 16:14 ` Philippe Mathieu-Daudé
2019-07-05 16:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-10 7:14 ` Richard Henderson
2019-07-10 7:14 ` Richard Henderson
2019-07-10 15:28 ` Alex Bennée
2019-07-10 15:28 ` Alex Bennée
2019-07-05 16:04 ` [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour Alex Bennée
2019-07-05 16:04 ` [Qemu-devel] " Alex Bennée
2019-07-10 7:15 ` Richard Henderson
2019-07-10 7:15 ` Richard Henderson
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:17 ` Aleksandar Markovic
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:30 ` Alex Bennée
2019-07-10 9:33 ` Aleksandar Markovic
2019-07-10 9:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af417ca3-248a-d1a8-51c4-46676b6d9d4a@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=jan.bobek@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.