From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Suresh E. Warrier" <warrier@linux.vnet.ibm.com>,
agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions
Date: Thu, 20 Nov 2014 10:52:43 +0000 [thread overview]
Message-ID: <87r3wy6tp0.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <54653EBC.2020805@linux.vnet.ibm.com>
"Suresh E. Warrier" <warrier@linux.vnet.ibm.com> writes:
> This patch adds trace points in the guest entry and exit code and also
> for exceptions handled by the host in kernel mode - hypercalls and page
> faults. The new events are added to /sys/kernel/debug/tracing/events
> under a new subsystem called kvm_hv.
........
> /* Set this explicitly in case thread 0 doesn't have a vcpu */
> @@ -1687,6 +1691,9 @@ static void kvmppc_run_core(struct kvmppc_vcore *vc)
>
> vc->vcore_state = VCORE_RUNNING;
> preempt_disable();
> +
> + trace_kvmppc_run_core(vc, 0);
> +
> spin_unlock(&vc->lock);
Do we really want to call tracepoint with spin lock held ? Is that a good
thing to do ?.
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Suresh E. Warrier" <warrier@linux.vnet.ibm.com>,
agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions
Date: Thu, 20 Nov 2014 16:10:43 +0530 [thread overview]
Message-ID: <87r3wy6tp0.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <54653EBC.2020805@linux.vnet.ibm.com>
"Suresh E. Warrier" <warrier@linux.vnet.ibm.com> writes:
> This patch adds trace points in the guest entry and exit code and also
> for exceptions handled by the host in kernel mode - hypercalls and page
> faults. The new events are added to /sys/kernel/debug/tracing/events
> under a new subsystem called kvm_hv.
........
> /* Set this explicitly in case thread 0 doesn't have a vcpu */
> @@ -1687,6 +1691,9 @@ static void kvmppc_run_core(struct kvmppc_vcore *vc)
>
> vc->vcore_state = VCORE_RUNNING;
> preempt_disable();
> +
> + trace_kvmppc_run_core(vc, 0);
> +
> spin_unlock(&vc->lock);
Do we really want to call tracepoint with spin lock held ? Is that a good
thing to do ?.
-aneesh
next prev parent reply other threads:[~2014-11-20 10:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 23:29 [PATCH] KVM: PPC: Book3S HV: Tracepoints for KVM HV guest interactions Suresh E. Warrier
2014-11-13 23:29 ` Suresh E. Warrier
2014-11-14 10:56 ` Alexander Graf
2014-11-14 10:56 ` Alexander Graf
2014-11-19 21:54 ` Suresh E. Warrier
2014-11-19 21:54 ` Suresh E. Warrier
2014-11-20 12:08 ` Alexander Graf
2014-11-20 12:08 ` Alexander Graf
2014-11-20 10:40 ` Aneesh Kumar K.V [this message]
2014-11-20 10:52 ` Aneesh Kumar K.V
2014-11-20 12:10 ` Alexander Graf
2014-11-20 12:10 ` Alexander Graf
2014-11-20 14:01 ` Steven Rostedt
2014-11-20 14:01 ` Steven Rostedt
2014-12-02 1:19 ` Suresh E. Warrier
2014-12-02 1:19 ` Suresh E. Warrier
2014-12-04 0:48 ` Suresh E. Warrier
2014-12-04 0:48 ` Suresh E. Warrier
2014-12-17 12:31 ` Alexander Graf
2014-12-17 12:31 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3wy6tp0.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
--cc=warrier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.